From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next 7/7] mm: swap: remove unneeded cgroup_throttle_swaprate()
Date: Mon, 16 Jan 2023 19:37:37 +0800 [thread overview]
Message-ID: <715cfcd3-47c3-f7f4-7dd1-4d76c6b147f8@huawei.com> (raw)
In-Reply-To: <Y8F9rHVHu7XsBg49@casper.infradead.org>
Hi Matthew,
On 2023/1/13 23:50, Matthew Wilcox wrote:
> On Thu, Jan 12, 2023 at 04:30:06PM +0800, Kefeng Wang wrote:
>> All the callers of cgroup_throttle_swaprate() are converted to
>> folio_throttle_swaprate(), so make __cgroup_throttle_swaprate()
>> to take a folio, and drop unused cgroup_throttle_swaprate().
>
> Shouldn't __cgroup_throttle_swaprate() then be called
> __folio_throttle_swaprate()?
Sure.
>
>> +extern void __cgroup_throttle_swaprate(struct folio *folio, gfp_t gfp_mask);
>
> Also you can drop the 'extern'.
Ok.
>
>> +static inline void folio_throttle_swaprate(struct folio *folio, gfp_t gfp_mask)
>
> And it's not a gfp mask. It's gfp_flags (we have this mistake all
> through the mm). Or you can just call it 'gfp'.
>
>
Thanks for your kindly review and advise, will update.
prev parent reply other threads:[~2023-01-16 11:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 8:29 [PATCH -next 0/7] mm: remove cgroup_throttle_swaprate() completely Kefeng Wang
2023-01-12 8:30 ` [PATCH -next 1/7] mm: huge_memory: make __do_huge_pmd_anonymous_page() to take a folio Kefeng Wang
2023-01-13 14:25 ` Matthew Wilcox
2023-01-16 11:09 ` Kefeng Wang
2023-01-12 8:30 ` [PATCH -next 2/7] mm: memory: convert do_anonymous_page() to use " Kefeng Wang
2023-01-13 15:33 ` Matthew Wilcox
2023-01-16 11:11 ` Kefeng Wang
2023-01-12 8:30 ` [PATCH -next 3/7] mm: memory: convert do_cow_fault to use folios Kefeng Wang
2023-01-13 15:37 ` Matthew Wilcox
2023-01-16 11:31 ` Kefeng Wang
2023-01-12 8:30 ` [PATCH -next 4/7] mm: memory: convert page_copy_prealloc() to use a folio Kefeng Wang
2023-01-12 8:30 ` [PATCH -next 5/7] mm: memory: convert wp_page_copy() to use folios Kefeng Wang
[not found] ` <CGME20230113130136eucas1p18a54a3812792e500a02079ee890e5ecb@eucas1p1.samsung.com>
2023-01-13 13:01 ` Marek Szyprowski
2023-01-13 13:08 ` David Hildenbrand
2023-01-13 19:04 ` Lorenzo Stoakes
2023-01-13 22:16 ` SeongJae Park
2023-01-16 11:35 ` Kefeng Wang
2023-01-13 17:45 ` Daniel Thompson
2023-01-15 16:01 ` kernel test robot
2023-01-12 8:30 ` [PATCH -next 6/7] mm: memory: use folio_throttle_swaprate() in do_swap_page() Kefeng Wang
2023-01-12 8:30 ` [PATCH -next 7/7] mm: swap: remove unneeded cgroup_throttle_swaprate() Kefeng Wang
2023-01-13 15:50 ` Matthew Wilcox
2023-01-16 11:37 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=715cfcd3-47c3-f7f4-7dd1-4d76c6b147f8@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox