From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF505C35247 for ; Sun, 26 Jan 2020 14:48:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 971F82071A for ; Sun, 26 Jan 2020 14:48:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TE6agYmJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 971F82071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F3F486B0005; Sun, 26 Jan 2020 09:48:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EEFDE6B0006; Sun, 26 Jan 2020 09:48:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E05D76B0007; Sun, 26 Jan 2020 09:48:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id CC0076B0005 for ; Sun, 26 Jan 2020 09:48:08 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 87A10180AD801 for ; Sun, 26 Jan 2020 14:48:08 +0000 (UTC) X-FDA: 76420065456.30.bed14_cceda7b78c19 X-HE-Tag: bed14_cceda7b78c19 X-Filterd-Recvd-Size: 5220 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Sun, 26 Jan 2020 14:48:07 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id 203so4375256lfa.12 for ; Sun, 26 Jan 2020 06:48:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=suFPTFq/Jnh/uA1mB3Xjj1yJvj/WmXz4zUasdh/U3Lw=; b=TE6agYmJp5GFdw08Vzg+NV/vbjFAQN87TqO+KUwG+SSpOn/QXw2O5iYkI4V5wBFOd7 MskcQuJgz9OYUgTc3wCtEzUgVduImNspswoMR5iF6Aeljkj9x8+Ij6OYsZMeJPtuBt0q dusBuy9L/4jdf/rIl4Ugr8l3im2nUCt42fx1+bieysOkOovSmCUZ9hhChAnDUD5Wl47C A7zbiIfv6LDY6pcR+3eNEpeqzKBmMVG/i4T8YB8k6ehvMx6mruuC75qtvzU6oRRJ0u9s FcptOHkL02y1q8s1Tw0K95zwucg+aW2S+pCCrs0TgJmPCWAif56/0YZyDJm7kR6nU8Ot eREA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=suFPTFq/Jnh/uA1mB3Xjj1yJvj/WmXz4zUasdh/U3Lw=; b=exrynof07+SL3bGSxcFCDi3VEwTZtH5wdYpk8F2IVINObshNm2Ok9W4pGJftOpyDEH +ckdwZZyro3EKMaSA9sjkHRYy0l15Pl8tIgQhNDeGo1yo30xOLZCIbd4i1XMEK8+3/Oa Hd4p2llsHC0RfJLPrQrmJcRlfSlgR5N7hra7PbBzuaGDoT7VpOYqTDe9436s1LRKIIdp lk0ZJV5lzeBrlNwcqfuTk5oCGlAfgUcDssSpjPhLQMaQ9j45YEhFNLGa9fJiXjDbDjFE PTouC24A7kdZdRUlkQWfft2H8Zjebn5C5He9pYctt0IokCu0VcUK8wmmEhM0LbaOGWr6 ArTw== X-Gm-Message-State: APjAAAUVhwaJRdDDDe7XfNoBns6zfVjgqx/hXTkfjYOUddyOqlaJpVsr xlgy+jaO/NpXnxt0Ebv/Gp0= X-Google-Smtp-Source: APXvYqzrBzQVrNMbr4ufPq5EvI4AI6Akr2T5dAKUbDntDgoBL0+AcsUC3mGSp5/wQzvANInr+4cgcQ== X-Received: by 2002:ac2:4839:: with SMTP id 25mr5664498lft.192.1580050086365; Sun, 26 Jan 2020 06:48:06 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id z14sm6594934ljm.86.2020.01.26.06.48.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jan 2020 06:48:05 -0800 (PST) Subject: Re: [PATCH 3/5] mm/mremap: use pmd_addr_end to calculate next in move_page_tables() To: Wei Yang , akpm@linux-foundation.org, dan.j.williams@intel.com, aneesh.kumar@linux.ibm.com, kirill@shutemov.name, yang.shi@linux.alibaba.com, thellstrom@vmware.com, Thierry Reding , Jon Hunter Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King - ARM Linux References: <20200117232254.2792-1-richardw.yang@linux.intel.com> <20200117232254.2792-4-richardw.yang@linux.intel.com> From: Dmitry Osipenko Message-ID: <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> Date: Sun, 26 Jan 2020 17:47:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200117232254.2792-4-richardw.yang@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 18.01.2020 02:22, Wei Yang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > Use the general helper instead of do it by hand. >=20 > Signed-off-by: Wei Yang > --- > mm/mremap.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/mm/mremap.c b/mm/mremap.c > index c2af8ba4ba43..a258914f3ee1 100644 > --- a/mm/mremap.c > +++ b/mm/mremap.c > @@ -253,11 +253,8 @@ unsigned long move_page_tables(struct vm_area_stru= ct *vma, > =20 > for (; old_addr < old_end; old_addr +=3D extent, new_addr +=3D extent= ) { > cond_resched(); > - next =3D (old_addr + PMD_SIZE) & PMD_MASK; > - /* even if next overflowed, extent below will be ok */ > + next =3D pmd_addr_end(old_addr, old_end); > extent =3D next - old_addr; > - if (extent > old_end - old_addr) > - extent =3D old_end - old_addr; > old_pmd =3D get_old_pmd(vma->vm_mm, old_addr); > if (!old_pmd) > continue; > @@ -301,7 +298,7 @@ unsigned long move_page_tables(struct vm_area_struc= t *vma, > =20 > if (pte_alloc(new_vma->vm_mm, new_pmd)) > break; > - next =3D (new_addr + PMD_SIZE) & PMD_MASK; > + next =3D pmd_addr_end(new_addr, new_addr + len); > if (extent > next - new_addr) > extent =3D next - new_addr; > move_ptes(vma, old_pmd, old_addr, old_addr + extent, new_vma, >=20 Hello Wei, Starting with next-20200122, I'm seeing the following in KMSG on NVIDIA Tegra (ARM32): BUG: Bad rss-counter state mm:(ptrval) type:MM_ANONPAGES val:190 and eventually kernel hangs. Git's bisection points to this patch and reverting it helps. Please fix, thanks in advance.