From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3736CC433FE for ; Thu, 10 Nov 2022 21:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B10FE6B0071; Thu, 10 Nov 2022 16:09:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC0CC8E0001; Thu, 10 Nov 2022 16:09:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D6A66B0074; Thu, 10 Nov 2022 16:09:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8F7616B0071 for ; Thu, 10 Nov 2022 16:09:47 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5EB9F1403C9 for ; Thu, 10 Nov 2022 21:09:47 +0000 (UTC) X-FDA: 80118774414.12.3979E73 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 0058D20003 for ; Thu, 10 Nov 2022 21:09:46 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id 6so2755528pgm.6 for ; Thu, 10 Nov 2022 13:09:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8V1f8WH4dS9mFM23UsEnxE17zMYsQjxoes7ZkH73p5o=; b=Z7HxSIBaw3nRfpZXX1oRZw35iem5t419Zt44bjqY/I8GyM4VVauYgUvZfwT110/YJw 63dnJj0giqkJdC9BFzKSctPalULNi0zfM4cJ15OZASuTEtM6oly/l1E6jF5wA+Aqkv4B IEifLv3vug9FQ0RLR36Dsg1E4eAMFMIIuzrzlHFe9KUnElmaLENnRxE2xu6mAMDjNixR SlynomLnrivhBCqfOzfFvq/9RtIdBvok6G39ehVBhHBuIXBVi7TPlLBlk7RNtcu34jAV 7dLUCbx+eJMKkUS8nhgXSbuwIKVkiunKECoH6dR+SlKLMdN/uArx08lta3hjs+EID7F6 ZbeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8V1f8WH4dS9mFM23UsEnxE17zMYsQjxoes7ZkH73p5o=; b=IB2UUkSwKs7Ft2N8nSfCgHKcyP18//nEgxuUjVoBgG+nmJ98YbqGZEbmyPSueIxyhh NBJfYUYbwyseq4EXJTUa/MmgmZFYkJFCqbVn3H/czHC8t/2FnV1miVWA8rJojjhcc7AX rWRkUF65heSczky13WF1NO9BOAkJ6dwdNUzWmE/YU5T27gwyEEcKuuaIsvs/6mPyjpl3 zxfiGqqelnfb4BzHRiV+aPqBU5+8coF9l3xSWAdA/8O7czP8i6dboMnxrop4vOxGIsgT xNnenuQdc6uuylQUaSbj8TWW4an/yLy5bxcKWM+9olR5AwzfpyzoCAL7/QW/ICVSkVE/ Y6XA== X-Gm-Message-State: ANoB5pkb7K+jylAgm6498v2xGpjp+dBhR4KNmCtu01V/5MI3/VDAyyak 9Crow3KXQBuUQWH9kpXW4V8= X-Google-Smtp-Source: AA0mqf4Bri8I2T54EcfKFNLY7VtGKR62aHFeyc8DIxVdI58xoU2I5SetLJjMAqEzjbAAYmGypG2fZA== X-Received: by 2002:a63:d111:0:b0:473:ef9c:e1e5 with SMTP id k17-20020a63d111000000b00473ef9ce1e5mr726817pgg.241.1668114585852; Thu, 10 Nov 2022 13:09:45 -0800 (PST) Received: from smtpclient.apple ([66.170.99.95]) by smtp.gmail.com with ESMTPSA id ij15-20020a170902ab4f00b001869f2120absm95826plb.294.2022.11.10.13.09.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Nov 2022 13:09:45 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH v8 2/2] mm: remove zap_page_range and change callers to use zap_vma_range From: Nadav Amit In-Reply-To: <20221108011910.350887-3-mike.kravetz@oracle.com> Date: Thu, 10 Nov 2022 13:09:43 -0800 Cc: Linux-MM , kernel list , Naoya Horiguchi , David Hildenbrand , Axel Rasmussen , Mina Almasry , Peter Xu , Rik van Riel , Vlastimil Babka , Matthew Wilcox , Andrew Morton Content-Transfer-Encoding: 7bit Message-Id: <7140E1D7-B1B9-4462-ADDA-E313A7A90A68@gmail.com> References: <20221108011910.350887-1-mike.kravetz@oracle.com> <20221108011910.350887-3-mike.kravetz@oracle.com> To: Mike Kravetz X-Mailer: Apple Mail (2.3696.120.41.1.1) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668114587; a=rsa-sha256; cv=none; b=wUR8k8xR/QDoW++cd8DkIigo9MDt8FA3EPxbZ27Ov8edVyaYt6RuAz5TOWyu6jN97SC7Bi 7WZ1M84XY3aFRhOFTBWwcprNUbWzUwpKtlez1TU3H4Jx5pPC3FRzqlD0dKfHT8lXCQ/h4b uDYaImoEK2ZRAoci5OCBKpbVeyQ9u+c= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Z7HxSIBa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668114587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8V1f8WH4dS9mFM23UsEnxE17zMYsQjxoes7ZkH73p5o=; b=ahzfSOve+RTk/rAZ1D8L5gq5Ssr2PoWi/vTwW0N7XWwwLZlz6V8uQHfkBsNSrO/o5715eI /N8XwQ7p/Jqm+Z0ZreNfObl7jBkIvT+nO4RqgxMW7bGEozxpHCGnHDPs5zx3fRegKqunZg 33dWOtuifzYiISXC7ATcfsPgbZyWyM8= Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Z7HxSIBa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com X-Rspam-User: X-Stat-Signature: j5ipc87hwh71881p99zqb1o4i1t9jufr X-Rspamd-Queue-Id: 0058D20003 X-Rspamd-Server: rspam05 X-HE-Tag: 1668114586-436652 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Nov 7, 2022, at 5:19 PM, Mike Kravetz wrote: > zap_page_range was originally designed to unmap pages within an address > range that could span multiple vmas. However, today all callers of > zap_page_range pass a range entirely within a single vma. In addition, > the mmu notification call within zap_page range is not correct as it > should be vma specific. > > Instead of fixing zap_page_range, change all callers to use zap_vma_range > as it is designed for ranges within a single vma. I understand the argument about mmu notifiers being broken (which is of course fixable). But, are the callers really able to guarantee that the ranges are all in a single VMA? I am not familiar with the users, but how for instance tcp_zerocopy_receive() can guarantee that no one did some mprotect() of some sorts that caused the original VMA to be split?