From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A2DC433EF for ; Sat, 9 Apr 2022 09:38:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D8616B0071; Sat, 9 Apr 2022 05:38:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9873F6B0073; Sat, 9 Apr 2022 05:38:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84E976B0074; Sat, 9 Apr 2022 05:38:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 722606B0071 for ; Sat, 9 Apr 2022 05:38:14 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4BD28251AA for ; Sat, 9 Apr 2022 09:38:14 +0000 (UTC) X-FDA: 79336839708.07.EB05D7D Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf25.hostedemail.com (Postfix) with ESMTP id 7325EA0006 for ; Sat, 9 Apr 2022 09:38:13 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Kb90z0K2yzBs5K; Sat, 9 Apr 2022 17:33:55 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 9 Apr 2022 17:38:08 +0800 Subject: Re: [PATCH v2 0/9] A few cleanup and fixup patches for vmscan To: CC: , , , , , References: <20220409093408.5338-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <713e469c-770c-0867-0dc2-cc7e8ba05c05@huawei.com> Date: Sat, 9 Apr 2022 17:38:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220409093408.5338-1-linmiaohe@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7325EA0006 X-Stat-Signature: w8554mrdapzsk77s7atp8gmrksyyegxs Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-HE-Tag: 1649497093-116147 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/4/9 17:33, Miaohe Lin wrote: > Hi everyone, > This series contains a few patches to remove obsolete comment, introduce > helper to remove duplicated code and so no. Also we take all base pages > of THP into account in rare race condition. More details can be found in > the respective changelogs. Thanks! Very Sorry about it! There is some invalid address in my cc list. So I failed to send them together twice. Sorry for making noise. :( > > --- > v2: > patch 1/9: drop code change and add a comment about MADV_FREE > patch 2/9: simplify the code further and change to goto keep_locked > patch 3/9: use folio, remove unneeded inline and break craze long lines > patch 5/9: activate swap-backed executable folios after first usage too > patch 9/9: new cleanup patch splitted from 5/9 > Many thanks Huang Ying, Matthew Wilcox, Christoph Hellwig, Muchun Song > for review! > --- > Miaohe Lin (9): > mm/vmscan: add a comment about MADV_FREE pages check in > folio_check_dirty_writeback > mm/vmscan: remove unneeded can_split_huge_page check > mm/vmscan: introduce helper function reclaim_page_list() > mm/vmscan: save a bit of stack space in shrink_lruvec > mm/vmscan: activate swap-backed executable folios after first usage > mm/vmscan: take all base pages of THP into account when race with > speculative reference > mm/vmscan: take min_slab_pages into account when try to call > shrink_node > mm/vmscan: remove obsolete comment in kswapd_run > mm/vmscan: use helper folio_is_file_lru() > > mm/vmscan.c | 92 ++++++++++++++++++++++++++--------------------------- > 1 file changed, 45 insertions(+), 47 deletions(-) >