From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AD55C282DE for ; Thu, 13 Mar 2025 22:36:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A1FC280002; Thu, 13 Mar 2025 18:36:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22B59280001; Thu, 13 Mar 2025 18:36:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0575C280002; Thu, 13 Mar 2025 18:36:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D4430280001 for ; Thu, 13 Mar 2025 18:36:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3D5C0B6BE7 for ; Thu, 13 Mar 2025 22:36:57 +0000 (UTC) X-FDA: 83217989274.03.CD5EC49 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id B1414140003 for ; Thu, 13 Mar 2025 22:36:54 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X3cMqFwk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741905414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MEn789IiFnrQsw71niQs8iSfggvunaGbnhoDDl6N9/8=; b=19yERdsSyxIeezaVJ2bcY272OE3npFF/lMhmu/u7ZO+1sC7YzSIixDbzdPvLmfbU2It8+j 63Zv9qzSFeBMZ/brAK6CL3Qv2SunlDbljxmT144mD7vpN57XlKDduiNrl5pr6PI2kV5C0f CwwbOgYZGznodFh0S7lepGIHBgPkL5c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741905414; a=rsa-sha256; cv=none; b=Rmz9fPxp8+Z5Ru2CYBJzAWjcdWvetW0PrbfvwIpezPL5L4RplS9SglRpFgoSH0HXkOL6J+ yR2/DcFj1JEJvPNeh7mWYwSPxA8SgJfd8zdqCiDnhqq/o/0ERQYreLK+QeP+hu/deL9lAk PsL7bkGB4/JHH1WWfa+vnRjogDH0GE8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X3cMqFwk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741905414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MEn789IiFnrQsw71niQs8iSfggvunaGbnhoDDl6N9/8=; b=X3cMqFwkwHSh2z4s0e+xGPOhR7UiknPYaG5cwfE9xYn6B4hhCP41EaFIB5l+F+njGPGZRH OEmPbnROJoLSVwfbY5XRxcQ0iC/M4IstDyXla7cSGzYM6/ld7p1iKFBTisXPX6mNpZ+RDi OCWnDfWccEQGtUhYphC+R34wZJlig7g= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-Kc5LEE-WO2iCq7qehZ7YUw-1; Thu, 13 Mar 2025 18:36:50 -0400 X-MC-Unique: Kc5LEE-WO2iCq7qehZ7YUw-1 X-Mimecast-MFC-AGG-ID: Kc5LEE-WO2iCq7qehZ7YUw_1741905410 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43ceeaf1524so7825595e9.1 for ; Thu, 13 Mar 2025 15:36:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741905409; x=1742510209; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MEn789IiFnrQsw71niQs8iSfggvunaGbnhoDDl6N9/8=; b=H4GWzg5oYd/HSlrtW1+Rn2b5dgJUkWPDofuw7ayEYMDaJiJRBZiV3H6ytIx0nfpinm ULFvVkgYaQ6eEyWNcHTMg1uPLX5j2jo8qKk0zbSzYdXR44GPDcjWSX2GyLdTJ0wk6Qnh O5WkHfXB1s6ldbKoJrBvJ67lG6YW6/oNZt1BPfnIxB9CFokWFZHmX09Eo21Erqq4FNAP g3pO+hO7g/1je7as9kXVpjGtb/73JNUMiYiCx8vLCMBSUWmdUCXlC9ABiT26PCY6qC0V NX7xtpG4BpHP78GdbRsqAB716RAFpu6/dFB4E2lobtZSLCoN8MqNkzGbGwJkL7LZzgVx iI3Q== X-Forwarded-Encrypted: i=1; AJvYcCXO3TDlvZsZTfbQIIBvNPotBe9qk8JIYdVdm0Aq5rbcGv114GFcfnb4WtXe2iEdIwwgXrX/bZL8xQ==@kvack.org X-Gm-Message-State: AOJu0YzDPoKnAaK3JrX2rBbSko4GVLFaFu/n8rutJuFeY3OKrSk/O7E1 dLHAeqqLk1R1OxnY0p8iFCsCWJsaXwJpgJPlsQv4aHRBxpcenZvJQl3RKQxCfUQcro51EqvaFU2 kNY42MvRPxzYYAvB4PZEavPwqweDhjRJoVksswg5AfN/X8cak X-Gm-Gg: ASbGncvFdjdCMNoTtmbkUQXJdpApx2Zgf6Er08bA6Q5Pxt4cBDdr4o9XO+5nPDvQyeL QIFm96baFc9Nnny/dL1YSabudDPxzsoc9B6Q0N5KlogIFm61IjgkJ9gdCLKAFCNiK0uHDUP5qeb e68B/xtOib2Uv/hWYTOwvucYmtZ0RN8tuOd6PUue02AKaAeDEsJxF1zG5NvlwVsZMv7UbeCPeQx clHMS9oSDzshxM3IYUBGA2CzRp8t2uhMgBF9oQgB8sHg0exJGKgpggFT2syDTcQRES9L6mrFLs+ 3cBQZkuDAj8mSHJrW9EFwi9skIjjQumkOVHrrSDu0FrherPPDRWuapxkrDhRyBRViBHLKVuyY/T lLICzHKqTldQKicr9sIdTA5vrxrb4yOzbfWVDz31J X-Received: by 2002:a05:600c:210d:b0:43b:c305:3954 with SMTP id 5b1f17b1804b1-43d18081271mr38994785e9.8.1741905409623; Thu, 13 Mar 2025 15:36:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHogm6Nwm7wQHORJKU3v5xzf+Xl8FpKmWTaZqwSlRET//jXZSRmhmB8USMA7MGxQrcqx8/g3w== X-Received: by 2002:a05:600c:210d:b0:43b:c305:3954 with SMTP id 5b1f17b1804b1-43d18081271mr38994565e9.8.1741905409283; Thu, 13 Mar 2025 15:36:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c742:3600:463c:fbbe:a2df:efd? (p200300cbc7423600463cfbbea2df0efd.dip0.t-ipconnect.de. [2003:cb:c742:3600:463c:fbbe:a2df:efd]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d18a2af67sm33650475e9.26.2025.03.13.15.36.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Mar 2025 15:36:48 -0700 (PDT) Message-ID: <713b6924-a653-453e-8fde-8c966638386b@redhat.com> Date: Thu, 13 Mar 2025 23:36:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] mm/mempolicy: Support memory hotplug in weighted interleave To: Gregory Price , Rakie Kim Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com References: <20250313063351.692-1-rakie.kim@sk.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CniF_majGVpaWCWLhkHZUGnv0IDgpO11Eht-tiZK5IQ_1741905410 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B1414140003 X-Stat-Signature: 3jqs9b6unrfq86ux1k36qr17k8eyxwoz X-HE-Tag: 1741905414-247398 X-HE-Meta: U2FsdGVkX19BKS3pcSuW/eGSnJF1h/Jj1fP/xDWT769wUs/THKOIuWdIygz0mnnTwaFloSo4qoZic44z1oIesXw12iwK8sXl7HhYewo4k5ifg/TbSTS0pndEa3exTdLnTqpzlhYoAHQUYkVF8h7Nk0sKqUsBvzXGYx0TznFO8rN1lkH8Txev74ghKB3zGanmGg9IYu37rL5V8LBs9ISOz2Blz80LNw9tc2mWBUtXHYjQMI3Kc+ov+LOPK2oF4laFarSR7kWPekfB1XESPxSO/5ugf72peAGpJYXEjhB4cVaBjc9rVV212TT7YSW1Nvx98WB0pb2aDZ5wPLxorUblma0wuB1n9p3PC6oshErQ1MDwGISRGcNkAlYnJxaZZMJgC3MTWJcl5s8bkGxS0iLcYIFNCP6GpmwqAmy7qtS+nHg+snJZa64/lCTOIKPEru/IYNp26sfiuAaYQwxOWypWFtTDSA7jcIK4rBx1SW9iUtHDhSbnWpzAH7bGaY6Ar4+Gt1ONwAI4UJPyySIE9U4DxNni9JnYtn3pcIgeAXZjIfqid+A7b2zE1wAE1sy+4yLo7bIZ1r3IOb6H/ChtZpCm2LLOwJm6gnk4S+VJgP7GGs1YdTD7E+xm9DwccchaC44twRAMS0Kboxt41XbBXqpPx7GoSHJiYSgqzUKeK0Ne8WZXYozNGSmRweX7wjVHODjp80C79BFTLLsc842pwl1hJasSKDUC1vtev9aCg3AMmAXCgxlb298rXKKI4RzPrFeoROLVj1lX6Xs0oIF4IlJ+KUXq3rDXz7vhFzhrjsA3gKaFSl8pfWELmrMDgiMUdg6f2dV6cGqQCsXGqH14nDka02EucuGOANMSTu5mxzE/RfsQrUpVSqEsShJI1nOPkToAE6zzJQPYf2ee8ghLqm387SyLtGSNOEqGEauWks0DxezDEcCZtERudkrZY9KvvruJTll8qmtN/nQHvAp/2Wq YG3ptfGp 5OREQ0Jobcoo6MO8MXWsl7Zwdc38VCF0sXojSjqwMswnf17YA/TddpR22WD7ZX+dYJMvik08tHBoaR2cPABd1TUQk963AalfcaqUEpCfebktqXQFRha70yBku8Sv0IwfxZTyNua5FAHHGmcJA+rQcG1OhuAjbk72De84EBzQZlRHRQOis5R1M0pzlGXLFF0q0qqAF2sr0DDsKuZ+WKjPMwb95RNnMqRNKB90e5GdlHUg4eSzVBVxAssbsuZXJdRD6aneQH4tUGYVuHRPe1D/qhAxuEvGMif6vCeTYUJq/wqwWIYnnSrICIN0Yp3ts0Cyu/VoofU4y4TTJuJRODhlx6NmBNT+PQq9eeNBEn21Im8ymuBYue8oeRqq82AGqngPhaRSiQ1zRZfLK8PpT6vIe/LCAurtZm0t6pKqAMc1mCWq0JZuDQtO6rUA/lIiLh7x7OgYSw/RXgNCin/K7tF4JxT8JRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.03.25 17:23, Gregory Price wrote: > On Thu, Mar 13, 2025 at 03:33:37PM +0900, Rakie Kim wrote: >>> I'm fairly certain this logic is wrong. If I add two memory blocks and >>> then remove one, would this logic not remove the sysfs entries despite >>> there being a block remaining? >> >> Regarding the assumption about node configuration: >> Are you assuming that a node has two memory blocks and that >> MEM_OFFLINE is triggered when one of them is offlined? If so, then >> you are correct that this logic would need modification. >> >> I performed a simple test by offlining a single memory block: >> # echo 0 > /sys/devices/system/node/node2/memory100/online >> >> In this case, MEM_OFFLINE was not triggered. However, I need to >> conduct further analysis to confirm this behavior under different >> conditions. I will review this in more detail and share my >> findings, including the test methodology and results. >> > > +David - might have a quick answer to this. I would have expected a > single memory block going offline to cause a notification. Yes. Unless offlining failed, or the block was already offline :) If it doesn't happen for an actual online memory block that is offline after the call, we would have a bug. -- Cheers, David / dhildenb