From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F609E67493 for ; Fri, 1 Nov 2024 01:08:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8001F6B00A5; Thu, 31 Oct 2024 21:08:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B03E6B00A6; Thu, 31 Oct 2024 21:08:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69EB76B00A7; Thu, 31 Oct 2024 21:08:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4BE926B00A5 for ; Thu, 31 Oct 2024 21:08:04 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 093D916196E for ; Fri, 1 Nov 2024 01:08:04 +0000 (UTC) X-FDA: 82735737756.17.5D3CF35 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf04.hostedemail.com (Postfix) with ESMTP id E437E40018 for ; Fri, 1 Nov 2024 01:07:25 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730423226; a=rsa-sha256; cv=none; b=2LAK3SK68CX0tjgBrX9r/CczCPJBfwoZ+9Fqovvsge+aAujZPgJqRXrfJc+DZWu0PMhuYK 18l2R9ALmiKOBJhQolm5DAjL/niTipx6fzQbbXy2aCUMg3O5nnTRt6cHKEQLrFdUuacKWl MQ7TwguClRil2Dfw8Li0ysLOxbcAtu4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730423226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2lQ2nAgSHUHmeZcKaLEGPghYoMzhELv0eOsdB74lYAE=; b=uz1lUexT2KK9f5aSY+YU1sHDTqg0Rt07anCWDaIEMuWMLFBIv12oarS/uxgRrev35CQ7oY 4SyuMYUf9BH0T9DtbWs/4CX7ASWfXjdKpJzcNOqXSk7jb/S74xsxKw566J34K/PAH/UAUK VQh19q9nbmT+12SIDicSw2zAwJAlYV8= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4XfjPW3VYszQsbR; Fri, 1 Nov 2024 09:06:55 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id C31A51800A5; Fri, 1 Nov 2024 09:07:56 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 1 Nov 2024 09:07:56 +0800 Message-ID: <713a2c5d-e6e8-471f-96a5-1f54fe2d35b8@huawei.com> Date: Fri, 1 Nov 2024 09:07:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: shmem: remove __shmem_huge_global_enabled() To: David Hildenbrand , Andrew Morton , Hugh Dickins CC: Barry Song , Ryan Roberts , Baolin Wang , Matthew Wilcox , References: <20241017141457.1169092-1-wangkefeng.wang@huawei.com> <20241017141457.1169092-2-wangkefeng.wang@huawei.com> Content-Language: en-US From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspam-User: X-Rspamd-Queue-Id: E437E40018 X-Rspamd-Server: rspam01 X-Stat-Signature: 5bgmmgzn7tfurbf74ncdjnw9wgehgfpd X-HE-Tag: 1730423245-77933 X-HE-Meta: U2FsdGVkX1/gxrg25uqEHRwEnFoejhBgFLjw/6/Z2OTjw1t5QF+FVVYGiNJBoqhl01xYY2cCRz+uWYCJVld80XpzBKBcyxDA2Kw8AZPHj1ihytuC7HvTAdzKFBQY3Vyku0lxycz5DBMwRa5D9ph7JfAeZ9hM39/JVs5nIrvp9ij5asUemGGu+QBTlXkjLhHIJdp1KJY96okoWzaxFDTOQmTNbtuy3R70lha56gWe+dBd8vRZ4bjM/c5JtniKEzC3udSjwuPQ4vfvv1PVZcr+8fIiaaOKgLPO58dHK3VQPyfLGv4+o6j82TcVbWufqotHbVkmKIfCLXF34jVjpdLAq8Jg0i58QPliw2/0qQKPMRd9OgMzpJq0acETQwVGwVCbfJMnZNcc0yGFSpoXEYP3jhpJX1KzldjU5QF374Wh6UD77CMPaOgp5LX99O6VJbfad925nvX7k+vh3dI4Bk4lZbyDrkWiW+kipQwbyByb/N6jBxTVbpJP/RgQwgbExnIY4ctq3yGqPoRPGGKi8CxF5/qqj99Mx4NEvD3eKkvLJHEkKlxIqj/IyRwOLQTADmy9dD7rn6FW0JEg1Mh5CrAXKKIonAk9jsMN/HTxX93l9j6U3Zr0Od2c71ONafzuoaNyOCzoPKPNIcXKjxtsYyYFtaKmeDQSu+zs3QXyw0oOySKyuYQya6Ovp7m1sNDFBvc7GE9LVFmQw6GVsQiFszr9PfMWmHjFWteJ2RupYHst5Kh1YFUbk5qZ1a03Od8aZtCO6jWhSoeJBb2aRPNOAl3KBTHId049VRqdn353+ED4Bt4Kq/NA0KaTXxvPRC1570l45e06qrEe482eFLA2nhWShdpsu+5UjIy1E3QpbLEYVny2qwIy1o7mybzDxF8Ws6xomGYRVEu+TGNJ0vZW6NGSJx0sqdUnL7axdeHha2U4hpcaBeb4eRMH8bujHU213gZHzI9jn2nX4PkqdcD4Cyh ojPC611B cJNihd8rZJwik4hg3cfzGnuDRvgnXc2ZERL3dWbMUtFybWK1XEVMv29gbB2x6TuvRYkXS47bac07Xmz9G95GsgEKNdPdZI8TmjGe3Vwckx+V0aDb5Wz9INlhleqK8HqWTngUTw98Sz35Gl/KWCM4Qvvejhdxvh10GreXqNhVvkfQ8O+ksFXxQtid3L/qrTLDpmbHmzkM+9WILWqI4LKeDLo1Krl1CoFUQYvxVzulTnMuGPV5hc7fuays3vjBmx+u7dKObhZkI9ndvjkh533uCfFSzZW4tzjTfppTb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/30 21:09, David Hildenbrand wrote: > On 17.10.24 16:14, Kefeng Wang wrote: >> Remove __shmem_huge_global_enabled() since only one caller, >> and remove repeated check of VM_NOHUGEPAGE/MMF_DISABLE_THP >> as they are checked in shmem_allowable_huge_orders(), also >> remove unnecessary vma parameter. >> >> Reviewed-by: Baolin Wang >> Signed-off-by: Kefeng Wang >> --- >> v2: >> - Add RB and send separately >> >>   mm/shmem.c | 33 ++++++++++----------------------- >>   1 file changed, 10 insertions(+), 23 deletions(-) >> >> diff --git a/mm/shmem.c b/mm/shmem.c >> index 247c0403af83..e933327d8dac 100644 >> --- a/mm/shmem.c >> +++ b/mm/shmem.c >> @@ -548,17 +548,15 @@ static bool shmem_confirm_swap(struct >> address_space *mapping, >>   static int shmem_huge __read_mostly = SHMEM_HUGE_NEVER; >> -static bool __shmem_huge_global_enabled(struct inode *inode, pgoff_t >> index, >> -                    loff_t write_end, bool shmem_huge_force, >> -                    struct vm_area_struct *vma, >> -                    unsigned long vm_flags) >> +static bool shmem_huge_global_enabled(struct inode *inode, pgoff_t >> index, >> +                      loff_t write_end, bool shmem_huge_force, >> +                      unsigned long vm_flags) > > Please use double tabs on the second+ parameter list. Ok, I will send a tab fix patch. > >>   { >> -    struct mm_struct *mm = vma ? vma->vm_mm : NULL; >>       loff_t i_size; >> -    if (!S_ISREG(inode->i_mode)) >> +    if (HPAGE_PMD_ORDER > MAX_PAGECACHE_ORDER) >>           return false; >> -    if (mm && ((vm_flags & VM_NOHUGEPAGE) || >> test_bit(MMF_DISABLE_THP, &mm->flags))) > > But where is this check for shmem_getattr()? In shmem_getattr(), the vma=NULL/vm_flags=0, so only vm_flags check is enough. - if (shmem_huge_global_enabled(inode, 0, 0, false, NULL, 0)) + if (shmem_huge_global_enabled(inode, 0, 0, false, 0))