From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F557EB64DA for ; Mon, 10 Jul 2023 09:53:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB86D6B0081; Mon, 10 Jul 2023 05:53:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A68F86B0082; Mon, 10 Jul 2023 05:53:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 930A56B0083; Mon, 10 Jul 2023 05:53:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7FBCE6B0081 for ; Mon, 10 Jul 2023 05:53:46 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 45DE28017E for ; Mon, 10 Jul 2023 09:53:46 +0000 (UTC) X-FDA: 80995240452.05.4670B83 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id 09C802000D for ; Mon, 10 Jul 2023 09:53:42 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xz6F2AKC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=KxXe2n8v; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688982823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JhQYnd3zFReOIgvPmbBH7euJHgaFU8/SGouVRAGqJOg=; b=3ay6BpTPBjcxn78L8iDHECor8lQM+atICYytRS2GFI2S6LxnYCKnMZU9uuTNeKS12cuhYz rVzuYpTgDqdrv3ue1sLJ6W50J055g++F1ooS7TJxCmKE8l54afYvEgHapZy98JpTBaHD2g 2Esyj5WXt02DseXAKlGA+ua1I1op73k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688982823; a=rsa-sha256; cv=none; b=6Yq5JhM+shpzdmEKVEJHrOA5IPD7DJ9vU+ZZ/22SuyjvFCjg9v6Q6lyvgAwgZgW69AHCsT jeo/3jAW+gfjN3L1NY0slNH+kVlyJHhe/9YXwJmKCzYNfgaHeYnvUI1gw68mMV4eIGEtBz h98ixBUFWUvKR5iZNEwFefKNqP63RNc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xz6F2AKC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=KxXe2n8v; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 31F6021EEF; Mon, 10 Jul 2023 09:53:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688982821; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JhQYnd3zFReOIgvPmbBH7euJHgaFU8/SGouVRAGqJOg=; b=xz6F2AKCngY8+kyCyaqPfEcdl/9pcM3qK2zlApTNfnsSSmRxVEU3rLnQFOr3wfH41rieYI sRPfjnTsRQvKqbS2pAKF3aE+T5KN5gJtoCEawvbbRLMT/seMfiZl2ioO8QBxA7eakSAUlQ +z0vApCAa2POQfyJ1ZHAR018OicX224= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688982821; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JhQYnd3zFReOIgvPmbBH7euJHgaFU8/SGouVRAGqJOg=; b=KxXe2n8vEXVhRArC1cbLwHAKno2ehlhMjN3Il+S6ofIu33K36fXvi3jmMrt+MwzWVdECPY zFnWDd0kaYFTx7Dw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5A11213A05; Mon, 10 Jul 2023 09:53:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wcRGFSTVq2SsNAAAMHmgww (envelope-from ); Mon, 10 Jul 2023 09:53:40 +0000 Message-ID: <71313e6c-79d5-3ff7-981e-f7675aee0a5c@suse.cz> Date: Mon, 10 Jul 2023 11:53:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] kasan, slub: fix HW_TAGS zeroing with slub_debug To: andrey.konovalov@linux.dev, Marco Elver , Mark Rutland Cc: Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Vincenzo Frascino , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, Catalin Marinas , Peter Collingbourne , Feng Tang , stable@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, Andrey Konovalov References: <678ac92ab790dba9198f9ca14f405651b97c8502.1688561016.git.andreyknvl@google.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <678ac92ab790dba9198f9ca14f405651b97c8502.1688561016.git.andreyknvl@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: rwoyeyejje91414grnxjyxfnyx4i5bwp X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 09C802000D X-Rspam-User: X-HE-Tag: 1688982822-552924 X-HE-Meta: U2FsdGVkX1+imM6k7BAxsygxwrrLFRTLWGl2J+F5pYKMnmlzqSO03vxXJ4/cPBwE8eh2X7X1VAJ7GOlAk2IEcvONjkSQATY8s3O0xzEksoYV07lDr2tdt9yZKYnKEjDyRmCnRKMCVSMZ8YohSG9Q75t3VkiaQkdPn8Qwe6UjEgpLfnpW2sG9t6G8Yg+J+gW2UzLdc2rMyzFPP4EX2faEbokWZjfq/eK9s+6RiCPYAL5wcQsx6ewcZ4cDNtfH331IrzxEyrkBclX0kIPwmi0zOoEc/M/DdhwckGj3VVVDPhi1e4zoAbll37m+vPPnhbyDC+BV/MvDzPALQ+oEYnzLyS5p0a6eQ5AJ8BMv5KGqQQuFPwxqPqPb+tgMKMKSKXhg07SOI37Jjwd4iaztgeakbqSm2BkWfZ+/7CElgsd1LPaoj+tb+zLVLL4YFVj1bNls4Icb2brfLVz5eFqKUVHV8occl6EKnd/BCw/d0Xlm7OeNUZBQivyKv9ufM3ofJNqrS3dKYuFrjrLQZ+bN8ZR984hjjeB4eN8LtXh79+Q3grNMEJAAtxRWcXJ7gZKD3SvbDMGwsq3ldc99iJZ+oXJwxHwbRL9d0AP22yOymmuk2YdhY+OUiQQiNoaUKEwTEPm0vJ8Ezvf/dM3aYvrXh0w2spE82WPhsYwl8ri47vSt3t/iRQ++8Rk+lDaULivWLNbGXHTJItwVPJ9UFGAvSrttaFJhmASG73QdhSTact/cW/HjN5Lb7+5L51Wp2WPDhNuJRxtrshhmiAkNKi1YxnWqni5t4GxmyzovJU+9tvLkNzX3fZezHhdYB4jhW2uvc9x/JoLRGCoXVko5LoJMKXZLiaHMXw3/sXtTFkHxOqB1bj+LnKZKlTGiu7MtY4X+wgitmYS3Cl2S3784gXbGE6GAzrfrUrUSn1AiPa3KSy6zEymI4Krgjk3uM3bBkbMg/7HOL3fAFltqIeL4yQntdjq sdyLBTS9 HWlZU+IleHct7EuJKZut4b87V9/xCXFWxGtlVijr+5KCUmw4AES4jw7cmWmEC0aDpHsdYrSoYihVzrHmR4yf/l1I/kApVIhuxMzAk8SmAblgxDa7KFU9Bv1bXUVzVjuvC4BeuSt00XmIhcrWhEehaTcVBkehdJERihBxqKC5GQHFnxgE/ro21sFhx61Eh65h1jrsigdDYUgZ7eI1XszF5kZUtS7eUDSTKxgFP8Wj2JomgAu+eBAXa/ziB6D1zIVA75uaS5HyV4r4axZ2OmdPNJO3/+GuGEmzNmQodBPUmK6cHOI1oEstz44OLySqWXIvCOKI/s6d/F7BM1pvlUl8Lofn14736J+bKSe3MF2CjH+1swrtwxDSMdyppfNwQ/mUugGDy+3kBvN5gpcu7F+1CBIrAPuBk32RZpB+jyKq/zkMFg3+HaF4v9T08F/qt1bimsgNwjiCrwLa96eI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/5/23 14:44, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Commit 946fa0dbf2d8 ("mm/slub: extend redzone check to extra allocated > kmalloc space than requested") added precise kmalloc redzone poisoning > to the slub_debug functionality. > > However, this commit didn't account for HW_TAGS KASAN fully initializing > the object via its built-in memory initialization feature. Even though > HW_TAGS KASAN memory initialization contains special memory initialization > handling for when slub_debug is enabled, it does not account for in-object > slub_debug redzones. As a result, HW_TAGS KASAN can overwrite these > redzones and cause false-positive slub_debug reports. > > To fix the issue, avoid HW_TAGS KASAN memory initialization when slub_debug > is enabled altogether. Implement this by moving the __slub_debug_enabled > check to slab_post_alloc_hook. Common slab code seems like a more > appropriate place for a slub_debug check anyway. > > Fixes: 946fa0dbf2d8 ("mm/slub: extend redzone check to extra allocated kmalloc space than requested") > Cc: > Reported-by: Mark Rutland > Signed-off-by: Andrey Konovalov Acked-by: Vlastimil Babka Thanks!