From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9EB9C28B28 for ; Wed, 12 Mar 2025 16:16:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63804280002; Wed, 12 Mar 2025 12:16:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E684280001; Wed, 12 Mar 2025 12:16:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 462FD280002; Wed, 12 Mar 2025 12:16:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E4319280001 for ; Wed, 12 Mar 2025 12:16:54 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3D08655BC0 for ; Wed, 12 Mar 2025 16:16:56 +0000 (UTC) X-FDA: 83213402832.17.FED2528 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf22.hostedemail.com (Postfix) with ESMTP id 09D7BC0005 for ; Wed, 12 Mar 2025 16:16:48 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GMj1FHqk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8Xp5iAxR; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GMj1FHqk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8Xp5iAxR; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741796209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ppOhyx0kE4ei6ipVBks4/WS+k6TC55C6fYxiAo4Xs3Y=; b=LfGRXspTT4FUunlfJPMOlFYS58AwXK1U4HeABrCwYQWM6wlbkJLav7czLwogw/fxnOHgZf LdqMqV3ZtsrtMfCzC8g0Mz+gIkTf87do8ECIdmYbDiHH2bHlxwd9siAbTxoBBpuRrThQ4C WIqgRC5V2lr5w7yPRmPcTGdhjmvi5Dk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GMj1FHqk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8Xp5iAxR; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GMj1FHqk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8Xp5iAxR; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741796209; a=rsa-sha256; cv=none; b=7MmperiDlSgAq68RODChEdlM6597dyKR7Gp49v6X2qP0NSqe4N25658DkraKoElE3U5Ruc WoRjCOTgH8upN+thKxb2bKP2XN5EYaJF4Z6ik2ZstfOeDyTo7fmYHKwSf62598L5tBA/vt fYOKsCHqmOUgzpxIPw3fQMBGJnBxUmc= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6391C1F388; Wed, 12 Mar 2025 16:16:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741796206; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ppOhyx0kE4ei6ipVBks4/WS+k6TC55C6fYxiAo4Xs3Y=; b=GMj1FHqkciFjlfl2AbEeGCyGdU+HLEtzneLUWGK16/ZDxRLJNsrFKTI2Db1/c3rwIErFWh MyeA8bpbRNpAURd93YMDpiTP44d0m6DWwtpko5eH9l1Aw/gih2F1oGnfgKGSHCTwrFhl+z ApW92AV1wP0PkzwWLWmv19MyuKXuZso= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741796206; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ppOhyx0kE4ei6ipVBks4/WS+k6TC55C6fYxiAo4Xs3Y=; b=8Xp5iAxR/kq7ggDTGycn6cEhGYwSIn0zz2Ajays4o20u/gBLUvXJArlJH8RhsdSjKBmlMn mkeeJHmMEir5rlDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741796206; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ppOhyx0kE4ei6ipVBks4/WS+k6TC55C6fYxiAo4Xs3Y=; b=GMj1FHqkciFjlfl2AbEeGCyGdU+HLEtzneLUWGK16/ZDxRLJNsrFKTI2Db1/c3rwIErFWh MyeA8bpbRNpAURd93YMDpiTP44d0m6DWwtpko5eH9l1Aw/gih2F1oGnfgKGSHCTwrFhl+z ApW92AV1wP0PkzwWLWmv19MyuKXuZso= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741796206; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ppOhyx0kE4ei6ipVBks4/WS+k6TC55C6fYxiAo4Xs3Y=; b=8Xp5iAxR/kq7ggDTGycn6cEhGYwSIn0zz2Ajays4o20u/gBLUvXJArlJH8RhsdSjKBmlMn mkeeJHmMEir5rlDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 46F051377F; Wed, 12 Mar 2025 16:16:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Azr6EG6z0WfkHAAAD6G6ig (envelope-from ); Wed, 12 Mar 2025 16:16:46 +0000 Message-ID: <711b5e47-ed20-45a2-a912-42db5491a25f@suse.cz> Date: Wed, 12 Mar 2025 17:16:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 02/10] slab: add sheaf support for batching kfree_rcu() operations Content-Language: en-US To: Harry Yoo Cc: Suren Baghdasaryan , "Liam R. Howlett" , Christoph Lameter , David Rientjes , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, maple-tree@lists.infradead.org References: <20250214-slub-percpu-caches-v2-0-88592ee0966a@suse.cz> <20250214-slub-percpu-caches-v2-2-88592ee0966a@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: f7aum54zm7uk5zras7grws5ne3fx93zj X-Rspamd-Queue-Id: 09D7BC0005 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1741796208-142103 X-HE-Meta: U2FsdGVkX18m88PQwTzpfw1NVXK0Kkk3j6CP76CdTrVr+NRB03acQxyXDcxwDW3mXxdx/pqa3DNy0DggBedBbeOpWONK0Jl8D66pRy2q2mAW+vBot9jubyGsXtDoLIiHB/UFtzg5G3S3L6liHiXZqax1SfYp+/7ktt64XGphZMJXZ95ZmZknzWTjqbe61+8mzyGJ8VBUzzqQ3zQanxw4TApyCfrw7HYeBiGyUc4sBG9i58ilB5PtEaG7O+yPORSWx9j/hkGWtpJGC+SyEUHrrTBRbEYTo2w1M8UgbmAtCnjQPnlBQelOPCjzcwAdYbMNMSjfWRx6j2kiyzJ+NTr8VKsWpzKsBKCiVA85EKsoxL6fADHvtc3EwXZOvdufLRt626krQEa1W9979T++RDbcNTob34uc8BA9KLXlId2vSxYbCvvZp9Gl6DDwMZEn2sSpgtobykJ9qbABTvcrFOMrkXJFjG++ssyukqP6t56zyQ8dHtgQEqPX1WFdZLNS9bAmRpzpPJXW4qZxiho2AywPSx10yGMF3QX174BgD9IC6fJmC9+fJQbjgNQQGYT1XdlnecCuQmKjaK/Ed1Lqj8IKUvtm/v3gOffJ9uWrhFhW/T5wM+T7cJMbX6D5hgHkht9IjBQP3N5z2YKRuDre9LSOoKw5aEvWiDk0KmU1hZJgZ3JG5/Gqn7lQ/DR1fAEPrAm2UgBiTRfbIGsM4qQ2ozmpZ7nPHMXibXr3l+8zT5De0OFFvfNNYf1PMERnja0J3D4mJYbHNYwV7SlxzjIEmEy9rrElEXmdxvZLihryTYyhNwNm671KytyPUP97LsVSolEHE37ToUTfSCLnehJ7Vg4QRPaZ80nmY2adMNUyEdGLJZyX+ALK0kgfaJyTSMyotIXUPSgYBFVwx6rApNhlWL5SzShU5D6oOQND1ZeX2H2oZtEmrRT0cGr+88uvPTNob2F3Kfg3W4zm6yAgLrD2mSS PO9EsaKn /NCV/hKlPGMAziIEndlxhTc0Yy1+bm7JNzRzaDtkYEXi9QCFtP0091jcE3d11Rs9IeAspV7ZHz08muV2/csMscqgUSGsv+2foB7fgxqgBCHOY5wsSeeiQA1UOHh09IRDFjTmgUqHHCAU61lqYcXAPUlXXXYbMsXmV3bnJ6e549ZyfNM3oKFmAdqkWupdazUV+0Nnkd4dTQ0HnvjApv4v4Hdkr4Axz3xB4I0wiLoQHZ1muY/kbfbfdU6SaChzwZ6PTjH60YsyX+gMDQKfoFXy7SnRX1BVEC6L8M9brZrpSb3VNfp8JvpcnPMRUKI4Yx4rBrCG3ZUPu6itfBnmvMD7VVjlmCLFmi6MgWOLN+V0Z02PfUOvnqIQIpCkxXCzdLRXCPq3nVRdg81oZ3X6nG9TtWH2Scw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/24/25 09:40, Harry Yoo wrote: >> +static bool kfree_rcu_sheaf(void *obj) >> +{ >> + struct kmem_cache *s; >> + struct folio *folio; >> + struct slab *slab; >> + >> + folio = virt_to_folio(obj); >> + if (unlikely(!folio_test_slab(folio))) >> + return false; > > Does virt_to_folio() work for vmalloc addresses? Hm, no. Good catch. > Probably it should check is_vmalloc_addr() first? Yes, thanks! > Otherwise look good to me. >