From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A146C61DA4 for ; Thu, 16 Feb 2023 09:10:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5025B6B0071; Thu, 16 Feb 2023 04:10:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B24E6B0072; Thu, 16 Feb 2023 04:10:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 352DA6B0073; Thu, 16 Feb 2023 04:10:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2532A6B0071 for ; Thu, 16 Feb 2023 04:10:39 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EA10FAACEC for ; Thu, 16 Feb 2023 09:10:38 +0000 (UTC) X-FDA: 80472584556.18.A9CD001 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf20.hostedemail.com (Postfix) with ESMTP id E505C1C0020 for ; Thu, 16 Feb 2023 09:10:36 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=ehpbVRDY; spf=pass (imf20.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.167.44 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676538637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=itpmqCRSbaIVC7wZtfr9HbCli3IWfUbTikhRIPulXqo=; b=1MmWUWZVLPdZRE0/LHeS3mQ4BnjTsBwbzEmKeJVHTvGcJ5KAepTM8JBug/9PDVKminkDKD cadQuIhCMy37UlBGMFUl9O1rc4Xx+YoBqziD1JBWwNbBfcyIuX3ze2U5kxnmTcyG9FcPH/ pI5CVVdJkqsw7UA640b5e0Rhq030Tds= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=ehpbVRDY; spf=pass (imf20.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.167.44 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676538637; a=rsa-sha256; cv=none; b=4odgFL+YChPWnIhlEw/EXfDPcd5gubFcmadUJRPr13GVZzuwR9dlcCm1jO1f+J7zimDFYI X/MDR9A1lLyTsSMj64RgkyEv9GU+cS61lcvNrAiH+QrA5VFQ2gsUZw0VMQa5tIkc6XXTqr RcfLS4qglF1gVOtqpqT8Ez7K4ha1aBk= Received: by mail-lf1-f44.google.com with SMTP id cf42so1974310lfb.1 for ; Thu, 16 Feb 2023 01:10:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=itpmqCRSbaIVC7wZtfr9HbCli3IWfUbTikhRIPulXqo=; b=ehpbVRDY3uFTXff1WZrb6WzdSKIUhNZKsSYQj+UUJ9tM4zj5sKYMMEnr2n0/mMzn/o IecrjHyF7rqlAAAr0WXGO/Ou4CQWwvq4ZdaGLW6n9piiT0pmaBCHTJARw3TxpUoZfwim ASsW9LVa9EB64amERKkSIZrA4RkOAajtj/XTJlY+n2AOWieHVDCD5B5Ret+Gxsg7mFVV Vry1hqxCXl1i4WP+jUXmGt3XZLHNge0QPVZG+WCZjm2ONoixoQpWa21B9LY92Lu2UvJU 0OT1aL4himfNuIXrdFYrwOeOtzCie75xXunGHoVbinRum48bgpgsmeWgYM9ONIqtcZqJ Fyzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=itpmqCRSbaIVC7wZtfr9HbCli3IWfUbTikhRIPulXqo=; b=YXD42vsBOBy4+wMzxK3X02XhM1n/tyV/HQg7AZTMxJQpueHhzTtD1YEVbLsdabEL+F GD+rvywJk8UpqOqEuMeIQaVtfdFWJQGz2Ws2J/oCDAnnbqvdl3ruxGWW/MifWFyByO/u F/kvPjLRhqhpPl8rcVDMdW6hrGrTqNoS3OjCNVoJMDlDm/cYyQOkRRkl4wNCZrtXtLTx tlXZW/F631H7MwCUCKnVBqw0xRu3n0xgT5ix7U93fokwSps5Qg5PeNBhRbVezsj7bKpZ 5UKC2JJlS5lZy/a6yuJTLoFFTwbJEL1j/Q+57dopf4CDvYe8nTFKLKGS0GJQnLULvHtT c60g== X-Gm-Message-State: AO0yUKXZG163zijTdlDzXjRdTlj6F/K8xEKXgLHEIyoyxMyp2W7rfVjC x5FFAy9uXqsELD/tj6tVU5umqQ== X-Google-Smtp-Source: AK7set8ACLYGt8o/dN9L05F77GXMyAo0T/IhKox4F0xKScHW5FBT6vZ462WamvK/b6Hz9W8WtuuerQ== X-Received: by 2002:ac2:5ec8:0:b0:4cc:7ff3:ab4d with SMTP id d8-20020ac25ec8000000b004cc7ff3ab4dmr1530785lfq.20.1676538634978; Thu, 16 Feb 2023 01:10:34 -0800 (PST) Received: from [192.168.1.101] (abxh117.neoplus.adsl.tpnet.pl. [83.9.1.117]) by smtp.gmail.com with ESMTPSA id q14-20020ac246ee000000b004d6ebbad989sm220855lfo.1.2023.02.16.01.10.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 01:10:34 -0800 (PST) Message-ID: <71078188-1443-d84e-658c-967991f3b590@linaro.org> Date: Thu, 16 Feb 2023 10:10:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 2/2] Revert "splice: Do splice read from a buffered file without using ITER_PIPE" To: David Howells Cc: Alexander Viro , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , "Matthew Wilcox (Oracle)" , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mm@kvack.org References: <20230215-topic-next-20230214-revert-v1-2-c58cd87b9086@linaro.org> <20230215-topic-next-20230214-revert-v1-0-c58cd87b9086@linaro.org> <3055589.1676466118@warthog.procyon.org.uk> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <3055589.1676466118@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E505C1C0020 X-Stat-Signature: zo6rtn4zz5dqc3ek5a67ms6r8fukj3d6 X-Rspam-User: X-HE-Tag: 1676538636-261998 X-HE-Meta: U2FsdGVkX18y7QAEzoqYG6Pg4r2mG8yrMBBk++ar+3z5uSAUR6C0dLYeUnkErzB894NLDd07cIS8F8g/aMS0jHhc7xF0ZaJifMDGUVHlvCb9Bf6Ijfcg9Mvh7ccIo0F2AxJPoacIdJyLO8KZFxawfZdScCSWB6hVWrt/dzhWuXbkmg8DTl4sa2DPM/TaZLozqykSDZF5KRugnz1VeaXggSxEHkA7Nfrc6mPY6FU0erGJlLGiElXw3B7akYkDnunESiwO2GOG+dmIUpvKIhlOP28uzFPRQa1Yvj0roIu5BUWhgIoU8jfrp4ERgxwvQ47xF+VqM8djJWUfLwf2L/VsFic449BJtsKbxWfaHvOUV7r/2WdWRLSc9/1pcVceLXzWWck7PPuqOtvhnQmK2yy9sFMjHQsTzbwmFTLS8vbnOB1nJemhG96VaD/fr8C8Nhe5DguqUvRAKnAIU4n0AMHeTctGzlcmQbLcwdFegmnLGVj3ndUhfThlqhYYI8YeB9qBJjaeFBkxvePGwuc9S/XMsyI09ILLbnqJbcvEFxMDJEB7PNSut/PVieNWc2Ko7/ukc06Nt80Hd9x7cpODcYy1rufRgB/kXsWKkys8CFOQsmIZZqdBpwowGP9uXBk6xzKlTEiXyevfBS4LRDuAxvAwYpzxHPU8YBA+BY1gun5X7nmSSw53wGmqxLGC/R+y3lCv2NcKy1NrkrCzF01MhMlbFVtPJ1edyacndaLhifpm9fj3ABo1USqEewUmFmQtJFxYxmmgKoFYSrQK5YcMYd5/Xe1TfIb47bEX5Na+cTmWbIpvotnkjEzqQrblONIaoWoTd1EeVYP+KBCF7GGxkP9kqXuN5KYvt8zQofEQD9iXvxb6p4vjPvSg3BNw/dRcrnxEa9JeTVIRx3KVbHoh7w0Z/djDUG6otVHcbSlzina0CSyUmAoFJXDi5hNv/Gn/62g9YvT+BT6nbq8E4EHONl2 qwDal6q4 fYWaT+MjSwfpQx3eY7Iw+zY4aZ2cDl6zjXxUWmWfGFu/wTGEKGQZublu/pRsD947J06J1q8QhIN5Hwdn85DFtA1ccsXWhRwaRGZGAPqMR6gDFyW/lFtysFzgIxh2sI+uE/4UAXnigsZsMdL0orXlevc7q+tOtITxKaknDGXkQYAJB7uuSsda1+kDJnhs9NX/BJ+rCg8ohC0DYW8+v7dr7mOaMx38jU5/g7NH0hUMTvvRa/kh3veRq+QGB97mtNf3/UtPG1PgB799En7ZAfrajcG+sGOiOVCZQwpgRgVvzEEReNXav1+asjUbzpvPEfmWUdscFWNiuE2uAb/v2rarkQobBmFyonSSV9YODlWAAftQbX/W6Vf2HjfOAfI9WtA0HXevehyg7SdE9zt/4ccjlokSij0QbRMBh6LRx+PyXT/qFiSrdcrzoMclCFbRwvPkZ2wNeJnlJCwipUqrlhQSk+6NCbSw+62r3zugopMTVxOP9Ajax4s1uD580sGd/DaYgu3XO7JyxsfK+OVWV0W25jYW17A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.02.2023 14:01, David Howells wrote: > Konrad Dybcio wrote: > >> next-20230213 introduced commit d9722a475711 ("splice: Do splice read from >> a buffered file without using ITER_PIPE") which broke booting on any >> Qualcomm ARM64 device I grabbed, dereferencing a null pointer in >> generic_filesplice_read+0xf8/x598. Revert it to make the devices >> bootable again. >> >> This reverts commit d9722a47571104f7fa1eeb5ec59044d3607c6070. >> Signed-off-by: Konrad Dybcio > > Commit d9722a47571104f7fa1eeb5ec59044d3607c6070 was part of v13 of my > patches. This got replaced yesterday by a newer version which may or may not > have made it into linux-next. > > This is probably a known bug fixed in the v14 by making shmem have its own > splice-read function. > > Can you try this? > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=iov-extract next-20230216 boots fine again, thanks! > > (Also, can you include me in the cc list as I'm the author of the patch you > reverted?) Ugh.. I thought b4 would have done that for me.. weird.. Konrad > > Thanks, > David >