From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78444C47077 for ; Thu, 18 Jan 2024 07:05:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 106F26B0096; Thu, 18 Jan 2024 02:05:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B6976B0098; Thu, 18 Jan 2024 02:05:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC1366B0099; Thu, 18 Jan 2024 02:05:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DC5C06B0096 for ; Thu, 18 Jan 2024 02:05:01 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BC871A06BB for ; Thu, 18 Jan 2024 07:05:01 +0000 (UTC) X-FDA: 81691544802.30.5FE0A55 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf09.hostedemail.com (Postfix) with ESMTP id C4400140014 for ; Thu, 18 Jan 2024 07:04:59 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf09.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=jirislaby@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705561499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5S4lXTmw9h953xURv594T5Yo3rY/dm6ydiBKsQ3CdKQ=; b=32ehpGej3hmX4YjC4gE+U3a5KsRDfoCOHpF9M+fAjKSccktPxEujAZ/+sqSefLHlemyvQF iPB5xqvDV6MXnCJiFcBMyVc7WTI5MXx0NRZejU6tRyyN/IPcf/RH4ilbBpNRIrc/LTEbGE tEI/MLaikdveNwh+WPeV6gl7z/1bxDQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf09.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=jirislaby@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705561499; a=rsa-sha256; cv=none; b=6cZYyzD+7fW6t05X9sgec8Z8eCbCs8Br3cmnhlndXOR1VFPvbyS9LIESc8MeUxMhsf3plF 4Kbd2W3bKgqSvW3FxLRtS7hF2yVa7kyzpdX/4H3z55C1nAoNw7cyIuuSHrMm46E6hKhOLI oXLIJcE0K1Se0q/4FdWfoVF3WM/0nkU= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-40e880121efso17545425e9.3 for ; Wed, 17 Jan 2024 23:04:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705561498; x=1706166298; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5S4lXTmw9h953xURv594T5Yo3rY/dm6ydiBKsQ3CdKQ=; b=NlkqqiV4Vs83Y8Njmun1W8xL+O8uuFbH9xrEm2rcDc4DZdPkJqdfckCfOpad5AHviY JmWgkF5ndbBsNbAYroq8dFpsoMDT13Kt/ptZ8S/vIb3Zq5OG5fH91OFWzoa7YCACUAKk njDqpmNKnPUyMVWMGX+4wpU/X0bbJ6sVM/W+v2jN2t2JCqjWu+pAAL9xj8E2Qdcdamp2 e9yMxkd89H0bGiZxz8dR4OfgZ0gPwzZ/wL02orV8ZrkwyzQrz36SCJA8fLLMKWOldUsW 1f9tSN4y4e95/ry3cLeZVSntcQ5PLnjSEslJgziLzDfJ+rNx5S0yaQIyv2ShPgdsNSOe Jtdw== X-Gm-Message-State: AOJu0Yz8CrbWnudXN6KKoHlZabhftxo1AG3H6e8skHlVDL1F6ro6wdhW oPXSFy2hKJFrQKbn5J2+by+kE0/OMeSUa3Fs2GEpjJQaEDQEiqTP X-Google-Smtp-Source: AGHT+IGAFGpP7XF2uouD5Uj3NbTbrJ+u+1W7IY0t7vFat81rQSB9yz2I3sh9Epp7wUzlN925jm/jsQ== X-Received: by 2002:a05:600c:4513:b0:40e:4119:cb4a with SMTP id t19-20020a05600c451300b0040e4119cb4amr236147wmo.15.1705561498062; Wed, 17 Jan 2024 23:04:58 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id h6-20020a05600c350600b0040c6d559490sm24785527wmq.3.2024.01.17.23.04.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jan 2024 23:04:57 -0800 (PST) Message-ID: <7103dfea-0db3-44b7-9b2e-e89d4edd19d7@kernel.org> Date: Thu, 18 Jan 2024 08:04:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: align larger anonymous mappings on THP boundaries Content-Language: en-US To: Yang Shi Cc: Rik van Riel , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Matthew Wilcox , Christoph Lameter References: <20220809142457.4751229f@imladris.surriel.com> <3193bf5b-4e22-412f-8c5b-68574942d9bc@kernel.org> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C4400140014 X-Stat-Signature: mp6hnx8hrauf7umdwauqn1wqd5bm5af4 X-HE-Tag: 1705561499-846747 X-HE-Meta: U2FsdGVkX1/s0RREIB7ZVg3P3b2bMIGTg3y4mca58uXflbSndwMlpEPGaqjRXZAL4eS5+U7rmbYQqXNuIAB3eBRe0EkEfpau+ABgvpfj6V7+JfD9q3KCba182wkGJNzhE6NR5jYtftlT80wuFoSFbF3Mwzk56UogQ823QSPE6BiBfTj8eLfl3ZptyyEEBvIHc53T0LiiC+GAR2AHSOexffauwYbv5+mZlulrBdZUjejltawoY4o4VvBLtxDwmGAe6LoGbZLsAGxqePO6XXjv0gAPcdS+FL6hC+at81mU1nw66ZIN5GHwPt/GBvwiYPNReVQ/c0TYSnsUU6tR/KGZQRAe34HjIgfViZIl44JlUkhunbnm8aYPUfUlr+y04OXJjGDcASZPHWKTXgD5m0wpR1POmb/Q897ZbPk2/b1SjTawBjgo6HuHruLOJ3UXEfs42jTpt9dP7zDYzFHOTrBo4/hH+Om49xRwSuj354BxmcK23LY5VIew1RDsFf263vqjq7NC/NvO1R+TO0G9ofyalIr19OkZvl2jq3fap1+qhJKLLauJ53baEFrpsfZ38g6FUJjI9UT1K0wxpme+b+JBfX1EhyFQjJKjPhv4SEdRtbKJgFtgw4rQdDzffEdCtc7Gj7TscvaFCCdcqs7I5JKZPoluOYUbsOfNAV2IOl5wmOoYV5DCztn62DSWop7Bl/aToI0OIaLSKXqqWMVU59VmHqnfsLVKEwEXypVM4gx5KgVtwLJ1PEspccMxZ849YTJ4gxXfo2D8gZ17IqPwMWqU2PMLATgY6Rv6JApy2QKUxVN6w8ktei7dXqyvvj2pkrk13POohz7FWJfF/Kh0pX4kmM0q4te03U9M5PFbjHHQPPcZQCh2lqILdCDsfFFQ5SZjR4uQqaA66u/dvkbpmeachZzzyf1n6id7jLOz07wCYuKC+6blss/M8hnUSNaZFHs9y8kMM3CMcEWAFVmyUQz Jbdo7+E7 e0lWsLhcXg45b8teL54x6jPRAWwMy6MaDIRGXEoLdfgfNSl+Xrljst0KZLAy+5eJR8UNuUiFnl6xiz+auHQqoPW18/1Q/hNnPBnhE4gW47IHUIJ6xeWrUWlNYHuWr3hwiTjJSCAKB6viIjaTQJ1mzhRI1V3L6Jw4y+hsKYtvs4qbGFDKOKNox30iUvp/AJD4fzMNzPLGUixUl4n73O8MyaQLf/fFCviIbeMwa2wX+3Sp3qIy2ih5kOJe4rh5u98WSK2/zm3M5rCBOmq8Jwmt/sh/S+TdHgldIqYN1j7gaDFYYZzG/ZKjuAH3kvzhQt6a8/xOsJLSAorce+guv2BKebuXPDWK4owC+We2+OH1xBxNKO5UTV7E7d5bmUIEvotXAqPKcOrXsxuRy0h9i9YO43osJnz03ZinQzbLiBvFVICIZ5J6ir0batWbqOsSae4F9ef7vR4Iv+EtL9XAJ04UU9cv1NQA8MDGxYuNz9D3eRjAG1q1WXPwMIkd1PcRDNaMpbLJYYUqCUOtvI0zIoG2oVMusQa+M/lrQfGY1pxB7g+EodgEOspsHX3N0IUn70jgSWiK7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18. 01. 24, 1:07, Yang Shi wrote: >> This works around the problem, of course (but is a band-aid, not a fix): >> >> --- a/mm/mmap.c >> +++ b/mm/mmap.c >> @@ -1829,7 +1829,7 @@ get_unmapped_area(struct file *file, unsigned long >> addr, unsigned long len, >> */ >> pgoff = 0; >> get_area = shmem_get_unmapped_area; >> - } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { >> + } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && >> !in_32bit_syscall()) { >> /* Ensures that larger anonymous mappings are THP >> aligned. */ >> get_area = thp_get_unmapped_area; >> } >> >> >> thp_get_unmapped_area() does not take care of the legacy stuff... > > Could you please help test the below patch? It is compiled, but I > don't have 32 bit userspace or machine to test it. Yeah, for x86_64, it's semantically the same as the above, so this works too: Tested-by: Jiri Slaby > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -811,6 +811,9 @@ static unsigned long > __thp_get_unmapped_area(struct file *filp, > loff_t off_align = round_up(off, size); > unsigned long len_pad, ret; > > + if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall()) > + return 0; > + > if (off_end <= off_align || (off_end - off_align) < size) > return 0; thanks, -- js suse labs