From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D79EDC25B5F for ; Wed, 8 May 2024 12:33:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D9B86B017E; Wed, 8 May 2024 08:33:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 189C06B017F; Wed, 8 May 2024 08:33:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 029B76B0180; Wed, 8 May 2024 08:32:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D928E6B017E for ; Wed, 8 May 2024 08:32:59 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4D260A2341 for ; Wed, 8 May 2024 12:32:59 +0000 (UTC) X-FDA: 82095168078.21.BFDBEB8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id F0BED8000B for ; Wed, 8 May 2024 12:32:56 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YkffZYNJ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715171577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NyEKmq7S0/dWXFUpRGdfaeCSpwrySCliso/AaofHKNc=; b=vYUugJEllYZ1lvhwz2IIjGLRQxlXUdGZizgP39ImdjTGH2qyIFsfvVh5xVhHHUX+Eo+ze7 3/5gtzba47KzR/2nb1/yzwYg2ZuMHSLaeTzIWjo8WoIRyyS6vWLdMvJLIv/FrITl9urfX7 CyJPFXzg7y61Q6M8DHPshcDmN25Ey8Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715171577; a=rsa-sha256; cv=none; b=2OBRuWyKMXcuKWWvIQtCbXFUmhO6x8gJ8qJ0gWxnygsRktntDWKJw2QTjoDKzRK2v/wizf ZEoujcHWfwF9qhxXQvTP9WV3R9lQCPvhyOGXcVlfjHy6K4misn/6RenVG0iapgi5gwGwPq YE9uSqgQpoTqa++O9Fpk1VarTFiKayM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YkffZYNJ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715171576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NyEKmq7S0/dWXFUpRGdfaeCSpwrySCliso/AaofHKNc=; b=YkffZYNJ4Jips/mZRPWJXtpIUhWf2A6VXQ8BkOfFQKeCkgpd4HV2E6nJDttYgEtBAlzwce XX0tNasFrxUAyBDICXEOoO1Oh0F9knF20VruWEIXqhq0PMfzyQv3ZGX4MSfnvT4NBllBgo jUV2TCqOnjxdsPkppE6LJdC/okYmPzc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-xvv1d-KtPSaBPDuV3YWgeQ-1; Wed, 08 May 2024 08:32:55 -0400 X-MC-Unique: xvv1d-KtPSaBPDuV3YWgeQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-41d979ae1b8so16202975e9.3 for ; Wed, 08 May 2024 05:32:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715171574; x=1715776374; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=NyEKmq7S0/dWXFUpRGdfaeCSpwrySCliso/AaofHKNc=; b=fDsvYESyvhOYpF3kXI3Aq/+LifkboAb9D9Wi2dNr0BuKmt8+skSwYALC1lq2LXh9Jp nIPhUrX0Vcr7tBFXvBEn6ZHb1940tkg6eo2GK0Ca+CMHr4lN/YvtSCuzL7ggoDcNkcN7 09sx+1e9JG5EFIEjmP+YZX+LfQxBLLB/irCZmX31IkKGU+2IEgyWSUssXsUHcKlB7EsR IFYCRPBrsgX/rTc8yhpatofIksxzP53KhdB4hkUs89hSrZWv2dq7nDt5i75kOIqkf87D vsqLfSOWyiRUUKciotNLsL+eZZiT6C3SaN5mqPzdW3J1y6m+L140dKH9qTBv2X6Y4rTa bOIQ== X-Gm-Message-State: AOJu0YzlabePScIAyvi+DyaOHCA3SDJVLG/jdLefRularFt09VLU3v9q Wt/BA/KNg1sMlUgmSaTLXZAxbLhpaCICF3WbsczrYAVuP8EQ6IkQYny6JqkzxV3z6TEnxrEfMD2 0Z0zXSHgc8TjqTYBSs19fK51uULSm7Riw9z1E+mQfbnLEN8cN X-Received: by 2002:a05:600c:3b8c:b0:41b:ef52:1677 with SMTP id 5b1f17b1804b1-41f719d5d52mr18230965e9.27.1715171573759; Wed, 08 May 2024 05:32:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHsALbom9bN4D6PjfVxH3CyMKXuYiCR4T9mD7ks1o0R8DW+R71cnB8NLNkN11xerb402M7ivQ== X-Received: by 2002:a05:600c:3b8c:b0:41b:ef52:1677 with SMTP id 5b1f17b1804b1-41f719d5d52mr18230825e9.27.1715171573342; Wed, 08 May 2024 05:32:53 -0700 (PDT) Received: from [192.168.3.108] (p5b0c6bc3.dip0.t-ipconnect.de. [91.12.107.195]) by smtp.gmail.com with ESMTPSA id c12-20020adffb4c000000b0034f3e5452a5sm6701504wrs.1.2024.05.08.05.32.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 May 2024 05:32:52 -0700 (PDT) Message-ID: <71027eed-8ddb-4b67-b5d5-a55e52a7133d@redhat.com> Date: Wed, 8 May 2024 14:32:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm/ksm: fix ksm_pages_scanned accounting To: Chengming Zhou , Andrew Morton , Stefan Roesch , xu xin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com References: <20240508-b4-ksm-counters-v1-0-e2a9b13f70c5@linux.dev> <20240508-b4-ksm-counters-v1-1-e2a9b13f70c5@linux.dev> <36168dfd-bdfa-42cd-965a-f7a0e108108e@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <36168dfd-bdfa-42cd-965a-f7a0e108108e@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: F0BED8000B X-Stat-Signature: ddeydsqib5ntn9h4qo6cxhffdax39fsc X-Rspam-User: X-HE-Tag: 1715171576-321960 X-HE-Meta: U2FsdGVkX1//mBwcrXVERFIWm+8zTGLoJqotjhIukXsXZH+dPy8coz4pqHtvna2zpGg8RY8b2is+eZnpK3/kTZOwAMbsG6dCJ9haMPKpeJNhzGSvGpLoCbAbGLtTrGJTdGsg5GTmqX0ydtN2jruHkAWFt+lGPaESF7+zxGEuco5H7xRbd0kAEnOgOHK/lhcxvRdXGt9gRd8/ftodti9HfuA7raWoBsx66uNYoM+4INChxBK3f8up/L0Bzc3wh78hffMCnHcatZ6wQwvlXRL3zWbUe1QH93sxIlfpFSHTWgNHvgyznl1fLxBYMxq9VdbEyjeuWoNXUBNOTVlPSFy8Ae35BI4GvqJlIv3SK+MK5kFSygqcNyNoIocMx7hvrRxbfBy+7od0P7xEdTX9VuUztY3fIv8EMi017UmbOZudoV9xQh/47W/m+ORBFL232AyozmkisMazH6CJqg6mdzxE98uEi1tfeR9XYddrIKFY72/vuNKYUpA23QntLgMxvaeqQI4h99169FjNQUrCDalgXeG7Yq5wWYJee+FYeEQaCdMsClkBBkEWQzui3QcTl+Sh2/rJyBHT8pgSBA5cWr48yH0hkP2yLQYinGwYsRBsQJnI89+e4y/bwVmGO2V3SNPAMn053OwAn6VW+T4RBrLpdcc7kGND3lnPTFCmKXoU08RBUw4+ZhvCOKQNieBSkc9bY3/tJ9L81yaUgfgD9hwQdONH3dKfKSkKVlvzfdDxAUuzi8cle2DVqkQM3UqNkWNu3NqaKioECKazdRaQ693r9yFi1cl7sIhx1PHUTYlRTJFCidj2dQi5H/ah0eQNLmdrsmNFihBN+0lWDHYerR1A9jB15fQ3NiwHsNtV7Eqx9pD5y+yWhS0Glu3Aaf97OZZbMB24xVLYdTgU81AUMnvGPsIvVxGLNgXJcaSy0iCSoOKbP3kjsQrEiOb8+LUE7B7oDZWfriq4uvmFpsuLCDK dnI0C3EL WCTgpMLPFLwALf/BZs8H+x42G8JZV9a4g08oRNzpqOiWmQA90eDPG8KTdmPI7bb69fKxE2tj38CTt1a8hyZnYME0Z9yRf2+7xvQ9Slg/lpi6no2qcwxty5L4S/ocBgvX2loMdruqkAfZ1BG7KTq0WFZd7LNCSpiHZbHI1oE8yuG81bSJ0+c/uGwofZRVe+XDXPgok4/k0a+IIpSercv/OSkL0H/5AP72DwEWWFE13eSAzrNjMRH+H4QxlVTEaIcYDN0CfllPnIFlgDGFzip4P2Hb39nrVDVJyN7xnOnJFI+oqlSmNEjYL2OcY5mMbFB8gP4hMN99BMvV3tDBQYJIOhyPBd3Wj/4obwfWbBJgewTl6CNuEflG8LJy0Pa0SL3bmHWHaj7t+xQgyCXdmXpshEsGw0e02esRG19aU+86gJ6g1ztU8XwVRles61WBQ4gojfohbV5kECiYPJfLHaRjrMic4R4RPLNcWrqLK0U0XVgSrYddn3SiORY48Vj6IOYRihYx3MvF5ELBGY6ZZVmZM8ZkTvG62s2Eo2KyarBtQX7/nFOs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.05.24 12:35, Chengming Zhou wrote: > On 2024/5/8 17:55, Chengming Zhou wrote: >> During testing, I found ksm_pages_scanned is unchanged although the >> scan_get_next_rmap_item() did return valid rmap_item that is not NULL. >> >> The reason is the scan_get_next_rmap_item() will return NULL after >> a full scan, so ksm_do_scan() just return without accounting of the >> ksm_pages_scanned. >> >> Fix it by just putting ksm_pages_scanned accounting in that loop, >> and it will be accounted more timely if that loop would last for >> a long time. >> > > Fixes: b348b5fe2b5f ("mm/ksm: add pages scanned metric") Acked-by: David Hildenbrand -- Cheers, David / dhildenb