From: Vlastimil Babka <vbabka@suse.cz>
To: Dave Chinner <david@fromorbit.com>, Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
Johannes Weiner <hannes@cmpxchg.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Hugh Dickins <hughd@google.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [RFC] fs/proc/meminfo: introduce Unaccounted statistic
Date: Fri, 21 Oct 2016 09:25:10 +0200 [thread overview]
Message-ID: <70fe5da3-c739-58ce-0531-299b48e0ca9e@suse.cz> (raw)
In-Reply-To: <20161020225929.GP23194@dastard>
On 10/21/2016 12:59 AM, Dave Chinner wrote:
> On Thu, Oct 20, 2016 at 03:33:58PM +0200, Michal Hocko wrote:
>> On Thu 20-10-16 14:11:49, Vlastimil Babka wrote:
>> [...]
>> > Hi, I'm wondering if people would find this useful. If you think it is, and
>> > to not make performance worse, I could also make sure in proper submission
>> > that values are not read via global_page_state() multiple times etc...
>>
>> I definitely find this information useful and hate to do the math all
>> the time but on the other hand this is quite fragile and I can imagine
>> we can easily forget to add something there and provide a misleading
>> information to the userspace. So I would be worried with a long term
>> maintainability of this.
>
> This will result in valid memory usage by subsystems like the XFS
> buffer cache being reported as "unaccounted". Given this cache
> (whose size is shrinker controlled) can grow to gigabytes in size
> under various metadata intensive workloads, there's every chance
> that such reporting will make users incorrectly think they have a
> massive memory leak....
Is the XFS buffer cache accounted (and visible) somewhere then? I'd say getting
such large consumers to become visible on the same level as others would be
another advantage...
And yeah, I can even recall a bug report, where I had to do the calculation
myself and it looked like a big leak, and it took some effort to connect it to
xfs buffers. I'd very much welcome for it to be more obvious.
Vlastimil
> Cheers,
>
> Dave.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-10-21 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 12:11 Vlastimil Babka
2016-10-20 13:33 ` Michal Hocko
2016-10-20 22:59 ` Dave Chinner
2016-10-21 7:25 ` Vlastimil Babka [this message]
2016-10-21 11:17 ` Dave Chinner
2016-10-21 7:36 ` Michal Hocko
2016-10-21 7:31 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70fe5da3-c739-58ce-0531-299b48e0ca9e@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox