From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36771C5AD49 for ; Fri, 6 Jun 2025 11:49:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5E816B0092; Fri, 6 Jun 2025 07:49:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0F2B6B0093; Fri, 6 Jun 2025 07:49:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD76A6B0095; Fri, 6 Jun 2025 07:49:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8B5F66B0092 for ; Fri, 6 Jun 2025 07:49:04 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DFF7EC1B09 for ; Fri, 6 Jun 2025 11:49:03 +0000 (UTC) X-FDA: 83524804566.10.2AEDD4B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 95A8A1A0014 for ; Fri, 6 Jun 2025 11:49:01 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ERlMlazi; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749210541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=68I4Y0TtXFxCNK2N6e3UcQSOeAu/7hc1LBplwDcwTcE=; b=dQ0cSHx4cny6XnTAHg78nN76R4TCPn2hptrrfMZZtuCLtLj1oZeQw/9oYIDElZVqkW+APv JCyBt1Mxk1KC9+t99IhnZFYlq8mVrOf64pyMEdaZqGYpvcsAU41lDqYv4v6EX19grzs1IF vdQ8FfvkVNuI+ATWe2FBtGvi8w+YfD0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ERlMlazi; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749210541; a=rsa-sha256; cv=none; b=psxEL+6gbYipbYy8x6nQid2tC9QilUNOx0+F15HDTkyYV6Z+tqaJlSkxagGKHAf13Rk3Ox rpkud/Hm2DdbIInYWzWiQNOedZUm3VXjaKaKEWowaRyLjp0XY3TaImDhea29ceUzgTbR/l zLa/NhHWlgPGkuDaQYsDXK25zcBVysI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749210540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=68I4Y0TtXFxCNK2N6e3UcQSOeAu/7hc1LBplwDcwTcE=; b=ERlMlaziH54zNSdbkZupPBipmF46333rWHp+X+7pFBK9C98eVfvB+5aEKN56P4oF09tYv9 aIoLSnCI7IF139LTAHGpHmc7W4N9AaD4YUUgoQoPE+4mr5SuA3J6H5bN61Ct66XL7kGkqg vGbXODeHW63+ERpyWMnQhvo+uGQWFgQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-168-Gl9TEcNQNX2TfnUL5bclMA-1; Fri, 06 Jun 2025 07:48:59 -0400 X-MC-Unique: Gl9TEcNQNX2TfnUL5bclMA-1 X-Mimecast-MFC-AGG-ID: Gl9TEcNQNX2TfnUL5bclMA_1749210539 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-451e24dfe1dso16173205e9.0 for ; Fri, 06 Jun 2025 04:48:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749210538; x=1749815338; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=68I4Y0TtXFxCNK2N6e3UcQSOeAu/7hc1LBplwDcwTcE=; b=mNuUbNBO0wTunxJojR6L2F/JOWLE6wP+znE6sU8IagAijYeLH+XsEtTS1mHGp7BREm 2ElDbSt/aKsvdH/EXcJwjJj9OFuC6jXZOU9nKs0AuPwEOhUfyqfiWIFn5VHRdQPvusQx qKlOuU80UC3EwT5VPcXBWoTm1qI45HGYBh74P9iboD2C+rJmvIG5rGuGsIRmWstAgSB8 dpawmBnqZHmuZyuP8mGw/96bn7fatcBuMx+/q9G7lPJWIw2CmLeT3pnFXSqqawS8Xiij AQlP82s4tjpE0HkzDnOvqOPKvl2nKF2SryKzmT/NexvWgT0eXSl5Z3pm2uii0dY/m4iu p87g== X-Forwarded-Encrypted: i=1; AJvYcCUV7SqSz1tUdm7mofaZ87U1+XSZfNXDggXKMySAWC97dkb9/C2FHxYD64ezmkaTbdIclnmRRaXsuw==@kvack.org X-Gm-Message-State: AOJu0Yx6rrd0NS6kyoX66QIJqkWhMGD51bDUamCf9ZESoyLt3bleBGGb WqtIcZ14Y5DClQBuX79K5oisolmMiWNr4pdJI/dqeXJl0Ka472lAE8rSv1Z++6aczaOGN/ED6F5 FIJjR5R0xcAodtTD3nk8YVsxyNjAwDEq2sARvpUcOwSfhQTDnkmor X-Gm-Gg: ASbGncuky1xC+t6Nb7082r12W4qBOhXdGNj53r8BeYQ9X8syODWd6nRlqENir4kbZV5 sg1LUBvQ7p8IOk3sR1RQ3HVANSpi9srYvBGxx+yyeJFjYjCpUbp/yDPE/gZuL53l7FG7cFgx9U4 mYTzRHCiZ08UFs+FoZhgAxysJkjAiW37yG/lxAIZyUdSPcj4N58OiAUMayV/jv+WTKR60MV+h7b bd6ohX4bpUFAGb5RCNUrWkKqTSkZJUHZo7ANXKVrF61XP52hBE+x+zYm3X2TPXDTgW3qRf+hehW B9j0limN9FYspmUiOq2RgjSC0vbRg1YIkZbaoIZlTD4tx0XT6SlIFiHmxW0nXi4sOMu9gOaV+Kb JLCNAEW6Q1X33eydQopDqT/WRzbmUqB4= X-Received: by 2002:a05:600c:c491:b0:442:f8e7:25ef with SMTP id 5b1f17b1804b1-45201458425mr27983475e9.11.1749210538465; Fri, 06 Jun 2025 04:48:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFrdtAx79g1V5j+TxA2nNneOf5lDgPUH5YR6LNlzqQQIXuJ4KSCbPsPVZoiFWxBNVvQB+bDmA== X-Received: by 2002:a05:600c:c491:b0:442:f8e7:25ef with SMTP id 5b1f17b1804b1-45201458425mr27983285e9.11.1749210538017; Fri, 06 Jun 2025 04:48:58 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229de70sm1615032f8f.5.2025.06.06.04.48.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 04:48:57 -0700 (PDT) Message-ID: <70f3fd39-6b78-4b2c-a09f-ec1e7a2c34db@redhat.com> Date: Fri, 6 Jun 2025 13:48:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 10/10] mm,memory_hotplug: Rename status_change_nid parameter in memory_notify To: Oscar Salvador , Andrew Morton Cc: Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250605142305.244465-1-osalvador@suse.de> <20250605142305.244465-11-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605142305.244465-11-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sJs1mJDksDzp4EfUfE1leSvxkOqETclMr0589QZPMQE_1749210539 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 95A8A1A0014 X-Stat-Signature: 5sh7my99wuspgp736hmhx7tpjditr9pw X-Rspam-User: X-HE-Tag: 1749210541-161468 X-HE-Meta: U2FsdGVkX18Kykk1hywfayy1gevRJZNuJAqVng3w3ebF3mJG6fF5Omys6ow4/sc50nunoNjXJVxQOAGbPYdUViSgetisbN1mCRGPsE9t6hEi4H1IxvGjA/N4N6PNnV5PVEKTA9optyaFLcvqBF1iwLSEr+v5IdVYy6bY4DDZ3eV1sAgbS9bQ1YEfy7FsMBtLjXd7tctM7WODThHuUFDdKre2eZyv8nTDglqjYOo0H15jxz8ID+KRHV/2peDZOFzNesjs0KFfPKYLnymfNtl7k/gTtLPNW5z7lNOW1hzQ841obaHV7yBQvleuM5Y0FQb9SJqK8OqYvY+350DDZZqX3ADMJw8oPf6fcI5HrytTx0z0wrdmlKV8P+2Kv0Z6U3jFGhKMJIGc6ArVX7A+cjM10cS1heA6ocx9WHl8BsLbaGdOvmuCak/ZzOZ+I3tsJuGljqpwrvc7FUAohJO02xbQGVbOF2r92cKK7hNN6Ywli9iwLLT17pHdO+ScMainPe32SYTS6JtVLTiXevjySTYc8xTrdNKgUiMsbx1sggyYJTo3saDQZZux89kuE/dLh5i+iXjYTf5SKxpzoa6mEGS9ivh1Tlguy4v0WldqA2kbyDxSFVgn7d+nZ+mOS4G5A/TAJy8bdoN7ehjRtfWKD2LENtqx8PrHEs+oMr8NWTqG8p2V/yN9+d5YDigzcX2kA+bsu43X3Y/+/bJueeWTq7obEqtxBJ4HLl1hPss6w4YCgybvoTs6dMchCvFNdBVfKl5O2p0lQn36XzuPCoamp6y6EO2y+ooDqkQWPxpY8eWk7jCfwxag88hCcWk12KDDhCTM09cJ1BwQcaWl6acA3+6sP/vK7Iha8GMGWZBJ2ALR5d7pEuwKICp3+1VJQPtfmP5CE5QCFfLxHT1UUMYT/T/FKkzArNFyflDbHdoXlFYTHtJfO4FEiRnORXRPTLW73YlOZp7WbdrgO8MxPWfQ81y /0Dh31Ei ZWVuu9josSVjHLmxIbNxp35mDlBzZsu3/4EI0eV2OChXrB+ReEnH9JrB6gig8YwV5emtZrSCoexNQuFbTpF4V0iTAxB2ziTVJ6kEfwBmXkw+163mQIC12O1y7cjkDy4RDuHswc6T6JPydcZrySTFDkFanPn80eFNhslXPKmcIyKqmYpDz3zBLoVALGbXxOvWaILfx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > struct notifier_block; > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 0550f3061fc4..bccbc02ed122 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1186,7 +1186,7 @@ int online_pages(unsigned long pfn, unsigned long nr_pages, > > mem_arg.start_pfn = pfn; > mem_arg.nr_pages = nr_pages; > - mem_arg.status_change_nid = node_arg.nid; > + mem_arg.nid = node_arg.nid; > cancel_mem_notifier_on_err = true; > ret = memory_notify(MEM_GOING_ONLINE, &mem_arg); > ret = notifier_to_errno(ret); > @@ -1987,7 +1987,7 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages, > > mem_arg.start_pfn = start_pfn; > mem_arg.nr_pages = nr_pages; > - mem_arg.status_change_nid = node_arg.nid; > + mem_arg.nid = node_arg.nid; > cancel_mem_notifier_on_err = true; > ret = memory_notify(MEM_GOING_OFFLINE, &mem_arg); > ret = notifier_to_errno(ret); Okay, now I realize we should just remove the nid completely, because > diff --git a/mm/page_ext.c b/mm/page_ext.c > index c351fdfe9e9a..477e6f24b7ab 100644 > --- a/mm/page_ext.c > +++ b/mm/page_ext.c > @@ -378,16 +378,6 @@ static int __meminit online_page_ext(unsigned long start_pfn, > start = SECTION_ALIGN_DOWN(start_pfn); > end = SECTION_ALIGN_UP(start_pfn + nr_pages); > > - if (nid == NUMA_NO_NODE) { > - /* > - * In this case, "nid" already exists and contains valid memory. > - * "start_pfn" passed to us is a pfn which is an arg for > - * online__pages(), and start_pfn should exist. > - */ > - nid = pfn_to_nid(start_pfn); > - VM_BUG_ON(!node_online(nid)); > - } > - > for (pfn = start; !fail && pfn < end; pfn += PAGES_PER_SECTION) > fail = init_section_page_ext(pfn, nid); > if (!fail) > @@ -436,7 +426,7 @@ static int __meminit page_ext_callback(struct notifier_block *self, > switch (action) { > case MEM_GOING_ONLINE: > ret = online_page_ext(mn->start_pfn, > - mn->nr_pages, mn->status_change_nid); > + mn->nr_pages, mn->nid); Nowadays we call move_pfn_range_to_zone() before MEM_GOING_ONLINE. So we can simply do the nid = pfn_to_nid(start_pfn); unconditionally above. -- Cheers, David / dhildenb