From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C56DC001DE for ; Mon, 31 Jul 2023 11:27:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24FCA280031; Mon, 31 Jul 2023 07:27:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20055280023; Mon, 31 Jul 2023 07:27:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C8BC280031; Mon, 31 Jul 2023 07:27:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F0646280023 for ; Mon, 31 Jul 2023 07:27:22 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B3625C0AD9 for ; Mon, 31 Jul 2023 11:27:22 +0000 (UTC) X-FDA: 81071681124.26.227E35C Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf08.hostedemail.com (Postfix) with ESMTP id 4180B160004 for ; Mon, 31 Jul 2023 11:27:19 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690802840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XORHYwMIFjShI5UKC/FJAJr8KBqC5P/ShUSvLr9VuCw=; b=fwcY7BTrQP9Hai90D9i7t60b8RmHd+LJDBd8KeM5Q1I2Z6dVhDlObhHfhzf38nAdywGUIg DqJFGN9DY0pcweAqYBjrIk/de3lM0QNAIhPVI4yMt34l3bIVE2qBGFZCEcJ/4cxnf0bMln Jv4qKIgso1s3A3GjhHFi9JeNtllGoR4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690802840; a=rsa-sha256; cv=none; b=KwzVM0ddq5kojp8iolpNVP82ehiefv0+fclylrWGnF65xz1X9iD3ak7ejhfzBQzkcxlUUY QdKPB00NfDMPq5Dbw0hyPXBZHaMyzfNyiQXihdPMw2pxpoJwBNO7wU6NA7lT/R7uaRwtgv Ul++q6PYOn4RqNNJTnah/F7FEpnwFcY= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4RDwsz6y5Lz1GDJw; Mon, 31 Jul 2023 19:26:15 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 19:27:14 +0800 Message-ID: <70e81ce8-a27a-325f-68d1-836532ed2ba0@huawei.com> Date: Mon, 31 Jul 2023 19:27:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 4/4] arm64: tlb: set huge page size to stride for hugepage Content-Language: en-US To: Catalin Marinas CC: Andrew Morton , Will Deacon , Mike Kravetz , Muchun Song , Mina Almasry , , , , , , , References: <20230731074829.79309-1-wangkefeng.wang@huawei.com> <20230731074829.79309-5-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 4180B160004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: mix8ykaspyewh84515xijagifha5skyz X-HE-Tag: 1690802839-491984 X-HE-Meta: U2FsdGVkX1/elH+SO8twbT2OndkDiLoRs7hP2t7i3JWeQE8tiySue+8OKwRBYgtpCcguhOI/HfspQB/mLciZp2Wke5Om/t7IqjYkGmq4bQRcSvU81WKASZ6xcsFQKO3IkYcH4AG/2A5jBJoCf/sz2yJkO0j9uKjDxA/DQkUGcDQQ52y01eB0jsBPj7rG2ykAcyTx+RBlV7GULBdXDS81NBqNr+YQhS82Zo/5tiRL493kpD5yKqkNYqptIg25xPfilUPpJfrj8w9FaUwr/tVt/6YUiXWRXFX03rKTriIj35un2Q/laicjc40b6P988mxhCRIdpLNkycmGjrqPSI5u1cRz0+9Wk875JtklaiGXR+cmRRGtsGvwRgvNCeAgi4FYHG4sfq+5WkelJBexs/3WXH9Gs+movBse5GNmIgGaFRt2IK7AZ+gzS/aCUTIOxDsomaMm1CascFbo4zKiAgxt5H6YtXOsgvIUy1258tajjqr2DANlZXVFCD4o9FyyXQ/lNnWg5ehbwBXX65tQTRyQEAUg+avz6x/OCHHzSZGIe5RI2MtzRQFAyM3SyTd+dAt2pC3pZuvEk1wbMOC/RKKfDfO3Eoh5l/z+pU7KQD7oMMoPGo7ELgnAxHDdCTDVzUtvx3RA1GdmFnZDBOSGgkToOJkdMUKqksZlvNzuz0iEZX1ZIQy/mH7YVFRd5vqhk9K7YnMQ1y5p83qIut0enNFscggyYAVl8U9ggllkPFqrrh7HXITqbgJydJ9CLgvyGme97A54trICRZ0PRq4AFMN1AweKVkH96g6d+j5H0QQrjDEyNBbjq8ttoa0SbB7wxSuC3xk0hPWd1mNPsJVF7MFfb1y+g1/lxOsEWmI9mmlOc7KFFjEGWDV1WVfUhA46rVmiKvA/Q5a6UpEq3wi6D5xOXg0aJ9JI3j5/xr5odtRxylHpivaCF7ikKjhHCHUgNwZcKoFzkfIouJTgfxmmvcU P8DocIE/ D59eL6BDyMke9rlfvX6Lf8dfQ/4h10zLS7MCY4Egn3QYapkG3XXq9pVoWPe7Vr+gpCfq43QujaO8xUBZEKw14/xUuDIUgSpSb/o8C4yn7Jy2lU4jy4GSsSP5D5JEOdcmaP7lMZesan8zySz0FmKrySERw3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/31 19:11, Catalin Marinas wrote: > On Mon, Jul 31, 2023 at 03:48:29PM +0800, Kefeng Wang wrote: >> +/* >> + * We cannot use leaf-only invalidation here, since we may be invalidating >> + * table entries as part of collapsing hugepages or moving page tables. >> + * Set the tlb_level to 0 because we can not get enough information here. >> + */ >> +#define flush_tlb_range(vma, start, end) \ >> + __flush_tlb_range(vma, start, end, \ >> + ((vma)->vm_flags & VM_HUGETLB) \ >> + ? huge_page_size(hstate_vma(vma)) \ >> + : PAGE_SIZE, false, 0) > > This won't work if we use the contiguous PTE to get 64K hugetlb pages on > a 4K base page configuration. The 16 base pages in the range would have > to be invalidated individually (the contig PTE bit is just a hint, the > hardware may or may not take it into account). Got it, the contig huge page is depended on hardware implementation, but for normal hugepage(2M/1G), we could use this, right? >