From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2229DC3DA49 for ; Thu, 18 Jul 2024 15:28:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 712166B0085; Thu, 18 Jul 2024 11:28:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C1F06B0089; Thu, 18 Jul 2024 11:28:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B0986B008C; Thu, 18 Jul 2024 11:28:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 362846B0085 for ; Thu, 18 Jul 2024 11:28:02 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C9C9BC0F9A for ; Thu, 18 Jul 2024 15:28:01 +0000 (UTC) X-FDA: 82353253962.04.4DC1B0B Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by imf11.hostedemail.com (Postfix) with ESMTP id F0D274002C for ; Thu, 18 Jul 2024 15:27:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=zyhe3P1j; spf=pass (imf11.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.210.44 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721316438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=AFuoeTzLjl2+sNJgRuxCQvYdNiIGR6RuZRBzqWfCJQQ=; b=7Rc3qsORr7YKPc+6pgbTjll7vr4p0cYV/RoVsNzPUlifTVR55Q4fcVfrei66nn8k25BZtT cj7fqfU5HGRM4bhudxX5Q6XnXIyxc/vcyfRvkBkj21UMu5+1RiURMcCTimBqC6Yq2/gkli i9E3z4SjPxcgHyXJS4GYO0BYsVoSUQg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721316438; a=rsa-sha256; cv=none; b=2PGiipIsoN43eZabs3VCRjZBFDNf+UjqXzpGZz+JOjkcb/H6n73Zeei6m7zGp8qgM0E6p5 yiJrI2En0MfTXuuVnSrFARB8Z0YM3D5iIBt5jCV9XSpC6suSPEySdD0epRRBesHipXWEmT VK9ZCi4ZFCPO9SqHLTZqMuCTmPgJYS0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=zyhe3P1j; spf=pass (imf11.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.210.44 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-70361745053so426037a34.0 for ; Thu, 18 Jul 2024 08:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721316478; x=1721921278; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=AFuoeTzLjl2+sNJgRuxCQvYdNiIGR6RuZRBzqWfCJQQ=; b=zyhe3P1jF0xdqRoPNsCQ2MBR44HqlRZWdM6mvCc5cS1M+F34BJewiPhV8ydAi5dhE2 PdOKpTe2C/qFX8oc0BJ7voQCyxlInjoP/Vf6D59B2zRccqSrG6jqSjfW+rXQyiDE4WSx 5tUqWDIsi/xUne+Xh28rAFZo/A1qpaKjqsgxK8m961588oQoo4yiBLmIvT4bxSYsMyFp 2dyJRNoDVTBSnNwn/BkD82n+OdfQ+rufW28HIrQ4/Fe3BZK+O5VsjtRXP5R1aOVocwyL U3J+/vPdHtc6aqMaqXgj6cIGlKTSN1qxFMZnoM0x1yfg9hUSA+IVbN4OSW1Ofr3+pCHY ebhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721316478; x=1721921278; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AFuoeTzLjl2+sNJgRuxCQvYdNiIGR6RuZRBzqWfCJQQ=; b=HJblPJQZtGU14xNjO5ERYMflmT/FaLW1ymAZ2n5M3TQZq/AdbnWBptZlR7OZAISOnl Mh9i50DS+37ZaMZsjK4I3Lf5YyaINWAApDDJnJGXVcVTC3AZTajc5BxEADLss+BD1SvU orS7h9Ktnxsv7SbKcy3xVBLX9NPXekX4iOagyYJJNQKidmfpdJSihbDZH4JtcMOwR86H 8uRztUWsw8Oo2TjPgwmr4tZfvhq/8RGUoHH+xrWNzx8AWXhOP/Q28DLIG986aK7fIEl8 44DY3RKEyOiQENOTx/xdZR83DWYkz+3/3aiUxgzX28nguDfuB2kaO1SpM9wDInxekiZT nEeQ== X-Forwarded-Encrypted: i=1; AJvYcCWnkpPy3vef28eMzw2/qrXTAZ23jPeqw1ugrouttT7+IRhE/Cy0ZsbtyF2vMkqswrpPYMAR1M2/puLEL3TN2xmW8J4= X-Gm-Message-State: AOJu0Yy8A/bZZeDzpDqg3SeVHcu8SQ9wrPFp/5tQdYTXDYo2uZqLAXU+ fLKla09QmA5leflnZnBmL6tM2h8yF+cs2UPqogu2m+nk9ZqlZxXYKSHqMDUY/Ws= X-Google-Smtp-Source: AGHT+IECRzrkp2OK2/9kQbAk6sEa0OvgiXvImrg/fRA1kUBl73W5L+d6uMpxtPD+FT6kVOA+0ts7iw== X-Received: by 2002:a05:6830:610f:b0:703:59e5:b083 with SMTP id 46e09a7af769-708ea0ed71dmr2005019a34.17.1721316477806; Thu, 18 Jul 2024 08:27:57 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:1a6d:d3d6:98e4:34e1]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-708e79013absm471194a34.73.2024.07.18.08.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jul 2024 08:27:57 -0700 (PDT) Date: Thu, 18 Jul 2024 10:27:55 -0500 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Mikulas Patocka Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Mike Snitzer Subject: [linux-next:master 12153/13432] drivers/md/dm-integrity.c:4559 dm_integrity_ctr() warn: impossible condition '(bi->tuple_size > ((1) << 12) / 2) => (0-255 > 2048)' Message-ID: <70e61f94-d4c6-4ef6-9e72-d65017a745bd@suswa.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F0D274002C X-Stat-Signature: gqx6z69puzrht7h4wxk9jk8oy65dokbi X-HE-Tag: 1721316478-45777 X-HE-Meta: U2FsdGVkX1+tj2tmxbyMtGbbHn04+qRStFCO7liFIG/U5AGYTj/7iLEGedtaL3z3F0GC94rJZwExHUjljfoBsuGVmiomqNIQHEIIPpa9mM3Te/ewnywiT5x2r0ZDbco+wTRLfrXgVuH2Fw6L8r146kQNZiOprRiKttA+ZCjmOFwLRYuPCBd8te5LBahLMjsyyfLNWyy4toP4LlARb8xSSkknL4by13MOtmVea7dDK6rypWQae5+RVMdzVPTn5Lcqhnfeom/oOziItFogzHxLkUbPwJpTR2NImjkAvt6zKqFuMMeQr5D1KVWag8dabhy2w6mwBxcyOvDd+IF0KtCTyys8ZfRtfW869TauJWqdBJOlI+SEeYDHDRhfcuKb25lAOhJAd5692DFLH5URWc3BfDqoLrIlKiIAAverH43E/rQPBODEAGSunD8APP0SCov2QhzucRFX8MYSaz9xGvzmnzbnbcvh8uxDgUNyIiIR0e30b1h0bGHCP2PKPnG9XrGcfNcLj1STE4Oph0VVbXAm5VoOlwbpEq8N6LCgU3UMmkh9JeCyRTpHDr8B+05MaYhtmjxGYavrYbmTwdOoUvInxKGdPhTaWNTq9ZpOHhCuBvxblCJDFttP1b7i+CsAXo2S7zxLhXHjBEqiJnJAN3/KvW8fC4AogtDNnsAiX9wPmosiUM52A7mB5xV/uROkuL07EJ8vQvCeOli/f1yORPfroaHc60I4AsUiV/+xnAZxzdMeM1sk3VSH0t3nRG+CxtiUMryZp8ztOZN90AAWEOZsx/qwCHC8KCUOouc1njPJb2Ike560+6USi37IdjGUeJYlJQ9P+CtAjcENLxH8UGlL9GRpiuemjfN4++q0EExymOyJUOAYC+g2T7UVLYFeerJ5BgnsWKPeeIGPry+3c52gJGPtWr+lUViRQ+34bBOH3/6UUxrS87N9pIxVdZEc/6MXCzekapA1Zi/J8aNbzWO /PboVitg usrdEy0EI0LtjTYkzQ6xNVUaE3dBuBm/IiWC3NBscxxwp0hU3R72Flh/w5wBxZwEYuyzVkOib3xzW198bCK6xxKpfC8CL3OBVL2VA/2gl+pzRNYF1lZGz1NF4gJVV6qFj9mQF4lTjNFgcJqY8zmkFkaibZ8DcfzxQ4X/Syr0YVFRYMMqvDAnEZ1v2bls/AFESkmrqbqtUiznRaIhZW6yRrMzpRCRXpQf353dtAikMwBwtQayxbUJ6xc6IpxlR6I3VSpcPoqUfU/4YPDyYoJb/TDU/zujk3j6Dkp7N5ayC5H2rtH0c87kTEvtODvAq4ECH0CT5YPKCvpZmBA2Ug9UkSX9qLiyh87BsJO82gzNeR4/bEBTaAYCi/P7QHfNpDAe0lwiBYKLOBBO52f+tk3usAnM8tJrcBEPqApP36rAeXPqcDtVnqMRATx5EyB6zESsOQvcRd/MxwbC24xkcrRNYE5lubNuz3zcvSccXB5SC8cMI9bhkzpe+hxFpTjSVMiKfVSJhdbUCwpuwsb8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 73399b58e5e5a1b28a04baf42e321cfcfc663c2f commit: b40cdccafe29f2192807b44130cf5099337ebf8f [12153/13432] dm-integrity: introduce the Inline mode config: i386-randconfig-141-20240718 (https://download.01.org/0day-ci/archive/20240718/202407182211.faX85HCP-lkp@intel.com/config) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202407182211.faX85HCP-lkp@intel.com/ New smatch warnings: drivers/md/dm-integrity.c:4559 dm_integrity_ctr() warn: impossible condition '(bi->tuple_size > ((1) << 12) / 2) => (0-255 > 2048)' vim +4559 drivers/md/dm-integrity.c b40cdccafe29f2 Mikulas Patocka 2024-07-10 4525 if (ic->mode == 'I') { b40cdccafe29f2 Mikulas Patocka 2024-07-10 4526 struct blk_integrity *bi; bi->tuple_size is a u8 b40cdccafe29f2 Mikulas Patocka 2024-07-10 4527 if (ic->meta_dev) { b40cdccafe29f2 Mikulas Patocka 2024-07-10 4528 r = -EINVAL; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4529 ti->error = "Metadata device not supported in inline mode"; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4530 goto bad; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4531 } b40cdccafe29f2 Mikulas Patocka 2024-07-10 4532 if (!ic->internal_hash_alg.alg_string) { b40cdccafe29f2 Mikulas Patocka 2024-07-10 4533 r = -EINVAL; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4534 ti->error = "Internal hash not set in inline mode"; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4535 goto bad; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4536 } b40cdccafe29f2 Mikulas Patocka 2024-07-10 4537 if (ic->journal_crypt_alg.alg_string || ic->journal_mac_alg.alg_string) { b40cdccafe29f2 Mikulas Patocka 2024-07-10 4538 r = -EINVAL; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4539 ti->error = "Journal crypt not supported in inline mode"; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4540 goto bad; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4541 } b40cdccafe29f2 Mikulas Patocka 2024-07-10 4542 if (ic->discard) { b40cdccafe29f2 Mikulas Patocka 2024-07-10 4543 r = -EINVAL; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4544 ti->error = "Discards not supported in inline mode"; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4545 goto bad; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4546 } b40cdccafe29f2 Mikulas Patocka 2024-07-10 4547 bi = blk_get_integrity(ic->dev->bdev->bd_disk); b40cdccafe29f2 Mikulas Patocka 2024-07-10 4548 if (!bi || bi->csum_type != BLK_INTEGRITY_CSUM_NONE) { b40cdccafe29f2 Mikulas Patocka 2024-07-10 4549 r = -EINVAL; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4550 ti->error = "Integrity profile not supported"; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4551 goto bad; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4552 } b40cdccafe29f2 Mikulas Patocka 2024-07-10 4553 /*printk("tag_size: %u, tuple_size: %u\n", bi->tag_size, bi->tuple_size);*/ b40cdccafe29f2 Mikulas Patocka 2024-07-10 4554 if (bi->tuple_size < ic->tag_size) { b40cdccafe29f2 Mikulas Patocka 2024-07-10 4555 r = -EINVAL; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4556 ti->error = "The integrity profile is smaller than tag size"; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4557 goto bad; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4558 } b40cdccafe29f2 Mikulas Patocka 2024-07-10 @4559 if (bi->tuple_size > PAGE_SIZE / 2) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PAGE_SIZE is never going to be less than 4k and 255 is lot less than PAGE_SIZE / 2. Was something else intended here? b40cdccafe29f2 Mikulas Patocka 2024-07-10 4560 r = -EINVAL; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4561 ti->error = "Too big tuple size"; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4562 goto bad; b40cdccafe29f2 Mikulas Patocka 2024-07-10 4563 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki