* Re: [PATCH] mm: mmap: remove newline at the end of the trace
2023-03-10 23:18 [PATCH] mm: mmap: remove newline at the end of the trace Minwoo Im
@ 2023-03-10 23:25 ` Steven Rostedt
2023-03-14 5:28 ` Mukesh Ojha
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Steven Rostedt @ 2023-03-10 23:25 UTC (permalink / raw)
To: Minwoo Im
Cc: linux-mm, linux-kernel, linux-trace-kernel, Masami Hiramatsu,
Matthew Wilcox (Oracle)
On Sat, 11 Mar 2023 08:18:00 +0900
Minwoo Im <minwoo.im.dev@gmail.com> wrote:
> We already have newline in TP_printk so remove the redundant newline
> character at the end of the mmap trace.
>
> <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ...
>
> <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=...
>
> to
>
> <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ...
> <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=...
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
This should go through the mm folks.
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
> ---
> include/trace/events/mmap.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
> index 216de5f03621..f8d61485de16 100644
> --- a/include/trace/events/mmap.h
> +++ b/include/trace/events/mmap.h
> @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area,
> __entry->align_offset = info->align_offset;
> ),
>
> - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n",
> + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx",
> IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr,
> IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0,
> __entry->total_vm, __entry->flags, __entry->length,
> @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap,
> __entry->mt = &mm->mm_mt;
> ),
>
> - TP_printk("mt_mod %p, DESTROY\n",
> + TP_printk("mt_mod %p, DESTROY",
> __entry->mt
> )
> );
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mm: mmap: remove newline at the end of the trace
2023-03-10 23:18 [PATCH] mm: mmap: remove newline at the end of the trace Minwoo Im
2023-03-10 23:25 ` Steven Rostedt
@ 2023-03-14 5:28 ` Mukesh Ojha
2023-03-20 11:45 ` Minwoo Im
2023-03-20 13:34 ` David Hildenbrand
3 siblings, 0 replies; 5+ messages in thread
From: Mukesh Ojha @ 2023-03-14 5:28 UTC (permalink / raw)
To: Minwoo Im, linux-mm, linux-kernel, linux-trace-kernel
Cc: Steven Rostedt, Masami Hiramatsu, Matthew Wilcox (Oracle)
On 3/11/2023 4:48 AM, Minwoo Im wrote:
> We already have newline in TP_printk so remove the redundant newline
> character at the end of the mmap trace.
>
> <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ...
>
> <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=...
>
> to
>
> <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ...
> <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=...
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
> ---
> include/trace/events/mmap.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
> index 216de5f03621..f8d61485de16 100644
> --- a/include/trace/events/mmap.h
> +++ b/include/trace/events/mmap.h
> @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area,
> __entry->align_offset = info->align_offset;
> ),
>
> - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n",
> + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx",
> IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr,
> IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0,
> __entry->total_vm, __entry->flags, __entry->length,
> @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap,
> __entry->mt = &mm->mm_mt;
> ),
>
> - TP_printk("mt_mod %p, DESTROY\n",
> + TP_printk("mt_mod %p, DESTROY",
> __entry->mt
> )
> );
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mm: mmap: remove newline at the end of the trace
2023-03-10 23:18 [PATCH] mm: mmap: remove newline at the end of the trace Minwoo Im
2023-03-10 23:25 ` Steven Rostedt
2023-03-14 5:28 ` Mukesh Ojha
@ 2023-03-20 11:45 ` Minwoo Im
2023-03-20 13:34 ` David Hildenbrand
3 siblings, 0 replies; 5+ messages in thread
From: Minwoo Im @ 2023-03-20 11:45 UTC (permalink / raw)
To: linux-mm, linux-kernel, linux-trace-kernel
Cc: Steven Rostedt, Masami Hiramatsu, Matthew Wilcox (Oracle), Andrew Morton
Ping :)
On 23-03-11 08:18:00, Minwoo Im wrote:
> We already have newline in TP_printk so remove the redundant newline
> character at the end of the mmap trace.
>
> <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ...
>
> <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=...
>
> to
>
> <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ...
> <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=...
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
> include/trace/events/mmap.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
> index 216de5f03621..f8d61485de16 100644
> --- a/include/trace/events/mmap.h
> +++ b/include/trace/events/mmap.h
> @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area,
> __entry->align_offset = info->align_offset;
> ),
>
> - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n",
> + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx",
> IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr,
> IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0,
> __entry->total_vm, __entry->flags, __entry->length,
> @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap,
> __entry->mt = &mm->mm_mt;
> ),
>
> - TP_printk("mt_mod %p, DESTROY\n",
> + TP_printk("mt_mod %p, DESTROY",
> __entry->mt
> )
> );
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mm: mmap: remove newline at the end of the trace
2023-03-10 23:18 [PATCH] mm: mmap: remove newline at the end of the trace Minwoo Im
` (2 preceding siblings ...)
2023-03-20 11:45 ` Minwoo Im
@ 2023-03-20 13:34 ` David Hildenbrand
3 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand @ 2023-03-20 13:34 UTC (permalink / raw)
To: Minwoo Im, linux-mm, linux-kernel, linux-trace-kernel
Cc: Steven Rostedt, Masami Hiramatsu, Matthew Wilcox (Oracle)
On 11.03.23 00:18, Minwoo Im wrote:
> We already have newline in TP_printk so remove the redundant newline
> character at the end of the mmap trace.
>
> <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ...
>
> <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=...
>
> to
>
> <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ...
> <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=...
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
> include/trace/events/mmap.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread