From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2C0FC7618A for ; Mon, 20 Mar 2023 13:34:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04E766B0074; Mon, 20 Mar 2023 09:34:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F41486B0075; Mon, 20 Mar 2023 09:34:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE1956B0078; Mon, 20 Mar 2023 09:34:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CDE4A6B0074 for ; Mon, 20 Mar 2023 09:34:49 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8BCBC120B87 for ; Mon, 20 Mar 2023 13:34:49 +0000 (UTC) X-FDA: 80589371898.17.4FC6617 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 31D801C0027 for ; Mon, 20 Mar 2023 13:34:46 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Pzbl4aAG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679319287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UL6ZvX+vjCKaJ8maGzwsaH5uxn7gh6HZeTFGTMUfwTI=; b=aMhcZEmMc6iU/2n/ixYgKor1DI9Pj6hgdEjHzEVa/xoGOXk3z/I7POPw94xN8fV3JcN2fF +YN1T3njozuVoBT9yrll1QfY45MQjUmoIEGyPcOf1LFGSLtTUrdQQ+FXrAw+4AyD1/asxl V0epDGJ8batjEIUwoSeZlDI14+fvOKA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Pzbl4aAG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679319287; a=rsa-sha256; cv=none; b=vBt6gWa5rz2yDi4LokfQqC82itW+Z+1jgigSrRxGmttYHNdS2vrDQ1qOftiD/IiW9ooOOh r4OGqkeQusU8uyXE2d2G0jk3ymKg5yO7URrCnBJHn958dSUbpyGjyHWv9FBE6GHjS8izjl hHpb3R0hzFJwE6lXiRgd54AH0+aJbhg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679319286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UL6ZvX+vjCKaJ8maGzwsaH5uxn7gh6HZeTFGTMUfwTI=; b=Pzbl4aAG3TaolLhhc3l6QdSDcNsXkTiJjtSisTLSXTKheeiAb+a1kVJ6TsX+mq3bIoci7d fuLOHHgtakKjz00neQnDG0k+lEsVZ+vB6gMknf4Dlel+rWxcqYGk+CMkoLrCYNFvVcFTq5 onlKQdPXdNLpQ1h+dj2FvVEgLwnhW+8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-Of7DlMrxOcOOhzQz9yLzQg-1; Mon, 20 Mar 2023 09:34:45 -0400 X-MC-Unique: Of7DlMrxOcOOhzQz9yLzQg-1 Received: by mail-wr1-f69.google.com with SMTP id o3-20020a5d6483000000b002cc4fe0f7fcso1430597wri.7 for ; Mon, 20 Mar 2023 06:34:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679319284; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UL6ZvX+vjCKaJ8maGzwsaH5uxn7gh6HZeTFGTMUfwTI=; b=7+UFl0b5XKXvN2R6rgPMrrFrPWHJ+mZ7xWXIQ6oh4u9dQiK938IZVC6cZakLkGFYow 0iyNM9o5gE2aA75VU2Atw/oCQaIbXMdT2CKunDORFgNhZAFhNIvE8GqzaxRWWzDPiSeA vBxptI2tWNkcg+G9bTsJZiaWJ+G4mHcInezWujakNTFCcC/KLz7VERv8Pvq1d+pu9XRy wZ9y0xZur4zhJ3Imc7vxYVbgp6wC97sCsJRzRcEo+ZRaNE8ylWm3VTJeCqA7H3MJWi+3 D5tDFNAMYmnq7VTM1xb0RGuGD8nGbvL28Dhh9at7QWtD2xDK/qlawCedDXtTO/XdXKFG Fp4w== X-Gm-Message-State: AO0yUKVvUXPuLVvoBTq2+fUE5y1Uc5JdACV2xdQbC6F6nqWbov7r2V6f YvtPJ1LSEwjVts12z09vXiTnnC4sZ7QGW2bkld1fSRBDp+EBopmVeplQT2FKDNzBd54un9rQKky 9DdMR8VK11Cw= X-Received: by 2002:adf:dec9:0:b0:2d4:e032:6322 with SMTP id i9-20020adfdec9000000b002d4e0326322mr5820654wrn.31.1679319284011; Mon, 20 Mar 2023 06:34:44 -0700 (PDT) X-Google-Smtp-Source: AK7set/Q81rpIrERD7ha3OcykcIz8yRM2cmG+OragzAJxFqbYZ6HxK/bVifpz+SZw9IO/LLzXVy7zQ== X-Received: by 2002:adf:dec9:0:b0:2d4:e032:6322 with SMTP id i9-20020adfdec9000000b002d4e0326322mr5820642wrn.31.1679319283724; Mon, 20 Mar 2023 06:34:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4100:a064:1ded:25ec:cf2f? (p200300cbc7024100a0641ded25eccf2f.dip0.t-ipconnect.de. [2003:cb:c702:4100:a064:1ded:25ec:cf2f]) by smtp.gmail.com with ESMTPSA id b4-20020a056000054400b002d672637520sm3454972wrf.96.2023.03.20.06.34.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 06:34:42 -0700 (PDT) Message-ID: <70d9bf96-2623-d617-c03d-3c7f6c5cbf8b@redhat.com> Date: Mon, 20 Mar 2023 14:34:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] mm: mmap: remove newline at the end of the trace To: Minwoo Im , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Steven Rostedt , Masami Hiramatsu , "Matthew Wilcox (Oracle)" References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 31D801C0027 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ksq7hb1sdmeqmfcggcuy1a4c9399zkid X-HE-Tag: 1679319286-208366 X-HE-Meta: U2FsdGVkX1/KOI0j58SidR7+bLN6w9/vwVNlr13NwrRFVqsAGr56oA/lFopYD8eECU//y0A0RdrKnyUTQWdDzNzVSm2YzRW92Ivm5htjjAAed3olsodcRhtrt+RogijFWH+kqQKyBMVDpZfPNPbBXtkZVqnvH2yGdP8huPV1T2arbCzBqb9SsQnC3IDXlK9NanfiI1w8fTNH7s7nu9A9OxR/52DkH2ivn466O4PEcLjsJk7NTccyWAA8o2RPBOQoYKzKapAemHl7gkYbCD6qex6XWzWR0VDzwKhx+8AoQqHr42gh/fl4hDwW1DjRKUESLZzCU3dp4Nz1dsjGqg8sELY3Y26+V/y1kpAbgqr+lJMOw3Puj+U5SCOxz0qX1l4CWWiNQfQPoe1Waw0P4LLfHQT8qSTNEUo7J8nOSGa0C2+ntWV1O3Bf+AQUbGo5+2idU+box/ZikM3VscPIf1QIPHcgY5xTZcpyUzUrlCxlLJhz3Udve27sksfjQpeKrjUgMfo8gmAVISu3Fn4BprgrcKSoCXo1/5rS8j5Xuss8kK63J4FmlF1efjZ01SYy1vrSuOh7tavwkoup/Cb5CeGgVcfupif1qdln4oXCpTkdZSaelpVRDyymcaVXXVNFFPgybdt6ND9Nj596gNxIu78tDuWGSSCuj+2yFKOq2nEgx2UlG+Qn0AgLCOr2i1YyQnoHlfjE0RQZYKhOMfxElfQU3QMCbl9qVJjsMI1Mw5mcMh9yQ85TKIFi9xE7I/soqtUq2gC/319wLRCRp0R5GoPNR+IzyM8C6pJPlGr4oxRNR1epBIyRWnXRX/FF1bzVMwgeqV7c6qtxzi34f/2CH7m0ZnhQiyGF2xzbzIlL0res5x5eK5g4teZ6i1lwniZ+a2rUnwJwh48jdo49U1gPKfZmuoCw2/UDMEgVoJKKwrcwgmcaMUuROhBZrRmHIW9MphT4sWQGRcUY8APso5r0pJh cM7LxN/5 xgjCAnGlmLH+4UWDOljRxXPN2p1UAil1OusiRxKN+Mc4gy66nA1Oe7bVsyGDMwCcIBboj5IuPo+i7ASjjYHwSGX71obcHh6UmKORUPdTSJ7FOVadISH88PfQ560WuJuJ+DExVgRMdlsCPhIR+y3jEQNrY4h+6n5KDoSDnx8bmUTWN4cS8TznBMVtveRVZOJIaP3hgnUVH3W1pPpLwWvC9YvfhlG+KWl6n4iU0Nd3Saw8t8ghUpPFAF53jp/B7NF2Fo2sUgNGqTaNlsF6MUmBggNH40ginDuuqpzTFiDkuTmDVzMKlFFHaLvzOHlXzwq4PtHQ+0qZGxgo+XDPTTpEGzi7AysmVe+vGL/tAcPCUpkWcwWTpk9a5xDQELzExGkhHt/demPGMfAzXP59bEmlIqc7a4iG6DqJnDWYEF+Z/ByQL2hh0Cy9z1cIsGTWJKO3+supQwtzQpsat1G0Ku37/eDkFnd3kKZwE90ln/t7zQ/SV2iSybrCLZyT/1HYnkNUR809MPsfocdaSs5Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.03.23 00:18, Minwoo Im wrote: > We already have newline in TP_printk so remove the redundant newline > character at the end of the mmap trace. > > <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ... > > <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=... > > to > > <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ... > <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=... > > Signed-off-by: Minwoo Im > --- > include/trace/events/mmap.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb