From: David Hildenbrand <david@redhat.com>
To: Minwoo Im <minwoo.im.dev@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>
Subject: Re: [PATCH] mm: mmap: remove newline at the end of the trace
Date: Mon, 20 Mar 2023 14:34:41 +0100 [thread overview]
Message-ID: <70d9bf96-2623-d617-c03d-3c7f6c5cbf8b@redhat.com> (raw)
In-Reply-To: <ZAu6qDsNPmk82UjV@minwoo-desktop>
On 11.03.23 00:18, Minwoo Im wrote:
> We already have newline in TP_printk so remove the redundant newline
> character at the end of the mmap trace.
>
> <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ...
>
> <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=...
>
> to
>
> <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ...
> <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=...
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
> include/trace/events/mmap.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2023-03-20 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 23:18 Minwoo Im
2023-03-10 23:25 ` Steven Rostedt
2023-03-14 5:28 ` Mukesh Ojha
2023-03-20 11:45 ` Minwoo Im
2023-03-20 13:34 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70d9bf96-2623-d617-c03d-3c7f6c5cbf8b@redhat.com \
--to=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=minwoo.im.dev@gmail.com \
--cc=rostedt@goodmis.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox