From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9582AC001DF for ; Tue, 8 Aug 2023 10:45:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FB556B007B; Tue, 8 Aug 2023 06:45:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A9106B007D; Tue, 8 Aug 2023 06:45:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 171658D0002; Tue, 8 Aug 2023 06:45:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 074D76B007B for ; Tue, 8 Aug 2023 06:45:04 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CE7981204FE for ; Tue, 8 Aug 2023 10:45:03 +0000 (UTC) X-FDA: 81100604886.17.92AB3AA Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf23.hostedemail.com (Postfix) with ESMTP id 36DB5140017 for ; Tue, 8 Aug 2023 10:44:59 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691491501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YxiswcHvPLmF0e0X7MtNXsZE0kPmPImwacqYXGNA5wc=; b=rHEmz7ggHUNQfCVLwo/SKO02Qruflf244yZgiv+sB3jSano/3BnYLfZIpUTN0bSadYinGc xdvTNxbUoFb01vvLw0oqtydAlaS91NG8zSrAQmkSURJVQVpkKCR8Yb41QJZJfjTVK3uP9r FAd+NTg0Dwzs8DZTz693VxpWlncxwFU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691491501; a=rsa-sha256; cv=none; b=XoyV9JsVlUN6fwlTMWL5aRdoLUqsuJiqBg/dwtxkJ55tYdfbdxefouaSgMn1RHnIYdfiPI EnDeuodVBCrvqgrpXSf1hLQq+GYDbTOjGwF/94yJIkygOvb8d/+js1Nx2AvrVrcQ77qz3+ LIgXVZ4FO60OKAwZqyiV1vropDz/fUk= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RKqWK0dVSz1hwFf; Tue, 8 Aug 2023 18:42:05 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 18:44:53 +0800 Message-ID: <70d65f4d-9783-b09b-5074-f552ae78b52f@huawei.com> Date: Tue, 8 Aug 2023 18:44:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/7] mm: remove redundant K() macro definition Content-Language: en-US To: Kefeng Wang , CC: , References: <20230804012559.2617515-1-zhangpeng362@huawei.com> <20230804012559.2617515-2-zhangpeng362@huawei.com> <3df967c2-5635-422b-959a-07632a783690@huawei.com> From: "zhangpeng (AS)" In-Reply-To: <3df967c2-5635-422b-959a-07632a783690@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 36DB5140017 X-Stat-Signature: hbf87k3xhzqb5h1m7x1p5qsuq9bwizrx X-Rspam-User: X-HE-Tag: 1691491499-259754 X-HE-Meta: U2FsdGVkX19/W4mL7mW9LXjHeMsXRUfFwfdlAQ+bRcOPLoCdQHvpZUjf188rK0nnYJTWMOWcp4UezrLltEGycN76hStth2Jywk/maTPeKmqU8KPGHeFSYCcpHclRy8cgncCki6pJvsu0pNB1EkK/r4OXAVAt00iMRWiHeSMyOZHzw5zkDwDWx0QeCT8QSRPVTOAmKcBP7P5JvB09duHKeEZP1A0t6Qff4WgOZhTMPArftXEZXz0Xa/hl998hxKZaaUnZBFrh5a/1wmzIs21NxEovjK2o6+r0Bn3MoaishgcCqDBlzaF9/FqNZcSB6JClntQ7MJnCWOqicPosTUcrAQsZDWaBEd7PZfEe4+xsz1OEsxn1C29yRpjfVyx/pb5xOmCH0aZ18ySQihPYo8LFC7wc8RrsDisFrsVwwNnpQVTtBG8buE6tMZj/pc0Aoz7x39dsIVxsBYXtfsgHXDDl3g5pRAJEeFPY0YEM0HUX8/cZGmPBvIrPYYwWrL4EPn8wQEhk/80WMtjWXm8GdPx6P/Y2h81uym4ndt7buiV2S+EZQFZ5LSrTrYwm4qpjvdZeu1gfr/LKadV+YoOROAK/hGiOJyAe1rgNCFf2WLQmHMjR4j4/0H80gTONPtPrp0GiFq7Sme4WpPfydzPOVWXuEb7DChsO/gKjAz3QwjK6HX/Jgtgl9oKXMVYY6a540dfgX76YYyB39vtMmDCZ/5/daAhVUCgOwKrUjkP/46Dm9hV2R5tp5M7opv8gijwOjoEoBt/Y3HVF7dDTKMALCwFXDW42DOes4lEAiGHu3bTN2+9cYcgDRMI4ke+9h0ouMqXJFzCbeYxlAyuqzrRxM6eLWuZ6BHM0lAv7MwsP0fNuMQqFQWSAqxkQCsuLRuHnxbuRuR7xvWSbF/7qZlMD/50WgMFvDH1NDyT63Iwj/fAt6ogAfUssxVWrPyxeoF0v7eSeMeNF9ff4O/fxIXRffEI fEw/ovbl eE1wrMf6Fuma9500LRBU+vb+nXjTH6+xQ/BsTdPsnhO57YH87sqz8DUMn/e1U0bc0MUa0/X8FTutqxMgGQ+8r4pfeSPwPjzUy6WTPGwahLBaikWkRTMJnyAyGhopCpzNYk+jp2O8/w9H7mphhVjPXmEsW6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/7 16:31, Kefeng Wang wrote: > On 2023/8/4 9:25, Peng Zhang wrote: >> From: ZhangPeng >> >> Since commit eb8589b4f8c1 ("mm: move mem_init_print_info() to >> mm_init.c"), the K() macro definition has been moved to mm/internal.h. >> Therefore, the definitions in mm/memcontrol.c, mm/backing-dev.c and >> mm/oom_kill.c are redundant. Drop redundant definitions. >> >> Signed-off-by: ZhangPeng >> --- >>   mm/backing-dev.c | 3 +-- >>   mm/memcontrol.c  | 1 - >>   mm/oom_kill.c    | 2 -- >>   3 files changed, 1 insertion(+), 5 deletions(-) >> > ... >> diff --git a/mm/oom_kill.c b/mm/oom_kill.c >> index 612b5597d3af..471061a3a0f5 100644 >> --- a/mm/oom_kill.c >> +++ b/mm/oom_kill.c >> @@ -479,8 +479,6 @@ static DECLARE_WAIT_QUEUE_HEAD(oom_victims_wait); >>     static bool oom_killer_disabled __read_mostly; >>   -#define K(x) ((x) << (PAGE_SHIFT-10)) >> - >>   /* >>    * task->mm can be NULL if the task is the exited group leader.  So to >>    * determine whether the task is using a particular mm, we examine >> all the > > Please drop  "#undef K" in oom_kill.c Thanks for your review! -- Best Regards, Peng