Re: [PATCH 1/7] mm: remove redundant K() macro definition

["zhangpeng (AS)" <zhangpeng362@huawei.com>]

On 2023/8/7 16:31, Kefeng Wang wrote:

> On 2023/8/4 9:25, Peng Zhang wrote:
>> From: ZhangPeng <zhangpeng362@huawei.com>
>>
>> Since commit eb8589b4f8c1 ("mm: move mem_init_print_info() to
>> mm_init.c"), the K() macro definition has been moved to mm/internal.h.
>> Therefore, the definitions in mm/memcontrol.c, mm/backing-dev.c and
>> mm/oom_kill.c are redundant. Drop redundant definitions.
>>
>> Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>
>> ---
>>   mm/backing-dev.c | 3 +--
>>   mm/memcontrol.c  | 1 -
>>   mm/oom_kill.c    | 2 --
>>   3 files changed, 1 insertion(+), 5 deletions(-)
>>
> ...
>> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
>> index 612b5597d3af..471061a3a0f5 100644
>> --- a/mm/oom_kill.c
>> +++ b/mm/oom_kill.c
>> @@ -479,8 +479,6 @@ static DECLARE_WAIT_QUEUE_HEAD(oom_victims_wait);
>>     static bool oom_killer_disabled __read_mostly;
>>   -#define K(x) ((x) << (PAGE_SHIFT-10))
>> -
>>   /*
>>    * task->mm can be NULL if the task is the exited group leader.  So to
>>    * determine whether the task is using a particular mm, we examine 
>> all the
>
> Please drop  "#undef K" in oom_kill.c

Thanks for your review!

-- 
Best Regards,
Peng