From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D1D1C25B78 for ; Tue, 4 Jun 2024 11:51:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5C7D6B00B3; Tue, 4 Jun 2024 07:51:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A097E6B00C0; Tue, 4 Jun 2024 07:51:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80D0F6B00C1; Tue, 4 Jun 2024 07:51:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5E4F16B00B3 for ; Tue, 4 Jun 2024 07:51:17 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 19D1F40636 for ; Tue, 4 Jun 2024 11:51:17 +0000 (UTC) X-FDA: 82193040594.14.38AAA8D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id CFCFE4002A for ; Tue, 4 Jun 2024 11:51:14 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JRYwmWIx; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717501874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OMRwji/WfOnNWXjuVyjyj2IkQFN/jdVrfZVrlWjH2bc=; b=xVjxFGScWtiSdepcSOo54SJDNWTrPrSoKsr1aCPBBJoDRYdfJHYPERUmQD8efYplPC2YWh laVPxtp/sz0XL7cVLHLYhU82mvZIeDCZIMQdH6cCzyUr7bsXJuhmUlelyIQQhMlywWnClX DnudA9EDhGG48iGj1HRoDPWskQr0BsI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717501874; a=rsa-sha256; cv=none; b=OYVh5gkF7JV5K8TpVb0ASgpPbU2yd/OMwzNmI+WeAqJVl2PiGSYLZ9CUKGv4sEPwZZHEVR TRfn9HZt1nterVdIMDV9QZDgkWnsGZCm0Zold6dImrqiVSupsIj+uP3fY4F39Ndv8L0MjY apLRAGYH/ePrCJ3PK+HPwCNVqFKFRRY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JRYwmWIx; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717501874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OMRwji/WfOnNWXjuVyjyj2IkQFN/jdVrfZVrlWjH2bc=; b=JRYwmWIxhiJmT45/d4v9dfbo7A50ZHIwHsLIrAIJqnk+T3x/XQtpaMn59rHzeoJo54OXDg excmUhUIU1//HJLMSW53KJufmWXl1AQxl9HB9viAP9hmWhddBUA0SRn4JG+JEKNNHX+axK DXNN84Ea3dX2ZTV97/rVMo59PIB45Ro= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-hocaahATN_mHO-6BYa1FGA-1; Tue, 04 Jun 2024 07:51:12 -0400 X-MC-Unique: hocaahATN_mHO-6BYa1FGA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-421542e32f4so2216365e9.2 for ; Tue, 04 Jun 2024 04:51:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717501871; x=1718106671; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OMRwji/WfOnNWXjuVyjyj2IkQFN/jdVrfZVrlWjH2bc=; b=F7kGjfhRpS4YplNoxDyBV9mXGm4DUK7OFZAnstJxsE3gcLG75KG74m4pShh6pr83Ao rQqG/Og4vN8xSlTjLwf2a0EIjOTij3LNE+jMZHmBDlD+ol3cGhihC2By5steI3aGlBoN X1s+2WI/XHjzn8tXc5pSK1gQuaCY1K4xGbeRZNJPS/MsWlPGLkbFmGvSDxxgdsaL0jCt /8znmRnTzDb5AYGk+SG/ZMUBI/e5bhHQCTDmmBmfP5jINox6fY2wTscR1wsIDqaze7WM v9ePpILTnlBtKi1Sv0WcpHkHiKocZQM7bGaFBoWUXRkcVQw2UORv64CRYZQihN8R2jPg iSOA== X-Forwarded-Encrypted: i=1; AJvYcCXRoC5QCQSAwMrwYT9kO4FoAUHnwJ4zUWENGO7qNaY/yyyGLXr3+2PcK1Wjgb/cSKy2qQh59wMXjq8u/GfN2aU50jU= X-Gm-Message-State: AOJu0YzR1dCSKeWzJ3JqQao7FpygVXU+o3OtoIs8LC6O0LsFHP2RcBdZ 7Gc619SkJRhU3czd680xBydd19IcgbCXBWV4MwSg6SjE9Rht6sIVLBFRhOZAWK5eRxTEHCix8BT 7gRCeIImPnwxhz2BE1VaSFOMWjZeb66PluRi4lUqDaRIs/yQMEdlGYPeL X-Received: by 2002:a05:600c:4f83:b0:421:3c3a:e828 with SMTP id 5b1f17b1804b1-4213c3ae8d5mr54474985e9.17.1717501871622; Tue, 04 Jun 2024 04:51:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGq+fe7f1G9wLD3rw4JaGeH+AeO+t2kwlYtXP3N35YpkBMI2AGb040GvHXeZzkUQUaYWMgS7w== X-Received: by 2002:a05:600c:4f83:b0:421:3c3a:e828 with SMTP id 5b1f17b1804b1-4213c3ae8d5mr54474805e9.17.1717501871178; Tue, 04 Jun 2024 04:51:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c73a:3a00:a025:9b06:549e:c16b? (p200300cbc73a3a00a0259b06549ec16b.dip0.t-ipconnect.de. [2003:cb:c73a:3a00:a025:9b06:549e:c16b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42135c9dc18sm116367295e9.1.2024.06.04.04.51.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 04:51:10 -0700 (PDT) Message-ID: <70ce5e9a-ddd7-4e21-9ca9-cd0e72e1df60@redhat.com> Date: Tue, 4 Jun 2024 13:51:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] fs/proc/task_mmu: use folio API in pte_is_pinned() To: Kefeng Wang , Andrew Morton Cc: Helge Deller , Daniel Vetter , Matthew Wilcox , linux-mm@kvack.org, Jonathan Corbet References: <20240604114822.2089819-1-wangkefeng.wang@huawei.com> <20240604114822.2089819-2-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240604114822.2089819-2-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CFCFE4002A X-Rspam-User: X-Stat-Signature: h89nwtzfixrqueouz3snx6z875jhyrn9 X-HE-Tag: 1717501874-176848 X-HE-Meta: U2FsdGVkX18nasoGaThHAdhq0kfKlTsHP4xLExoY/uPSrIdZOCsn/LIpxB0acYFopD8fRjXYr7+rKDChnbfo6/X1ueKdWMBbCIbSGLlCij1qFXJFTb1owJqwp1xCpxKhD/4d5WCyWHbmtMgUtUHpbnrv66TAVx1enVfzQmPq2HGkNwVh/Z9EkPhORz92fm7HGpixA5ohNemP0++mkZ5FBzQHoMzYrEoOMcTpLna6+3SeUSEMdSvRjVRdGKJIvHfOeXlxprebCgfO45SaXt8GDnVaqtFnOgMrHHsWdtWm7G+3g6Mj+KwdAVOFzokgNHUInxWb/aedw6yLWjZG0scwChiPev9vj42qkkQHayaiCAg2jjYBoPocLbP5SOyyva5CThK2pfLZxTULUcknouyqJdqp+sQWT9c2pKoN908tVTaB2R1gg8DftGsEjEJHjbR6byZy5m+ydkDnzGSb9V7a/1goIwFcb6WTnfCY5AnONgHTPmFXJrr/QHRjt4BmOvIqckVMOx8JIzd9cwvcj0/vtvY7D3/NidR2ezoP84r9SxwKLL/IOu9bi3JeVo8xu1rqBhHt3n5dyKieVA52328skIoPsXibHYTqM0sUdu0ip8Ia+b5rHTSCJT6wl3W9Bg9NKcvYJj6YpB808lSyVvFmPp/RIwljJojUAQ8bzOpv7LmHaM0wVWUODNnsww1DwbHEhXNtGlpPjtCZ2SXQBGGMw6uyxWvuuRJyTy+cSQslUuVSyz+vkjpLeOTKRwF0VYziDY7k53RzQPU+I2sOcZzys8arDKioXn3BWkFQtEhImMnfDMceVNQ48RAfgifBjXV7ZoZgbXGHJjNjSRdPSqdbr9rQdNW/w3PAp1GQLjx71SeDBo9j/DnTCJEMulPovSLwceQ3dKBDptgRvJObzctUHWbcQVi1sXqBsd/2s+JLBVEmrlO4CXDoKOK+/VBnOs70wbA2/MOl6fJaFvaESbq i+iid/WR EfSVkNBWtCghdjGL8GPvaaWQfCduILsUXO8fKCAktZBb8yMsSgVvcmJFrVeNczgH4ZYlnScKTmeB56X2RcCPK3AWFfWRyhbFUcFMWpeKG3ip7bp7S6P62YaJNgHlIEvBm3IBWXKdCeEwryrOLq9qETpniPlM+gB0Yff9+5S65mG9JkIufykg6W0QcTOZJR51hLWZUJ77d2QMX+5ofJweY0NG8un1GewN5vwZj3ZTbfLQL+3Hdac8e1FPr8BOtL0gHadMV+rkvOcODGBLsw5jgqOIfwe5ih8PuB4sc3bXrF2X+OZ/4g7/+C2svWA3k//ilB6lSlGgmRpNTD1Bwonjkzz4jiamWmS303h0i+hF34InyhtUVC550Uij5r3Apdg0sWTNT8TYECxYP2LnGycLMBlzDcEy52cQVIA4v6JwjJdraIZF1iA5bI0s39k7dnywO05qCFEg93ivwMEPKSrya1bATtQCqyassd+/aNUDsRvldo1RxX3BVuZjc+NVa6YJJZC4Fv8qWxTHIKTjBr7HNmD6C8av/VLUWn0s/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.24 13:48, Kefeng Wang wrote: > Convert to use vm_normal_folio() and folio_maybe_dma_pinned() API, > which helps to remove page_maybe_dma_pinned() in the subsequent change. > > Signed-off-by: Kefeng Wang > --- > fs/proc/task_mmu.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index f8d35f993fe5..5aceb3db7565 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -1088,7 +1088,7 @@ struct clear_refs_private { > > static inline bool pte_is_pinned(struct vm_area_struct *vma, unsigned long addr, pte_t pte) > { > - struct page *page; > + struct folio *folio; > > if (!pte_write(pte)) > return false; > @@ -1096,10 +1096,10 @@ static inline bool pte_is_pinned(struct vm_area_struct *vma, unsigned long addr, > return false; > if (likely(!test_bit(MMF_HAS_PINNED, &vma->vm_mm->flags))) > return false; > - page = vm_normal_page(vma, addr, pte); > - if (!page) > + folio = vm_normal_folio(vma, addr, pte); > + if (!folio) > return false; > - return page_maybe_dma_pinned(page); > + return folio_maybe_dma_pinned(folio); > } > > static inline void clear_soft_dirty(struct vm_area_struct *vma, Likely we should just get rid of the pte_is_pinned() check completely now. We don't perform the same for PMDs, we don't sync against GUP-fast, and the original COW vs. GUP issue was resolved. -- Cheers, David / dhildenb