From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB04C77B6C for ; Thu, 13 Apr 2023 09:05:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BC5D900003; Thu, 13 Apr 2023 05:05:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16B67900002; Thu, 13 Apr 2023 05:05:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05A32900003; Thu, 13 Apr 2023 05:05:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EE6EF900002 for ; Thu, 13 Apr 2023 05:05:30 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BDBF9C02C7 for ; Thu, 13 Apr 2023 09:05:30 +0000 (UTC) X-FDA: 80675784420.14.5F411C1 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by imf30.hostedemail.com (Postfix) with ESMTP id E498C8000C for ; Thu, 13 Apr 2023 09:05:28 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Ycw4JPyI; spf=pass (imf30.hostedemail.com: domain of error27@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681376729; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ImWRhaeP829MMe3bVHuIUkeNGlk1jSLzhOBi573HFgk=; b=Hj55Pg0tuUu7gOXqmcAlDP77eoAEcX9cyPg7fO6JTCSekbEh9xm4rab889AWCdDHUoexFL 74VrgZEhWfKMgxnPB5cJXlCcyAqSPhN6rP6v9sPtTSuceerKyGZQ/iAx7WmMgBvxjryOKp KNHM2halshxf+3Fdr9kuALBkRp2mDLk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Ycw4JPyI; spf=pass (imf30.hostedemail.com: domain of error27@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681376729; a=rsa-sha256; cv=none; b=SJ7qtZnvcdATACqBxW03ZHKnZ37XxFfscQ2rBF/OvTjKCyJBNO1qctiLQG5Lmn+Sxg7XUX SM36qxS34m7InQ1E38NR9Drpmaa4E2PshQR9/JWciemmo8AV0Vya8fVX/rnWIsw1Jp6TpJ erd39AiOrzK+RCx9CUQsGT+VXDCthTM= Received: by mail-wr1-f41.google.com with SMTP id d9so13568252wrb.11 for ; Thu, 13 Apr 2023 02:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681376727; x=1683968727; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ImWRhaeP829MMe3bVHuIUkeNGlk1jSLzhOBi573HFgk=; b=Ycw4JPyIfNKtPZtIde4fHG7FAZBd9ZIC+ZvGTAMrYzk+wYu7yIfkJRTLL020C6Ke+m 99RG8djJ9b4XI9BtEZqHkTV304oJJweBmNoNv3YQ9bFlxK469KbOyITyeWGfkBCGUkNb J0R1PDZUMyzyBe3r3QsYd2q8KIt9BFXAlIvkIgh5Iz1dwf7NOOxNT0R2EzMx/UuRSr9w CPtz2l5ofFsWk81M/q3HQ40k571mQEtJ89lmo5HJsOWDKinI43900eBxAEqYOTuFSjCJ pNDvWl2i/gher+yBo9UnWZMScjX54wCGI8EfJCGFzUz6H4uh82z+8kpuKLjjvWmJwHla rgDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681376727; x=1683968727; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ImWRhaeP829MMe3bVHuIUkeNGlk1jSLzhOBi573HFgk=; b=cr4Q10UhIh5qTudPirvIvB721sdjpSf8O7qDwWJzXUDC6bLOxgWevuG6X/WPPw9oxW f/gNREFpp7ovrddCewmd2kZVg2S8KO0k6+3oc5T2tDIQ5CwNU/Aw0T8mgIN2kGnhlsjl XwDYVFPfk8TQfrefHTg+i19+j1tLUjNCcbtXUi2cpaCyG/9SnRRLfN2WJNgEe+yDcLeQ OiYY2yegEu5Xpo6klVCOGirQjNdUu8CW2Tau/7jThcNpfDIyr+d5A9ORKwOy6aTfzUhd PPB76PiKMt9ellnZcdcSXOXbzfR3WHuTN+q4okQGc5RIgN9Kk887iPofMoXC5E0HrArv 2X+Q== X-Gm-Message-State: AAQBX9cBb2dEutovdYQ7wSBu9NHXJBhhx0eu1Ph/H+4QWVMcb46+jg+g BF+x+Jp9VwvVHlsBjPCcNkQ= X-Google-Smtp-Source: AKy350aon0w/1oZncdiNRHi7M6V9LfV3ybEK+J3KQURj7VtQ18YP10O9ijr3/WSeiDvR2EX6QjWXHQ== X-Received: by 2002:adf:f40a:0:b0:2ef:bbbc:de7d with SMTP id g10-20020adff40a000000b002efbbbcde7dmr884152wro.46.1681376727451; Thu, 13 Apr 2023 02:05:27 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id f20-20020a1c6a14000000b003eae73f0fc1sm1259165wmc.18.2023.04.13.02.05.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 02:05:26 -0700 (PDT) Date: Thu, 13 Apr 2023 12:05:15 +0300 From: Dan Carpenter To: Thierry Reding Cc: oe-kbuild@lists.linux.dev, Christian =?iso-8859-1?Q?K=F6nig?= , lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [linux-next:master 8309/10976] drivers/gpu/host1x/context.c:82 host1x_memory_context_list_init() warn: missing error code 'err' Message-ID: <70bab86b-d705-4815-8100-3cce0cbf25e8@kili.mountain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: E498C8000C X-Stat-Signature: r5u65fset8s6pc4c7bb57a7dfqt5hxqd X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681376728-381226 X-HE-Meta: U2FsdGVkX1/a7cQeszg+8VGQOblvva4GxQEEHuTyvxGBBAgFlPbSN5tW6c2Cg4cLfU0Zf8tkNo6EaQs2NSsLbUWFehA1b/r5rOf3z640fOj/4C/HLxSO5ln2N4WUfKflbzJjjthelkpkDO78oc0AWCVEvaPCB6szpcJaSxamXvOhji6cFccnv7XQrE8CiP6gWnBk9zv9hHJAW6x0k+AxzlrrIyr1XmN0SyogGu2kmNBRpwwPaJxjQCQfkl0SAGbCBGRQ7CEjLQ5PmICAnaQVGMpasTNwJcexqx2HNdgIbOzo10wzZhwJHl8QDdaOlxRzlKkxbZMN7ZRApLr40DGvknEoolus7DM8iz7QeJQ3WQf0TAY+j5e+nnEQAeVNn+CUPukhT3M0+uqpFn115XNdpBsBPbZWfFgwDAjjxVHcXK6t94+khxQzYDTSK5zaXC51dLQBd1nBf2r7I5L95MmZlZDN8SUc5B+N6t5PlmYMT6bPYmpcJvyHixBTN7P/4aYJi9GaAzGg5YuQ1EhqmBQ2wBgDbcg1e0LxR6prFY5AD0IOxvnRoL7XA1Tyhx/rROLa41Qx7KZGTTbXSdcwlbROrvjVvjKriDQxXfX4Rgyil7I8Tjelh52DMZL1XgcYMxYGr35GV3om9EsDaQ+PNUs4C6xWJH36C+pV70lRR1GtAmGpmTItu+cs0Bk519+NQRvkrPLT0KOVBqDrUUgI7189ApjwMvwYhrx+tR74a2tlRIRniWGqQDiXp93JR1qgAV+M9mrP3tlL17+m3xMvXGb26amYu3QEITH/JeuopB/bFlIYEKLBryjHusJEUN3EgZscFNwXkfxNqzIXPVXXwxASNnl1wrWUtJ8WD4vp9+Q8zLr89uHlZlNfq4trrkam3NYrqdqewQ0BiI/J1HdIJNICMgJpEIYmwZzqF7oA0ydoZ1TwEXX5Xogoe0hjhjRncUJy+BfT9tM0turohoLH+Pk BM6whMgq oFqHh2lHoBbkSZ+/J0ld4T1cQbaugWXL1LS9K82Tp45gWKV1yH4nudqKTlYKKXDxoI0hBfssbWm7EpGacdeslZP3T8KsMUDRmly9a7PCy/t1vg9CovO4zrIU8lbfebP7KElI5hYXW3KbBzV/6w3Y+djivOliurbG+FK/xYJ1DrqwcwC+9VnXGoOF7OVtb6uGZ9L9kdB3QWHPuudL9hQtnjaVkPixyL2ojrDZdqZWxKhetlP7AiqzzRVUBA6heA8RGhhEj1jXBM9cRTIBECnn1K2/QCB71If2+Qm/aa/Ad8Ib1f0UgGztedlnteFRqm0Iir6JN1Jo4by/yieclciH/z7CFonwpJinjynks50DliILF/GxgWW5sW7lYVc8dNLEb0kwCr0SWvsdQJS32zIwnX312bGP4VL5YYC8KicNnd2ZF871rrFKpCi3nNUA7XrlIs4ze X-Bogosity: Ham, tests=bogofilter, spamicity=0.000414, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 13, 2023 at 10:57:52AM +0200, Thierry Reding wrote: > On Thu, Apr 13, 2023 at 08:06:08AM +0300, Dan Carpenter wrote: > > 8aa5bcb6161206 Mikko Perttunen 2022-06-27 69 > > 8aa5bcb6161206 Mikko Perttunen 2022-06-27 70 err = of_dma_configure_id(&ctx->dev, node, true, &i); > > 8aa5bcb6161206 Mikko Perttunen 2022-06-27 71 if (err) { > > 8aa5bcb6161206 Mikko Perttunen 2022-06-27 72 dev_err(host1x->dev, "IOMMU configuration failed for context device %d: %d\n", > > 8aa5bcb6161206 Mikko Perttunen 2022-06-27 73 i, err); > > 55879dad0f3ae8 Yang Yingliang 2022-11-26 74 device_unregister(&ctx->dev); > > 55879dad0f3ae8 Yang Yingliang 2022-11-26 75 goto unreg_devices; > > 8aa5bcb6161206 Mikko Perttunen 2022-06-27 76 } > > 8aa5bcb6161206 Mikko Perttunen 2022-06-27 77 > > 9026ba722360ce Thierry Reding 2022-11-17 78 if (!tegra_dev_iommu_get_stream_id(&ctx->dev, &ctx->stream_id) || > > 9026ba722360ce Thierry Reding 2022-11-17 79 !device_iommu_mapped(&ctx->dev)) { > > 8aa5bcb6161206 Mikko Perttunen 2022-06-27 80 dev_err(host1x->dev, "Context device %d has no IOMMU!\n", i); > > 55879dad0f3ae8 Yang Yingliang 2022-11-26 81 device_unregister(&ctx->dev); > > 55879dad0f3ae8 Yang Yingliang 2022-11-26 @82 goto unreg_devices; > > > > error code? > > We don't actually want this to be a fatal failure, so err = 0 is what we > want here. Should we set err = 0 explicitly here to appease smatch? Yes, please. regards, dan carpenter