From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89732C433DF for ; Tue, 4 Aug 2020 06:14:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7B2B32076E for ; Tue, 4 Aug 2020 06:14:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B2B32076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F30FE8D0124; Tue, 4 Aug 2020 02:14:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBABB8D0081; Tue, 4 Aug 2020 02:14:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAABD8D0124; Tue, 4 Aug 2020 02:14:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id C289C8D0081 for ; Tue, 4 Aug 2020 02:14:32 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 758E61EE6 for ; Tue, 4 Aug 2020 06:14:32 +0000 (UTC) X-FDA: 77111871984.25.oven90_251695626fa4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 456BF1804E3A1 for ; Tue, 4 Aug 2020 06:14:32 +0000 (UTC) X-HE-Tag: oven90_251695626fa4 X-Filterd-Recvd-Size: 3555 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Aug 2020 06:14:28 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07484;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0U4ikaQA_1596521656; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U4ikaQA_1596521656) by smtp.aliyun-inc.com(127.0.0.1); Tue, 04 Aug 2020 14:14:16 +0800 Subject: Re: [PATCH v17 00/21] per memcg lru lock To: Michal Hocko Cc: Hugh Dickins , akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com References: <1595681998-19193-1-git-send-email-alex.shi@linux.alibaba.com> <49d4f3bf-ccce-3c97-3a4c-f5cefe2d623a@linux.alibaba.com> <08c8797d-1935-7b41-b8db-d22f054912ac@linux.alibaba.com> <20200803150704.GV5174@dhcp22.suse.cz> From: Alex Shi Message-ID: <70a88c67-d612-783b-b392-f572b7a0d4d9@linux.alibaba.com> Date: Tue, 4 Aug 2020 14:14:00 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200803150704.GV5174@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 X-Rspamd-Queue-Id: 456BF1804E3A1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2020/8/3 =E4=B8=8B=E5=8D=8811:07, Michal Hocko =E5=86=99=E9=81=93= : > On Thu 30-07-20 10:16:13, Alex Shi wrote: >> >> >> =E5=9C=A8 2020/7/30 =E4=B8=8A=E5=8D=882:06, Hugh Dickins =E5=86=99=E9=81= =93: >>> On Wed, 29 Jul 2020, Alex Shi wrote: >>>> >>>> Is there any comments or suggestion for this patchset? >>>> Any hints will be very appreciated. >>> >>> Alex: it is now v5.8-rc7, obviously too late for this patchset to mak= e >>> v5.9, so I'm currently concentrated on checking some patches headed f= or >>> v5.9 (and some bugfix patches of my own that I don't get time to send= ): >>> I'll get back to responding on lru_lock in a week or two's time. >> >> Hi Hugh, >> >> Thanks a lot for response! It's fine to wait longer. >> But thing would be more efficient if review get concentrated... >> I am still too new in mm area. >=20 > I am sorry and owe you a review but it is hard to find time for that. > This is a large change and the review will be really far from trivial. > If this version is mostly stable then I would recommend not posting new > versions and simply remind people you expect the review from by a > targeted ping. >=20 hi Michal, Thanks a lot for reminder! Except a update on patch [PATCH v17 18/21] mm/lru: introduce the relock_p= age_lruvec function from Alexander, the patchset is stable on 5.8. Just on linux-next, there are changes on hpage_nr_pages -> thp_nr_pages f= unc name change, and lru_note_cost changes that they need a new update. And I have another 3 more patches, following this patchset which do clean= up and optimzing. Is it worth for a new patchset? or let me just update here? Thanks Alex