From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EBD3C4332F for ; Mon, 13 Nov 2023 12:29:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 091DE6B0192; Mon, 13 Nov 2023 07:29:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 042486B0199; Mon, 13 Nov 2023 07:29:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4C6E6B019D; Mon, 13 Nov 2023 07:29:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D49606B0192 for ; Mon, 13 Nov 2023 07:29:42 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A6B08B517D for ; Mon, 13 Nov 2023 12:29:42 +0000 (UTC) X-FDA: 81452862204.16.1A00F02 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf21.hostedemail.com (Postfix) with ESMTP id 4B2801C0007 for ; Mon, 13 Nov 2023 12:29:37 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699878580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5/Kvv4I+UzHCW2i/9azn3jHPyeZ2xSSpjrmE9KFaILI=; b=PA8MRP1op4+S0GsvBAanhbP0ZNm3iGwBHxLRFxjJOMvJcAlqh26+dCYH/cAmfskdM1QBQZ VYmcNZXP40kv8wxwwuhIshRhBNqWNlFFWCfBGXD9EuRVlZqJZdIUbkR6zaeXqaQbl57sNU ex9tzYT+KzQKKgVFZmhu7ulwV1Qgic0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699878580; a=rsa-sha256; cv=none; b=HRR+duyz2irTFkanKroZX0c1syMm8DyEl+idbYrP0+y0oiGI99u3r7EEL/OwjoDOZs99lf d6x2+eJEipzg7H9IgFxXreeOezv8schHrdw1fMvwEbyP/v0saQ8aQ0c8y4YskAr33U3VtO 3/8drcBhaN9GSzEbtSoQ/d0IdEV+QT8= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4STSnq4tmgzPpGl; Mon, 13 Nov 2023 20:06:23 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 13 Nov 2023 20:10:34 +0800 Message-ID: <70973a55-63a0-4a85-abe5-d8681fdb3886@huawei.com> Date: Mon, 13 Nov 2023 20:10:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm: support large folio numa balancing Content-Language: en-US To: David Hildenbrand , Baolin Wang , CC: , , , , John Hubbard References: <606d2d7a-d937-4ffe-a6f2-dfe3ae5a0c91@redhat.com> From: Kefeng Wang In-Reply-To: <606d2d7a-d937-4ffe-a6f2-dfe3ae5a0c91@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4B2801C0007 X-Stat-Signature: 76og1xbphxthmsp5w4ed7zdkscjqgp4z X-HE-Tag: 1699878577-568938 X-HE-Meta: U2FsdGVkX1/dNJjs2MJ5nm4DYvxIC74QIMOKYT0V1RooqbvfWtK3WyJJOggg5u8LNQa5l3InW30drg7CF1GDGNH2cpo0pV91wOUeKC2g21qKMNUXrm3gooo5pEeZOWPGorFo3d3ppanLwNZhPmR43Ajf4lP0bOA+nKWb/c8h0rYC3PPV9nU74oZEoIEt9rnLPCz+O4R9SWIPz1nkXfSUEBd29ZHL7ch32SzklEbPr9ubVK5V/Aw4BLpGYElNdjKbDfAb2Ihl5z8zq/8MM0Lx15+qHs7wTJnjGVewYFxoC9uLDi4du0kg7X2lw/Rnrt7N1gcJ4SVx4bDzJDVjaoOvUP39tew0FcN2F8b78wXP8FgRlrLO1eA7NebO5itOwM9A9MLzBGFaMO084mRr4SSsO63tqmv+GNln36zvBjglr3BvG/riV2nnrY2CYzXDKFZG71tYprmCe27VotCUtBJiXlTPUxsmkJAQSECHaXxADWW1LgcsadRYnhwzS3lOKFVvRN2HMimGXRM5Wu6hX+aHLpViKSlQG2S+EteRwi9vVQjHW9E1KbTTEVNPKSa+jrmw4t4SOoMER2Hfjw+Q+sY+38voPNSIYjvqw5QOakDsi5Fpydtm+0lDv9xEtKljOshX3Dao6hQmf3OOZeYFBhL3wNGP985UMtYevWXTfwfWBfVvXuxioNx3Kp4ObtI83V860OEKwGn8xieQeLcPcJuIhn3fRVfVg50jGVflRC3BvE3ay3C8rAhYtvXOFewPn7TYB0WGSNJw/+pFG7KwdJljy8kroDhIThzsvufG79bbwXApfLd8JDpd9TdktPwMLPM5re4+ktoo7SGkoR75Ipwg+K6Ur5geGHtwgv0zeL2mqeOV2BgkWKVPNzDc9H6E8HcZCDuk/AXlFn9x4MaxmjJtK/2QL00ly1Utj2XLcpJk65VF35S38ruh6cCDdmoTd+dGsgcSDEnOu2i289QdxqE oiJw7xMJ NFukk57mBWEv4yICLKWK63++gybrETb0Rt+oWnb+Fax/KHAbZO8fVrjdYN/iCwIIEPgdl3gYMPh306DrV2QsJftkKk4vkdWzUphu0dVsFa2ZuWszw4NfjBbEVPx8VQUVCA3pJnrSl73le9WWh3bRYRPsVLD6GmNzYhQGgRUy6OIPlckHtqzuIo5j8Vf6Jwh0ljB8W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/11/13 18:53, David Hildenbrand wrote: > On 13.11.23 11:45, Baolin Wang wrote: >> Currently, the file pages already support large folio, and supporting for >> anonymous pages is also under discussion[1]. Moreover, the numa balancing >> code are converted to use a folio by previous thread[2], and the >> migrate_pages >> function also already supports the large folio migration. >> >> So now I did not see any reason to continue restricting NUMA balancing >> for >> large folio. > > I recall John wanted to look into that. CCing him. > > I'll note that the "head page mapcount" heuristic to detect sharers will > now strike on the PTE path and make us believe that a large folios is > exclusive, although it isn't. > > As spelled out in the commit you are referencing: > > commit 6695cf68b15c215d33b8add64c33e01e3cbe236c > Author: Kefeng Wang > Date:   Thu Sep 21 15:44:14 2023 +0800 > >     mm: memory: use a folio in do_numa_page() >     Numa balancing only try to migrate non-compound page in > do_numa_page(), >     use a folio in it to save several compound_head calls, note we use >     folio_estimated_sharers(), it is enough to check the folio sharers > since >     only normal page is handled, if large folio numa balancing is > supported, a >     precise folio sharers check would be used, no functional change > intended. > > > I'll send WIP patches for one approach that can improve the situation > soonish. When convert numa balance to use folio, I make similar change, it works with large anon folio(test with v5), but David's precise folio sharers should be merged firstly, also if a large folio shared by many process, we maybe split it, don't sure about it, this need some evaluation.