From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EBBAEB64D9 for ; Sat, 17 Jun 2023 06:43:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F5486B0072; Sat, 17 Jun 2023 02:43:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A50C6B0075; Sat, 17 Jun 2023 02:43:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BC216B0078; Sat, 17 Jun 2023 02:43:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5D3186B0072 for ; Sat, 17 Jun 2023 02:43:27 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1EE591C91EB for ; Sat, 17 Jun 2023 06:43:27 +0000 (UTC) X-FDA: 80911298454.17.FAF9819 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id EBA2020007 for ; Sat, 17 Jun 2023 06:43:24 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ajE6gF9R; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686984205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KT3z5MBsLMZkLkeo6Bj0bSQulysSCuM486H4EH/KXBo=; b=dAWdiF3mLij6OeT34iUTgiQBvTNoGoY9LOujHaQN9+i62PkthYlgWMX1sFNeq45NlZcyKU AQXt277hWfDvkDZnx92PKfddzLKAtbkl+L7+gt0QQBzAqz4PnkV2mNbrxkrmcSlCIassXs LARLToTTGzWsRSJYy2RTtU7pIvhKDLo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ajE6gF9R; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686984205; a=rsa-sha256; cv=none; b=OVYhnYuw1YmrOO2IJnOP3wLXqP+KOkvgkcrcyzgiG5TII+ptMtiEEg51uZJHsREz28ld7c 32NLXDJm4atbV0Ql+gr6wYCACCjL6zlFEVjzmWMVqmY2dWG4fRiQ6CbUHcTFcYJfrEyE8Z 51mJPVOfcHdtjKVcr1ge+A5psHfFPq0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686984204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KT3z5MBsLMZkLkeo6Bj0bSQulysSCuM486H4EH/KXBo=; b=ajE6gF9RkiMqM/z4XUUS99hCMIwG5azliuEmiqHCm0h5OAMMRD0V0avFteUE8kStmYz20+ FDQB1BS+pI9P2jxqngkLuQp95TDt6IG5sRKgiqbm6Iukqdaup31An6yGPHQWGjR2M5OIoz 4IRHiT7gXLNc2Fg+CdYIN0KZQez9RUk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-114-ZW6hiUcWM0G5bKLmfNojwA-1; Sat, 17 Jun 2023 02:43:18 -0400 X-MC-Unique: ZW6hiUcWM0G5bKLmfNojwA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF5773C00086; Sat, 17 Jun 2023 06:43:17 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 12E712166B25; Sat, 17 Jun 2023 06:43:15 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230616161301.622169-1-dhowells@redhat.com> <20230616161301.622169-2-dhowells@redhat.com> To: Simon Horman Cc: dhowells@redhat.com, netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Menglong Dong Subject: Re: [PATCH net-next 01/17] net: Copy slab data for sendmsg(MSG_SPLICE_PAGES) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <708509.1686984195.1@warthog.procyon.org.uk> Date: Sat, 17 Jun 2023 07:43:15 +0100 Message-ID: <708510.1686984195@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: EBA2020007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: o5hp1y6cs4iqdq6uanj389xba1um3xi7 X-HE-Tag: 1686984204-582035 X-HE-Meta: U2FsdGVkX1+Yv5YHTYsXKGDhPJQ5SH5WM4dgsK0w+gJKfQ+rzl+VCthpFThec2k17oWS6GyO31MYwJBi/8QIFByOsO6VhM1eWfygRfPh00ECh+woTgR9FQ4bcyy4zUMLvjjuma/y5cXPZ92rFROhtLfM4ojtUZ1oV04vAPNLu/A5DZIWK9tktePoKBDirDDsY3MuI+3EsBmMh16WnRBVn8cKSoIQO/OXDhGxCY6+yVH1JMyBZ68HmGcz1xmIoqif5V8NPARsuv5y8lxhEt1BLiRhUKUWLNdeAH/Ig8dDGwC2aFxJP6Oive5PIGziK4Qy5JOZGeUbV1JDGWAjAXUc3OvrAsA+8ODnZ6nuOuNrAWtiLwyCw8Wh3h86MvW02KNHECskvH2dcdMRaKCZ4GR82RzWJTXZQJ1RjTE34/HxFNNeAfyk5R9u27oDxmG5pMeT6Exd5wuGmPLfVWY5xgYAhuMmEot/wgfOzV3tx/TTCvz60hdpsbGK6SZ+OJjP4/M797FKGbrijL02XaLSKrjNIr1wo+8f1yLZkrk7xQBXcnYnctOeQcolcnMqtY1aH5exUggixgulrMYiU1DTTcp/W4uEfRQaLJlEJqaES54oig6Rcxx7vcJXVcXvO4FFqR+kgQ4ixWSMEb+3NinbvMt4REvUXFb6R8gg2qTw6Cvdrxq1MO0HkFGVjz/oLJb4bpIl4NDz2DQw2L1X8ZxotuSYhLZ21P7x0webH2dvoOLIP2l9F+1uNwl8sAo/yf3il3yotYFSpkDylzsv10coguAUtlMjczmxKgVkthdBdG2Z2rPL8XKcPz2wmAgCyNdOnPy/1l1gocJ3Cy8AdusPCnDxLIA27FjXBRTUiVHuBC/vdjexWl3cjFq2DaCqCcWrfTD8L4BXjWrLNuBHFLrZo7tddykWMQ3y/2IHl2gL9keWzmcv1+iXTVPJLGMhVu6+EjUUcXbU725Is0Mnt7oUWTG MlHEqG9y U3w3z2RjgdbRKPGPMPFikdbqLvoLMHT6pSkpes3XNswig0gXDXRP3gduNLUBQd3liDg8fXI36iRQC0j6DOgly5gcXoqItP7sTTe5TBi2ZqPuvgVvNz7aiV2Px/nTcOzOpKKSRFCpZhwzpBkTz6HE9xRLFDjb1S09eLAEhbEqvhQV553khEggFcxpWnvSx6kytyKAZ7WwGt7oHCsauO/FtkvDs1CSx1WhVKui3NGpOuda4SQ9RCcFWHgmKm4BmkbJzZyFO96g9ZGdSBjcchVHmasWnmSYCbFjtwTcig6OLy+QjWrjKCDuXIiNWeyntMdrnTXNTo7/9FeQuXDg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Simon Horman wrote: > > + cache = get_cpu_ptr(&skb_splice_frag_cache); ... > > + put_cpu_ptr(skb_splice_frag_cache); > > Hi David, > > I don't think it makes any difference at run-time. > But to keep Sparse happy, perhaps this ought to be put_cpu_var() Actually, the problem is a missing "&". I think I should use put_cpu_ptr() to match get_cpu_ptr(). It doesn't crash because the argument is ignored. David