From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 493D2EED617 for ; Thu, 12 Sep 2024 16:25:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D44116B008A; Thu, 12 Sep 2024 12:25:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF4496B008C; Thu, 12 Sep 2024 12:25:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B94ED6B0095; Thu, 12 Sep 2024 12:25:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 96CE36B008A for ; Thu, 12 Sep 2024 12:25:41 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 43DE280B74 for ; Thu, 12 Sep 2024 16:25:41 +0000 (UTC) X-FDA: 82556612082.29.1908885 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by imf30.hostedemail.com (Postfix) with ESMTP id 37FFE8000E for ; Thu, 12 Sep 2024 16:25:38 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZetBFtWZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726158222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G7CTvQcMV7Vg/CdXkgmBv+zYvwedvth8CuG0vxBi0xI=; b=kQPdkl8+theen8CxMd/4RkWpMKHq6iwVPQJsNcask+egNIHXM3gjlXF1NyA7UtDZAjU0Kb iGQgi++iSEA5Akm6FxNxFlxTrcG+zE3hl8aeUoTVqdUYyMYTgB2VjcPOIHKb3rPzzv4zw+ FUVeJL+jkWVv0A3Lrh4TLUu/XuP4/Os= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726158222; a=rsa-sha256; cv=none; b=BeUklBPqiepZDB9hv66dIJ+t09u8y4FPsOer1nEwxe4p6L6/YTiy7CLeMg79UTe7yOua13 KhZF0r9Non/wQNrfdr6MgRZmlS6MH5D1OIBiW0h0qdcVDBxJAiPoCJYa+MzMB2G7stDuzc u7ymkqkelmjCdPMvw+Obwn8/4P+7gTs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZetBFtWZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=asml.silence@gmail.com Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3787f30d892so6934f8f.0 for ; Thu, 12 Sep 2024 09:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726158338; x=1726763138; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G7CTvQcMV7Vg/CdXkgmBv+zYvwedvth8CuG0vxBi0xI=; b=ZetBFtWZcqy2XHo1TtfDOPImJILBNyrUABZlvEH7b8y7E+Qtyjycpy0r375gj7MRQh CRMOLK5IlQIOJa0D2+Q8kygGh3G6g5DS+IYw+5NaJxfDTLz39hBhi6qp+hfneD8Y3CaX 3KnV3SWQcUiqYpEkdAPL6e0E2QuDbDR2q3G5oT/EbFloW77z8RERWXD1S0CjTr7Y89md p84rLVVWcPVIYVCulPcI6y0vSowytJCIMR1I0aLCAZuGWc65yYY1FF01VkoWTxMH+lMX v//qXqiIr6wAs3jMV2tJf6xUzC2Lu4O/7Wtv2J4f7Gifg1+muoswGdf2BpNkP0W4WRc4 LGfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726158338; x=1726763138; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G7CTvQcMV7Vg/CdXkgmBv+zYvwedvth8CuG0vxBi0xI=; b=smyy2F6BRj8+U2QRA/dHlxVsGBEV1g/ztsgqdpjLIWY9+6Hve5RtM7jj07yCYWGAyy oLa5+KxvS0hXpFazn8130ngD4cUvpJHmCruwtu0MPTw0jIymlsYM3S77nHuiUkAr+OUj HpcjKfSPCZB2Loa6RyzOh0ErnZZR1Hkk+mIMzOfupWpl43MoiGeDhgXlaYRlt6H62aMw jHcCqnBTztneRmvSEnYb4q1t7ENxRojZ/DVCZOBvUWGgcFiEbNHeyg9AbzguDzHuYQFn psWn9FlX8rQV+ZlM8Uh24VIwu3NrYbszg1CVNCEfX7CrYf3XpX3Ii+7GFi4jmI2K8/Gg d/FQ== X-Forwarded-Encrypted: i=1; AJvYcCWDysPO6rMofzDvL0Pyz5eiZZQBH1+ykM6I0znqUVebMN2ZlxPKU33tMBI8K2r4qOeQIGjQIOvd4Q==@kvack.org X-Gm-Message-State: AOJu0YzKQymfsbsksyRBzzNguw7vGortFNvoLEEdPfegyJFTI1T9NEXT XYreChBUwIBWU4GgofnyJHsX9hG43q+m/eADzI8UaQJlztca0I6n X-Google-Smtp-Source: AGHT+IEYjsGFRmRxM2lE8dlGubF0aLspYjSbRzQuTzRHFWjylEfEXSoItu3kA3+dEZurCLzy9VYPQw== X-Received: by 2002:adf:e551:0:b0:374:ae04:c7c5 with SMTP id ffacd0b85a97d-378c2d48eabmr2011639f8f.36.1726158337499; Thu, 12 Sep 2024 09:25:37 -0700 (PDT) Received: from [192.168.42.65] ([148.252.141.246]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42caeb8182dsm179570045e9.36.2024.09.12.09.25.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 09:25:35 -0700 (PDT) Message-ID: <707bc959-53f0-45c9-9898-59b0ccbf216a@gmail.com> Date: Thu, 12 Sep 2024 17:25:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 6/8] block: implement write zeroes io_uring cmd To: Christoph Hellwig Cc: io-uring@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, linux-mm@kvack.org, Conrad Meyer References: <8e7975e44504d8371d716167face2bc8e248f7a4.1726072086.git.asml.silence@gmail.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 37FFE8000E X-Stat-Signature: 8tk8c4y6tcm9obwxnxde73azpn3q71qz X-Rspam-User: X-HE-Tag: 1726158338-608604 X-HE-Meta: U2FsdGVkX1+XYtz5mxd2ARY5GdpxAyxBSxeH/NQRTgS+hQEzumhQsBxhEP/DdPqgthAWiTYMsn3rbPLaZ3m39hTloJW31XBGdxAts+Gg2NSYrH2Y7UR9Tyexdnn5+/cZ78t/F9Ceyy0jik+e347X+4uGIKVR9vjoAbn2Mps8Bgx5YALxXdtU3SFITvAQN3E+DQs+wmHEd5l//oBtxorjSSOioT3ad+TSc9tPVBIuY7CgNJ+TFJrGFftw8NQ3FsBfA2Pmlq4QaEGQlOF+Ntjvz18jV2KTc4uu+NdGl5vKIac+/FTT9EL+t0bClJ8VSya0PPZIQ7t8G7MdU1/4cvpXyfozF4dX0soWgtYoUbPSHEY0GNtg7aMzibaQcTfI5ozQBIJ7Cj1V8bRoSdl3lIe9V/meHZcwuXcgMtCjjSsL3+2TalPYY7abVPrmZ9O/Vt+Jzty0/z4Rskm3M6xD6KKsGXLeUmisweZtiZ9d/gUDnJT8MT6wVNdTsREZbt3GjEARSNlUVhWn+gUp2+Ox1YkLl7Npa0Tc4kG+hHyDAT9IEsy6qtxV+2NEh5f29HW5JkgAwQe6Tkf6ipwYSs7VJ3vXbd/bW6oLAET3WNYyAxmw6TK8n9lKvHccAqn/Zr0VH7+92v4VvTrQVhP8DdLqPc8LVXL5JhKJVsLrB9t/TAZ1oJlT4o5n8yivry1PzGMt8nAs6JzJgK/F20J5Z1/UTuLmUkHzwDxDhNf25ATBDp7W8NwL5a7zDgkTrrPwzVQduiOz7JiEeOaUDAoU6fWERhqtk4EIuImwknQ2MFpQwp6vX5UTmczl3thtwqEoIxj5tXKFJUitCeAsEdk8cfTrvOI0ZF9mAoH3Xps/wBftSNPSCXHed9HYPjDhZAcTmWVS3FVz8vcgEQcK+mbIM4plEqWP8KMGnsJzsV0cPuqFKgAEy50fremSGaOPCgk3pKF1KVwfDKq5wZO7fQF6wx4Ug8F lWGJDe02 i72khz4tnKGtVQxStPp7/Wc++FG3OTG0HX1knOg9ZXPuJp0oNyGvFtAeCLDTVfUEVfYH2pFUDZJu5bc9p6W9Sq0Jqx/0uPv5vb0+atJRQHBbHMr0ze5bbWfZ28UP+gFnDypZS1n+ivNXomPajS8UiW4neQcGgGRb2kxKLKxrLxgeJiPrevrQDWQhCY3CoMOBrBm9IZC2+sDpOhw0JVJCwtx+lWc0+8ctVey22YvL/8AEPISwSmMohmyzWpqKz2FOuQnM2Jy0c7ssnE4LjfrBNkqHWlh0cyzPAD4jvDl6dH6hWfz4mKZpoWY1hfY3i0q7F0l0OQvUITBBrab+jWmjCLsd/voHBDy9QHlZRJb2uakjmVUDokmlzdSBwMmvo8/y8L2kt9NWI3YAJbn6JjuYVi0cFyL540snElpFUe+PIf/Khj1o7hOTBSDgtwzuaCE0YDrQyR8UxWi6rMwbi1bZPJ0Xf9ZZKtLbgT8OW X-Bogosity: Ham, tests=bogofilter, spamicity=0.025974, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/12/24 10:32, Christoph Hellwig wrote: > On Wed, Sep 11, 2024 at 05:34:42PM +0100, Pavel Begunkov wrote: >> Add a second io_uring cmd for block layer implementing asynchronous >> write zeroes. It reuses helpers we've added for async discards, and >> inherits the code structure as well as all considerations in regards to >> page cache races. It has to be supported by underlying hardware to be >> used, otherwise the request will fail. A fallback version is implemented >> separately in a later patch. > > Except that as far as I can tell it doesn't implement a fallback, but I could've worded it better, but it doesn't say anything about implementing fallback for this opcode. > an entirely different command leading to applications breaking when > just using the command and the hardware doesn't support it. > > Nacked-by: Christoph Hellwig > > to this incomplete API that will just create incompatbilities. That's fine, I'd rather take your nack than humouring the idea of having a worse api than it could be. -- Pavel Begunkov