From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F0EEC3ABBF for ; Wed, 7 May 2025 21:19:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7011D6B009E; Wed, 7 May 2025 17:19:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 689376B009F; Wed, 7 May 2025 17:19:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DBC76B00A0; Wed, 7 May 2025 17:19:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2BF166B009E for ; Wed, 7 May 2025 17:19:31 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 36CCDCBB19 for ; Wed, 7 May 2025 21:19:31 +0000 (UTC) X-FDA: 83417378142.01.43AA760 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id E7FF1C0002 for ; Wed, 7 May 2025 21:19:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a1c5jbV0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746652769; a=rsa-sha256; cv=none; b=iEd261dL5k/fs2fnMAtNCi7YsBg6jcUy9/PLTvqT+nc2szvdJlA9gszcbrb8tgpVNSseKx ffG4CHJ2KGBgTe68Nmo0rp2iw4ZmMC560pM+0TnFqlUuskAO0sCfHEd0wQ5ibMeTrp+NKq 8qf1+4DJC/3vNSODWU/2yyTjNomCaOE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a1c5jbV0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746652769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=neHytjR4nubPG+1S9p7VFPglTq2wLWk6QiZis8XoX14=; b=Y2r6e13tulBx1T4eh9Vsi4gb/NnKoiKlu4HjnxFHgo0gj9OV+N3M/0HH2Be1ZpD8hF0eYd vphxTvWG7hAPmkCQLORH4UdyGBuEMh5047rHXiTlg7x0SxgnEOXUQ4fWA4akMboydU2nFD pf1SSWDRzoUoA38329YBhlC05/PNW8g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746652768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=neHytjR4nubPG+1S9p7VFPglTq2wLWk6QiZis8XoX14=; b=a1c5jbV0Bq/bH5U/Pad4xu7NCRru7l2KMzCf7CL131taqUjnDZ2clhII1twXzoyqJdFB50 Xxh42SrDjSyHRdm3qFGZKYzlY4+hs6xgIgRRGCPfazyyTFHwH4j5J159TTbxxD0l/31vkz p2U8fwvf+IJzsJ7RCCPcmMOKCRpO++I= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-XWFvnWNnPgGsvFDbpf9t_A-1; Wed, 07 May 2025 17:19:27 -0400 X-MC-Unique: XWFvnWNnPgGsvFDbpf9t_A-1 X-Mimecast-MFC-AGG-ID: XWFvnWNnPgGsvFDbpf9t_A_1746652766 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a0b589a2c6so100878f8f.0 for ; Wed, 07 May 2025 14:19:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746652766; x=1747257566; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=neHytjR4nubPG+1S9p7VFPglTq2wLWk6QiZis8XoX14=; b=dRIN3ME/7RUkL/NUyWSivpgvfeK9OA3Chr4aug5GcY4GiJ/jfB507mFOqVUOX3vBV5 taRVQ7EUywxzurR894fQiglrznDURnLYDrN8ki7Kt3/GSeqCK//gztb4QVbk4N+QvzIH YtLt4E7q1TTSOZhcDZ8ezUWJa/Qf6Gj6tpfpbzka8mAKJDGPuOtg6Xg+wjNiliEepONW 0yX6It6NG4opcUlFUAT+HoxMgM91miUz42fCKpC+nGJYlBH3awzhJtY8pjVspzGA6/W2 HEDyqdjIBlossP6pJOPKj9orQ7PzVMi7CmNrArzpVp5N9CkTapxg3Zco42SHm1KmCvEK YCkA== X-Forwarded-Encrypted: i=1; AJvYcCUAFDifPIq6XIr3bv5lZau6kOjsczgHlUDtTUJRJIC5sRFjVd1VxCPeSBCOwiDUEOM0QD6HCYPAxw==@kvack.org X-Gm-Message-State: AOJu0Yyajqo9tuh7tmyyJt+Pv1TCTIGrmltVmBnjeOQjtyHZp0heE9XJ AWPX40VLtA9QG3zxVP+vseBjoGYDZDFYBMaDWP0ndRTpbKgLEVQKoV+wQhNn4fk3AP/DaNfRa4h 5L7Mp59upjhMjQGZEVLpFqqV4+I70TkCsmYp7EGS7WW9Ngc+V X-Gm-Gg: ASbGncs87nrByygngzm+9U7fRuM+bKX8PxkH4JeQL/S9pTRxMGYES4KuPuQ4kYxXSaA Ib8+bgPh3Ft/aMKr96LJlIJy5ZhQeTwny+RLXhbDLLIUcisexBBPAZo00Z8RkG8G5Nzds7+Bs+R OXZyfHf0bPrNA9TYae6m/QKZ67XYZoC60rywH9RYMsPjKIOcdJPykHV7jxRKozORFQnigQbro9e 2pF9TIqaJYHNfaC4RSFucfrXszlE45GpcvZzokDr+WRKuSea35n1X6OQ6rSwlCSkQN7zUTj7dBM v5zLon5CcrDVQzuHlW0T5lgGUSh/Vmkfgt2AAPw9gdVGvqmqwZpxkGHYcu/EH8vRqisPkZt6+IE 4hGySsjy0CdmGrMQCVZi6q9MLTyl73Ydqm1RDJQ== X-Received: by 2002:a05:6000:3109:b0:3a0:6f92:ef7c with SMTP id ffacd0b85a97d-3a0b4a05578mr3741921f8f.17.1746652766073; Wed, 07 May 2025 14:19:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZg1ZwclbtWu92EkOgSrYAgd4OdOvPsqPEbzOd7j1h1Qx/6bqO6iJHm+V0g61eeKVFR7zfeQ== X-Received: by 2002:a05:6000:3109:b0:3a0:6f92:ef7c with SMTP id ffacd0b85a97d-3a0b4a05578mr3741904f8f.17.1746652765733; Wed, 07 May 2025 14:19:25 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2b:fe00:532f:f82e:7128:936b? (p200300d82f2bfe00532ff82e7128936b.dip0.t-ipconnect.de. [2003:d8:2f2b:fe00:532f:f82e:7128:936b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a0bb7c29e8sm35906f8f.7.2025.05.07.14.19.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 May 2025 14:19:25 -0700 (PDT) Message-ID: <70785e68-5152-459f-b241-fa5abc3b88ae@redhat.com> Date: Wed, 7 May 2025 23:19:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: khugepaged: convert set_huge_pmd() to take a folio To: Matthew Wilcox , Baolin Wang Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, ziy@nvidia.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <8e33c8a65b46170dfd8ba6715d2115856a55b8f6.1746609191.git.baolin.wang@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wByEi_zM5jIaKILAjAfsyc-4c84w029K579q3q88gPU_1746652766 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E7FF1C0002 X-Stat-Signature: 6hnm6cf4gwcwce9f7w9agbc5jad7arqp X-Rspam-User: X-HE-Tag: 1746652768-630500 X-HE-Meta: U2FsdGVkX1/mFhhm5uccs9rGPIuDuXaZvjjGImC9UYBAiWAkIdcKJAd9u67fMKYlxFaSt+w4WKmRM2lu3SWRfUSd7otUDocHzMgTO76oMEi48xbc1Z+8P6BKUW5ag/mUH8GMPvdEqgRfQHr6EpPmrF0aGUpmJfsx9ZfKt9Psszw09/Ki6biWOpuupvkyPAdRvxlK4ggnZ3Kgg2JtOo99ikc7GNHXlqkjiIQUBZGfswDiUDrqEThoR5YWzpFSrCHlDcqxR2OpeBKC0838q++4yFWfMsVMfVWLeNkXKNvABSLZGbBHk1Vioc95yfltWxvwe3VxHzGf1o5oHQeNUOV4WLweiYKou7a0i0t+3+vXPB/e91bWtfRvp588UHpy1UDe438K0qflSW436rUqMZT/4HeZIR3hYA76650X4rOhFmXEbwBSt+zDkrpf/ppEhfzEBeSxVA4q7Z7qzaPUwSjsKKHvnH7rq4SjP+akts3YrD83uAv6YaT8lst/GiTafMdvu1c9EkHtXZff1qCIePLvEJyfoqcRDf9bwPSXw06Pl1/ITpeN8Ilo4pyiGjNnUxfyT68mJiV9zmtR0A+XWQ19HWTE1Ass2x22ZXM2QapCAToFt2gpKllAPidioDcu6GlRqqa4tQwMtHD1l02E5XPKD//uwNc+6M7i9a82C0S2xlumonXCn+b+Bq1Vrlo8YMwIgtbL7Zo46lDvJXRH1trsOZj3SmiiQTlQaRqJeYl5CTGXf0HDNH14WX1lSOOoES6Fv1pstzsu+YpIHKeSWdw5WD4UJGNTEjK8M0VWwbAtQjH8KA4QvIWn9EXrt2NQYvYpmj+E+/hJC2RnCI/PwX5FLyEniQD6/4xuxnVvDlWtV0BJhzYKaDhhzkRTyYX0+fJqBjDWKsOTSx6MjCGsFLdR/+I19QK/siIQ0XCksIpH2x1UIXKh37oNedayMBJCr1OCyJOBip5J+Tr13Y9QV+0 quau0LBd W1wj0L+5LQ+F2u1vj22SC5c1U2ufhsxCuANrsylzhRWi2oYApE4f7x86aCkw4jyvVDLrjkeEU+82IgfuQi2DkFH1pZnBSEU9TcPuWutvF6SC007GAr6W/wCZInvaRq+6CCLN7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.05.25 14:04, Matthew Wilcox wrote: > On Wed, May 07, 2025 at 05:26:12PM +0800, Baolin Wang wrote: >> @@ -1476,13 +1476,13 @@ static int set_huge_pmd(struct vm_area_struct *vma, unsigned long addr, >> .pmd = pmdp, >> }; >> >> - VM_BUG_ON(!PageTransHuge(hpage)); >> + VM_BUG_ON(!folio_test_large(folio)); > > I don't think this is aterribly useful assertion to keep in a static > function with one caller, do you? > I'll not that -- whatever we do here -- we can (finally) get rid of PageTransHuge. -- Cheers, David / dhildenb