From: Dave Hansen <dave.hansen@intel.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Dan Williams <dan.j.williams@intel.com>,
Jonathan Adams <jwadams@google.com>,
"Chen, Tim C" <tim.c.chen@intel.com>
Subject: Re: [PATCH 0/4] [RFC] Migrate Pages in lieu of discard
Date: Thu, 17 Oct 2019 13:51:10 -0700 [thread overview]
Message-ID: <70731276-ca8c-afa9-aca2-1ef210d4ac01@intel.com> (raw)
In-Reply-To: <CALvZod7kqjPJcdNQu3CO0+GU=0PyUE1YZgrDJcs8dBHpKbLkSg@mail.gmail.com>
On 10/17/19 9:58 AM, Shakeel Butt wrote:
>> My expectation (and I haven't confirmed this) is that the any memory use
>> is accounted to the owning cgroup, whether it is DRAM or PMEM. memcg
>> limit reclaim and global reclaim both end up doing migrations and
>> neither should have a net effect on the counters.
>>
> Hmm I didn't see the memcg charge migration in the code on demotion.
> So, in the code [patch 3] the counters are being decremented as DRAM
> is freed but not incremented for PMEM.
I had assumed that the migration code was doing this for me. I'll go
make sure either way.
next prev parent reply other threads:[~2019-10-17 20:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 22:11 Dave Hansen
2019-10-16 22:11 ` [PATCH 1/4] node: Define and export memory migration path Dave Hansen
2019-10-17 11:12 ` Kirill A. Shutemov
2019-10-17 11:44 ` Kirill A. Shutemov
2019-10-16 22:11 ` [PATCH 2/4] mm/migrate: Defer allocating new page until needed Dave Hansen
2019-10-17 11:27 ` Kirill A. Shutemov
2019-10-16 22:11 ` [PATCH 3/4] mm/vmscan: Attempt to migrate page in lieu of discard Dave Hansen
2019-10-17 17:30 ` Yang Shi
2019-10-18 18:15 ` Dave Hansen
2019-10-18 21:02 ` Yang Shi
2019-10-16 22:11 ` [PATCH 4/4] mm/vmscan: Consider anonymous pages without swap Dave Hansen
2019-10-17 3:45 ` [PATCH 0/4] [RFC] Migrate Pages in lieu of discard Shakeel Butt
2019-10-17 14:26 ` Dave Hansen
2019-10-17 16:58 ` Shakeel Butt
2019-10-17 20:51 ` Dave Hansen [this message]
2019-10-17 17:20 ` Yang Shi
2019-10-17 21:05 ` Dave Hansen
2019-10-17 22:58 ` Shakeel Butt
2019-10-18 21:44 ` Yang Shi
2019-10-17 16:01 ` Suleiman Souhlal
2019-10-17 16:32 ` Dave Hansen
2019-10-17 16:39 ` Shakeel Butt
2019-10-18 8:11 ` Suleiman Souhlal
2019-10-18 15:10 ` Dave Hansen
2019-10-18 15:39 ` Suleiman Souhlal
2019-10-18 7:44 ` Michal Hocko
2019-10-18 14:54 ` Dave Hansen
2019-10-18 21:39 ` Yang Shi
2019-10-18 21:55 ` Dan Williams
2019-10-22 13:49 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70731276-ca8c-afa9-aca2-1ef210d4ac01@intel.com \
--to=dave.hansen@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jwadams@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeelb@google.com \
--cc=tim.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox