From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com [209.85.217.175]) by kanga.kvack.org (Postfix) with ESMTP id 5C5516B009F for ; Tue, 21 Oct 2014 07:43:51 -0400 (EDT) Received: by mail-lb0-f175.google.com with SMTP id u10so829792lbd.20 for ; Tue, 21 Oct 2014 04:43:50 -0700 (PDT) Received: from v094114.home.net.pl (v094114.home.net.pl. [79.96.170.134]) by mx.google.com with SMTP id ps4si18542801lbb.16.2014.10.21.04.43.47 for ; Tue, 21 Oct 2014 04:43:49 -0700 (PDT) From: "Rafael J. Wysocki" Subject: Re: [PATCH 2/4] freezer: remove obsolete comments in __thaw_task() Date: Tue, 21 Oct 2014 14:04:14 +0200 Message-ID: <706964547.3XIII6QxY2@vostro.rjw.lan> In-Reply-To: <1413876435-11720-3-git-send-email-mhocko@suse.cz> References: <1413876435-11720-1-git-send-email-mhocko@suse.cz> <1413876435-11720-3-git-send-email-mhocko@suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Andrew Morton , Cong Wang , David Rientjes , Tejun Heo , Oleg Nesterov , LKML , linux-mm@kvack.org, Linux PM list On Tuesday, October 21, 2014 09:27:13 AM Michal Hocko wrote: > From: Cong Wang > > __thaw_task() no longer clears frozen flag since commit a3201227f803 > (freezer: make freezing() test freeze conditions in effect instead of TIF_FREEZE). > > Cc: David Rientjes > Cc: "Rafael J. Wysocki" > Cc: Tejun Heo > Cc: Andrew Morton > Reviewed-by: Michal Hocko > Signed-off-by: Cong Wang ACK > --- > kernel/freezer.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/kernel/freezer.c b/kernel/freezer.c > index 8f9279b9c6d7..a8900a3bc27a 100644 > --- a/kernel/freezer.c > +++ b/kernel/freezer.c > @@ -150,12 +150,6 @@ void __thaw_task(struct task_struct *p) > { > unsigned long flags; > > - /* > - * Clear freezing and kick @p if FROZEN. Clearing is guaranteed to > - * be visible to @p as waking up implies wmb. Waking up inside > - * freezer_lock also prevents wakeups from leaking outside > - * refrigerator. > - */ > spin_lock_irqsave(&freezer_lock, flags); > if (frozen(p)) > wake_up_process(p); > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org