From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8045C3DA6E for ; Mon, 8 Jan 2024 06:49:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CE4A6B0075; Mon, 8 Jan 2024 01:49:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 357386B0078; Mon, 8 Jan 2024 01:49:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21F6A6B007D; Mon, 8 Jan 2024 01:49:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 101026B0075 for ; Mon, 8 Jan 2024 01:49:40 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CF92CC0283 for ; Mon, 8 Jan 2024 06:49:39 +0000 (UTC) X-FDA: 81655218078.11.2CFA405 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf03.hostedemail.com (Postfix) with ESMTP id 06C1420003 for ; Mon, 8 Jan 2024 06:49:37 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=SOYWp6QD; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf03.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704696578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tt7PGUQ5L43nYUE94yk4XF4aImWy48h5RdG3yYl8t6c=; b=KJSl6xM+D2psPXOczYIsQaMbifAeyGEYf/av3Zmb6prOSJTzZTVAPeOcbV2hZGbO8vZNfD 4NFgnOmDInkfGYlLvaemCwGyJQP2vtFR9Y7KleZ+jr8KUU7AcILLTde4+IpDZj+fp9O+qr p5sYju29jrp1vyPXe2I+y6V5UCtUSzA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=SOYWp6QD; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf03.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704696578; a=rsa-sha256; cv=none; b=TRWS85yqHSg9bVRfH4aqTqMyWTEmp1N6LUi/2MtyC59TaF3lf5A8GiGttrevXyabgungjs j9ClzYecnA/f2fWPq8NZugL2Db3OcDJBg9dh6oZBarGMpsd0ajKE4lO/mR1cpR3iDjXKx+ 4fMX2gQ69+UC/W9MpvryT/RT7434A38= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6d9a795cffbso961331b3a.0 for ; Sun, 07 Jan 2024 22:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1704696577; x=1705301377; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Tt7PGUQ5L43nYUE94yk4XF4aImWy48h5RdG3yYl8t6c=; b=SOYWp6QDj72Cn0VEHvt6mxkRhWkHU6VisZGvKjmclPRfm2R3JRe4XSfpv1ixzU5ZlQ nBXESScN/SVxr4DTwawoKOh6D72TjjDzNfSpEKpW/dVUgWoQB5iSZzqhDtP3A09d1kWg tvPXJcCY21ZxRPO/2Ppl6kht6FXjFotMMdxbJoiSo2Jo0PlPVacmCzbvN5fQISgTcREX d5457aRTPA+/DKxWz3lNUkHrTdaVPCjQ88MZpEsV/82YsYR8qaVWQjT9B6tsuJ0CaBTb fdIhAP1oySBLdSvdW5qG1GBp5SvWaVGHQRCnbSmPOGaL7rTHqGlWd4/Ud/ZHAR93Ghcs rJIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704696577; x=1705301377; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Tt7PGUQ5L43nYUE94yk4XF4aImWy48h5RdG3yYl8t6c=; b=ooYU62XLd9fHWlxC+adS0r5aIUWWMcPa4536UDvBkV9PNCjE+mxTv+qHcA40q5TXZW lkap52j+9oliJ9nMUhz/GVIMwTVwmahvPYDLR1CxuAoawITvGcRQ4p4eXmOwuG0rJRwz SeMc55D/qJ5XwyC4eD+f3cSxoJwbBhRiAgVbqHN1wya7J4HTIbq2v9GlaimcqVbca3hO m+62R9qBsCEEZ6kfFhLIGlR1pdybmpVDkNF6d437D5pJWktUSAGIiwJ1oAr8/DvwGp35 58kvJDMGxx2PzGkiS/8EKweRK59uioqIW7s667bISPvfj1fak/DjTxuYR/2/Qg/qViV4 wVFQ== X-Gm-Message-State: AOJu0YxuvxxeLCaZTACqjUT4kAMhoub/ErFUfO1kLwUZ0+V4AAUIIwOZ 6G/guYmjVO9kG9sVKY3EaVfmbXebVurxyA== X-Google-Smtp-Source: AGHT+IHAvFu60wzgJRTtJBBjAUwjzK1rkytjoKsxQqjLOp60SbdqSYBofXcZZZ9ecUspoWLvn9S/jw== X-Received: by 2002:a05:6a00:731:b0:6da:ca4b:8632 with SMTP id 17-20020a056a00073100b006daca4b8632mr5746697pfm.5.1704696576864; Sun, 07 Jan 2024 22:49:36 -0800 (PST) Received: from [10.54.24.52] (static-ip-148-99-134-202.rev.dyxnet.com. [202.134.99.148]) by smtp.gmail.com with ESMTPSA id p28-20020a056a000a1c00b006d9b30b33b0sm5235704pfh.196.2024.01.07.22.49.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jan 2024 22:49:36 -0800 (PST) Message-ID: <70448afd-cb53-478c-83fc-831c712e9a82@shopee.com> Date: Mon, 8 Jan 2024 14:49:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: list_lru: disable memcg_aware when cgroup.memory is set to "nokmem" To: Roman Gushchin Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20231228062715.338672-1-haifeng.xu@shopee.com> From: Haifeng Xu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 06C1420003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: jn5xm3jpw6txaxa9usi5dm9gb1gj845q X-HE-Tag: 1704696577-251837 X-HE-Meta: U2FsdGVkX18nPYA6Wo2lRIUKaqq36pFqcIYvUpuNwuP9er5OdltJ0YLj2G8axCzf3PJO+juFGRFF5jYzqOhdxy81PvOzdzDRxDKsO/3Q33zEHTvRiND6QnF63qt1cB2x1p02/n2Q5fvBmFV4282aqVhnEMrk10f0/CsF1DqCBRYO4gyVH6PAX/lzaq0r8M2Srz0cjL4z/ldv/JnTCWiByk6PiieneqK+CONqNH60KyaOCRQKFg81jn0yhEjDJoF46/wVgcRf4hZCqU8oFFNIwckAlIpkX1moYEg/U8nVw18hs8xgDaNIXzbAxFW4DA+PwxVR1fkxhI5tu5uvmFQnJHhOQeKlwf5wleHQwIePDYl8UCt97MD3YYKT+ASmlFgzFFQQ+40DSnlEE5PMEfm8hoLnKoT8Ejm/zhuoQwRT9xyDOHAu8onDl9RqE7zme/Y0uHawicg5Hf5wm1U7tX7fYb3u+Zc1tQbGB4OpJx49Nt1XYDetH4zzsZnYQu46Gd9p2WFh+9XdP+E550xyQxP9ZRYesORKKSMAEcz0XB3f1Neq2A5xaaa6i6JXDFYe4p2wAQ/NSiqIn3VGv4qKoZ+LMlTR2ghxkPNi4OU0G2nwTccHajpybXtJFpIk4svoB2RB4x/BqxVeVbj8L13GEpsfu24U9INeVOL4XIF5R8F/RLKQgvv91pperQ4M4TMef4zjftP8w4K7LHgycfoZz3DsS1Zp+btjg3jmoJ9rozCm0+S6Ec3hMenLZTzg0SUN9LzaqzwEdWldeHSjBmSrT84FrtrFGRt+q0RP4c75qqE/foKKGcwpacPEIpeNO2jU8WY8Ca/Cn4x7boto+JJ4I1pTK2D+vz2wqfJDgS0sHYLBFPZ981YjhZ9Xu6o8PiyVDiIyu1fr3UZQ/Hp7ZlwVa84neB8EH2KeCrnu0XMLkb94CvPtTlNmmdMZXMRngJVBWD/l8v9vS3sydAcj0eRJ05i yq5EWnW7 wrJjdXI2MFZpRP2wCLN5ydSVUeA5/f8g1QXUvKlS2Um7VXnL0DyZs4nZUBigjfkkB5wBJcN5omuDZvQvkmxxDhhW2Ix6awfmUehruDmdmR2M3lDStZlxkuurqK64DPKzCaeZYPE6+zh4A1XcE4sUMkhL2jq8oMc9Nvxr3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/3 09:53, Roman Gushchin wrote: > On Thu, Dec 28, 2023 at 06:27:14AM +0000, Haifeng Xu wrote: >> Actually, when using a boot time kernel option "cgroup.memory=nokmem", >> all lru items are inserted to list_lru_node. But for those users who >> invoke list_lru_init_memcg() to initialize list_lru, list_lru_memcg_aware() >> returns true. And this brings unneeded operations related to memcg. >> >> To make things more convenient, let's disable memcg_aware when >> cgroup.memory is set to "nokmem". > > I guess it's not only more convenient, but also should save a bit of memory. > But _probably_ not enough to justify messing up with stable backports. > Do you have any data on memory savings? Do you mean that it will remove the allocation of 'list_lru_memcg' in memcg_init_list_lru_one()? In fact, even without this patch, if we set cgroup.memory set to "nokmem", all memcg's kmemcg_id is -1, so memcg_list_lru_allocated() always returns true and we won't invoke memcg_init_list_lru_one(). > >> >> Signed-off-by: Haifeng Xu > > Acked-by: Roman Gushchin > > Thanks!