From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F11F4C27C4F for ; Mon, 3 Jun 2024 06:05:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89A3E6B0098; Mon, 3 Jun 2024 02:05:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 849736B009A; Mon, 3 Jun 2024 02:05:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7113A6B009B; Mon, 3 Jun 2024 02:05:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 51DD06B0098 for ; Mon, 3 Jun 2024 02:05:22 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B8DA51407B2 for ; Mon, 3 Jun 2024 06:05:21 +0000 (UTC) X-FDA: 82188540042.11.5A1E7DC Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) by imf16.hostedemail.com (Postfix) with ESMTP id 8DF5A180009 for ; Mon, 3 Jun 2024 06:05:19 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=N3qvT9O3; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf16.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717394719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wjITebFei9QefCV+RvhEZenqRq68OjRdmGIxY4MFY+c=; b=iGVIv5CZ1oxesdEFydZMu7roIo71D8Cy9sJmtDUmADkcqXnWrV4xe1tWA0E46GC7g2a74R Xz7mGAfugG+i5LWX2IhHPcnwIvUQrARXsyfTpMueVUY6w6+sXI0vK4rG+7j4t+u02E4a6y eJGD3YXPD/afIiRTkSTezV1xnKBv2p8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=N3qvT9O3; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf16.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717394719; a=rsa-sha256; cv=none; b=p0EcEz1xyUW1LJTGbipBcNS2dDs1mg3K66vS2XIzxbPd5RE1Q1xiTscudWMgpqmx6dpoes gnEs1psfLHT9fIH9asDmQh7zusEgPPVP9qpODjChFWOz9Mt4ncXINyNQmP3vBAeEwBQQiF ojVSoG12/LMj8j9iukwhcQFexZOzbZg= X-Envelope-To: yosryahmed@google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717394717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wjITebFei9QefCV+RvhEZenqRq68OjRdmGIxY4MFY+c=; b=N3qvT9O3g01gA6fkCJ0Jco/gbU1DJpiZ2Lwr8dnYR/0bF7Wtx3s5K6C3Peuy+mwHd3jjwB WMa4yvyb+iQ2h+UU8+ShaYnW5kiA/zb+oTRV+qUmRIPCBmmAhWXQE1VD5d8ROSjAWJZK9R go5AdJXpaXtrrT46+jpFHY045gmHDnw= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: nphamcs@gmail.com X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Message-ID: <702b6eb1-0eb1-4f52-a709-b685a24c4c99@linux.dev> Date: Mon, 3 Jun 2024 14:04:48 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 2/3] mm :zswap: use kmap_local_folio() in zswap_load() Content-Language: en-US To: Yosry Ahmed , Andrew Morton Cc: Johannes Weiner , Nhat Pham , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240524033819.1953587-1-yosryahmed@google.com> <20240524033819.1953587-3-yosryahmed@google.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240524033819.1953587-3-yosryahmed@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 8DF5A180009 X-Stat-Signature: x6u6aqn7g4t4izszryz596d77coztkgi X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717394719-433796 X-HE-Meta: U2FsdGVkX1/KZl3gHge70YELxOT7zZS6zzUevivBm/jl7cy/g6VOxZTPQdYjbEOmZz1nf8VFlcuNVU4xYVjBhfhXK0Gre8eqCCFqUsAGdMGsbQdhUkkZP88Tbg0wztaYK3jsUDZ3y36BLkbx1hZLD0xRxR8FS+yciJbXhMAe/1mjb3Iw126yZKfFPBZ7Az/ML/rUdVyKZpeOlmDJR6DqG3er/FngvDpImmdHf6rD2fljuaES+PgXR+POhukCtySBp2bTLAR1nAo4m08UWiUhTjFRDLRkGNcFo8PsLjgyGJ33KA7TUNsRlRNefo6Ow7PJBZUB2Vh9cguZbCrmhN7lgt2YPAJxYXrxOKAsMwy2g5iviN+/lq5CZaRG3reso0v7dq8VbZe2+pSn92BLvUpxmL1Ngxw6U1pDrwx8fwzA7xwjrAWvPHROHekIRbAaBpHXCjYlARqHqhJvh7ydxRII4NnHKUxyQhwuwF3vLPFZ2eILN0VTnan+GMfa/mmvQbg+uhNpv3pqRBFxUaftmeTEDHgbsmjngA+8+UQ4fYE+TRLc/cm+0mkSyjc9kcJLEL65z3J49q3rKN0TzpNHAVId5ZMLxREol1iTaeforymr+vm80dZwYIjqUNyg2QNj6lxgsUq6hesDgZkP9dFq7/UcJRqzHkGbx/2O+SmfI9n0XzREM7+xZnJM4HCyjM1Ba3dYoDcQX3exRQNakGnXpICzAcJrjRiZF4KMJYSktVjPZPmJQ1nTc+enikbaM1134OyW/pbPmo7ugvbivi9l0jT3Oit147XnSDbKTnkNijTIGeNJrFSq3Hupp4hkZZ4xQaygb6ElET3yZjSiivHRXDoh3/iNb6Se6UCtUFunnksSjplmqn7TH5wzF5QSQ7Q+5v6r8SeoxagxvClEtAC0N8CklLVY2UOOYvrXo5uWA97HVepPP+Jd9tl5XiJBb8hV+Icpvax0szvKEoBaXhwLrbk MwPWL72V 0NEZoJK52AVA0z/Czol7LTZTcWYMms6QT55lnYhNrmKJ8d4dekDeCAH82WoJ2kRBS3szXscqW4C/AoyBCVvPyIzZdxcTG0KJr32J22EtUbm+2dtDXtyj1y1MFWb/iEkpvw5vnGmR1uY3129sIxJt1BSqRF+TbWNaYA+Gx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/24 11:38, Yosry Ahmed wrote: > Eliminate the last explicit 'struct page' reference in mm/zswap.c. > > Signed-off-by: Yosry Ahmed LGTM, thanks! Reviewed-by: Chengming Zhou > --- > mm/zswap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 3693df96c81fe..bac66991fb14e 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -1551,7 +1551,6 @@ bool zswap_load(struct folio *folio) > { > swp_entry_t swp = folio->swap; > pgoff_t offset = swp_offset(swp); > - struct page *page = &folio->page; > bool swapcache = folio_test_swapcache(folio); > struct xarray *tree = swap_zswap_tree(swp); > struct zswap_entry *entry; > @@ -1582,7 +1581,7 @@ bool zswap_load(struct folio *folio) > if (entry->length) > zswap_decompress(entry, folio); > else { > - dst = kmap_local_page(page); > + dst = kmap_local_folio(folio, 0); > zswap_fill_page(dst, entry->value); > kunmap_local(dst); > }