From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC06EC433F5 for ; Mon, 11 Oct 2021 08:34:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D07860EE3 for ; Mon, 11 Oct 2021 08:34:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D07860EE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C926C6B0075; Mon, 11 Oct 2021 04:34:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C42086B0078; Mon, 11 Oct 2021 04:34:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE30C80009; Mon, 11 Oct 2021 04:34:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 9AAAD6B0075 for ; Mon, 11 Oct 2021 04:34:45 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5263A2B35E for ; Mon, 11 Oct 2021 08:34:45 +0000 (UTC) X-FDA: 78683495730.02.811F2D0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 01AF170044D4 for ; Mon, 11 Oct 2021 08:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633941284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Av9k6rWcK0Mzelc/cpt++/TO3lqjdIJG6hSk2ZuzFmw=; b=FbNUvnQuyIzcO8ou76X52xLqHewhpXUy+XWYWz6YXRqWTijEDdjGQB7cfsXBPt04g5WjP+ 3dYZDEye94LeVTdqIMxslrZXtoCnteqljKE5jEHTUKVHbR1I5D1JvpEHqwf3xmsFkyQFA+ nJUW6ZZSR0qQxUc8k6Gm0n7qpuAANKo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-KncZjIVzOAqIs62EcKqiXg-1; Mon, 11 Oct 2021 04:34:42 -0400 X-MC-Unique: KncZjIVzOAqIs62EcKqiXg-1 Received: by mail-wr1-f71.google.com with SMTP id h11-20020adfa4cb000000b00160c791a550so12493371wrb.6 for ; Mon, 11 Oct 2021 01:34:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Av9k6rWcK0Mzelc/cpt++/TO3lqjdIJG6hSk2ZuzFmw=; b=BIL3HJElQoboRSkJwSP6Caqv8J9zmA973ZQFXseYTrGXcS9y7gbm6/29O3DMh9Kjoq +WyLo6EFmuVF0rfMeeWzqgzlY1NMn7mP6wcPgKJsdU5csxgOyIURvNuXg05dZ19GP2VI OYyw/tHvJESwpZeFpkLro06wTtKXVXgeQk/3WAUT2tpzwmLNCpEDhgogiyE/5+3anJkl DYZeXpOyJa8DtvB2S6pSLAjf0LJkZQqQgPfIZKKKtj7Svsk3W826Q9a5/ziGC9aKu2Z9 enj0glYBBSU8FF2sswoc6YSPidffChhVEJDFJ3LzUBOdoHJ6UWFWfvP4P8CQ4VPjA1fw CrMw== X-Gm-Message-State: AOAM5318nOjFimUy9odmDr8xyOAonI8ZGMCahLyDaA6BSy03GRaBXu1v LM7NZy9yD/8vRggK0gNQ5MVAeVaLQ3Qh3WBPdZ0ANMO0cSRRAEf1vvrDS8dZ72Ebn1mQhq0iZ+T scDgJeKk3jcE= X-Received: by 2002:adf:a15c:: with SMTP id r28mr23242871wrr.287.1633941281287; Mon, 11 Oct 2021 01:34:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwMGVPHnDaGNu4iH5/Oh7YURjzaVOZpfBI3BPOtxfFmYbxV7o0LLHXnbscRCq2aMeh5G30FA== X-Received: by 2002:adf:a15c:: with SMTP id r28mr23242855wrr.287.1633941281066; Mon, 11 Oct 2021 01:34:41 -0700 (PDT) Received: from [192.168.3.132] (p5b0c64ba.dip0.t-ipconnect.de. [91.12.100.186]) by smtp.gmail.com with ESMTPSA id h22sm7769224wmq.42.2021.10.11.01.34.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Oct 2021 01:34:40 -0700 (PDT) To: Faiyaz Mohammed , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: guptap@codeaurora.org, Faiyaz Mohammed References: <1633936279-26856-1-git-send-email-quic_faiyazm@codeaurora.org> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v2] mm: page_alloc: Add debug log in free_reserved_area for static memory Message-ID: <7027fa91-296f-01cb-6c5d-d25c81c835d5@redhat.com> Date: Mon, 11 Oct 2021 10:34:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1633936279-26856-1-git-send-email-quic_faiyazm@codeaurora.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 01AF170044D4 X-Stat-Signature: smu8cq6kc9ts1tewawuttusf7tb8wowf Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FbNUvnQu; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf02.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1633941284-749721 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.10.21 09:11, Faiyaz Mohammed wrote: > From: Faiyaz Mohammed >=20 > For INITRD and initmem memory is reserved through "memblock_reserve" > during boot up but it is free via "free_reserved_area" instead > of "memblock_free". > For example: > [ 0.294848] Freeing initrd memory: 12K. > [ 0.696688] Freeing unused kernel memory: 4096K. >=20 > To get the start and end address of the above freed memory and to accou= nt > proper memblock added pr_debug log in "free_reserved_area". > After adding log: > [ 0.294837] 0x00000083600000-0x00000083603000 free_initrd_mem+0x20/0= x28 > [ 0.294848] Freeing initrd memory: 12K. > [ 0.695246] 0x00000081600000-0x00000081a00000 free_initmem+0x70/0xc8 > [ 0.696688] Freeing unused kernel memory: 4096K. >=20 > Signed-off-by: Faiyaz Mohammed > --- > changes in v2: > - To avoid confusion, remove the memblock_dbg print and drop the > memblock_free string, now using pr_debug to print the address ranges. >=20 > mm/page_alloc.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 668edb1..395df3f 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -8153,6 +8153,11 @@ unsigned long free_reserved_area(void *start, vo= id *end, int poison, const char > if (pages && s) > pr_info("Freeing %s memory: %ldK\n", s, K(pages)); > =20 > +#ifdef CONFIG_HAVE_MEMBLOCK > + pr_debug("%#016llx-%#016llx %pS\n", > + __pa(start), __pa(end), (void *)_RET_IP_); > +#endif > + Are we missing parentheses that the code indentation implies? Further, I think we want to use "%pa" instead of "%llx" and eventually drop the CONFIG_HAVE_MEMBLOCK dependency. Maybe diff --git a/mm/page_alloc.c b/mm/page_alloc.c index b37435c274cf..e7946e5ca094 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -8097,6 +8097,8 @@ EXPORT_SYMBOL(adjust_managed_page_count); =20 unsigned long free_reserved_area(void *start, void *end, int poison, co= nst char *s) { + const phys_addr_t pstart =3D __pa(start); + const phys_addr_t pend =3D __pa(end); void *pos; unsigned long pages =3D 0; =20 @@ -8125,9 +8127,11 @@ unsigned long free_reserved_area(void *start, void= *end, int poison, const char free_reserved_page(page); } =20 - if (pages && s) + if (pages && s) { pr_info("Freeing %s memory: %ldK\n", s, pages << (PAGE_SHIFT - 10)); + pr_debug("[%pa-%pa] %pS\n", &pstart, &pend, (void *)_RET_= IP_); + } =20 return pages; } --=20 Thanks, David / dhildenb