From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD741C54E67 for ; Thu, 14 Mar 2024 15:05:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BA9B800B6; Thu, 14 Mar 2024 11:05:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 542FB800B4; Thu, 14 Mar 2024 11:05:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 395C3800B6; Thu, 14 Mar 2024 11:05:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 24651800B4 for ; Thu, 14 Mar 2024 11:05:44 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9803440A55 for ; Thu, 14 Mar 2024 15:05:43 +0000 (UTC) X-FDA: 81895968966.10.75DF7F3 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf21.hostedemail.com (Postfix) with ESMTP id 3F4F31C0003 for ; Thu, 14 Mar 2024 15:05:39 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dW+v0PMg; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710428741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+VVVPlg6jpI2Dk1K8dVnVw9Kkr5j5cEZavXwc/2b4RQ=; b=75flxSQVHdrHA7lJZPdBPHTTAnSWhXhDbhP0F5ewbiIeSlnTH6OpAI/HElGdFVOldKn+nZ GemdbKKNE8V/5ZgGNXrYJtJmPKFu46tv7ju+edoAeClD4wyzaz4M5NyO/r2a2IZ+1Cyjxw sNubPxotkudADFPzV0VGPVJwAVP8cKs= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dW+v0PMg; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710428741; a=rsa-sha256; cv=none; b=cMtNR7eN5wW1V/TWQvqwSWfG2zKpwrNAXDWYOvmeJR2WiHtspokQKJUM8syO7wGa3NTT45 OV/eMMnV5hIi/geJQdbpVXPkLWF366ESAeN46lQcN/KcQHhsLAxnESFsaptk89QlynYcmy CTkquNPG2KmKeR0CAaTbqMDeGHm7Il4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710428741; x=1741964741; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=NppUhHd3UgH8/N6Ittb4n65yRyxO8UlaIeClkqFgfuI=; b=dW+v0PMglnNbeUbNFA9b4fAP/eB5mG6JmnKbfI4wGDBp4bd91ycuRYme 40jzwXWr8iz1UcG/NlorXrLmAHmTLpQCnHm8+hB+NLNJCI4+GCTkz8cit KlhYWWW8/+/lVrvbsckIkZbswjpNZy1nPKLKfOXaGdjFMJ33j5qhRXKD5 8c8z35eJ25qC2B9pD6NTTw91WhJ9CMjGRX9dHXOLzg+WZ9KQ0RdnAp04o tM7X1MM+89Lw92NE68X6cgjlnyLx+yexWTmIPdGHT027Ls0LZePya0fyT 0mv5pH9mACSeG5fFxnxIGFop9LTLQaUTZUZN4UfYIKBTSSZsto56KnsbD A==; X-IronPort-AV: E=McAfee;i="6600,9927,11012"; a="9065365" X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="9065365" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2024 08:05:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="12249529" Received: from laallen-mobl.amr.corp.intel.com (HELO [10.209.21.198]) ([10.209.21.198]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2024 08:05:34 -0700 Message-ID: <70261e2a-b87e-462e-964e-95a51ecde978@intel.com> Date: Thu, 14 Mar 2024 08:05:35 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/pm: Fix false positive kmemleak report in msr_build_context(). Content-Language: en-US To: Anton Altaparmakov , "Rafael J . Wysocki" , Pavel Machek , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Chen Yu Cc: Pawan Gupta , Catalin Marinas , linux-mm@kvack.org, Matthieu Baerts , Mat Martineau , "Rafael J . Wysocki" , Ingo Molnar , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20240314142656.17699-1-anton@tuxera.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240314142656.17699-1-anton@tuxera.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3F4F31C0003 X-Stat-Signature: d7e9fqb85zbr8b7fpinkg5gcgitirqwy X-HE-Tag: 1710428739-965859 X-HE-Meta: U2FsdGVkX19xUg3TpH7Ql4EGkYKCfoRkSaOkPjLLcuzU9fggIG2gD6jC22Qz7k55JHiOCzjNvBOSOZuyDmjD+f8X+XH0yUCiNF546ZJoR5kV2NjoB7poaCYxL3LoS7kMAOhYY4xAN/DiI7cj4eSKgYfx5V6Oq9mgUOBMJi4xn+hAC7PD/Zkyn9ZG3wPzZVDDGE//WEiLi5vuU7wuwYPNQ35awcbZ6rwdb2ojFyacg0aZnFN5fFwnYAbBIaLwb1xZBFvQXfzDt3iNSPt+TOWTJE8phu9qdiV6Yt0PV0Hl4I6d87nd4LBo1HLSR9EgdwpYGUyODrCYOY/ize86gKn/FJM3jL+uiZrRjKKUzjJ/UoLOC9f/QfT/mzBuTEcP631Ve03BlzwJjmMot42xw9+LVWQ9YZD45qIR7nYkpEQDTEXqAAP7G/RWDKJfzX+HDc3B+yTR1ZnxHKvSZ2pbJXV3v+FFQ9VR0u4hOSOpjSJMLtkMiI4xeEpe56ZvReABAadFIyu8evACLK06uYnm7EWzDSNBaJwu8jYj3V3BwyqTccnORujG2VtXrvHI1tKJknUEVp05+m+im4roF1v7jvjV7EAZj/2g1usXa81+4R4I6EngJmkb2DQ7yXQ1jtKQYMpKAiYp8EFqmKjWkph6Y7HiYY9PRNZCkH/586U1lU4R8+R7gW5Y3ka8CvIrYv9h0z9Qv/vU39ciJvr+Nn8G6ZkkrmpXxhlXUGqW3/JyGCnQTUu259/84Xyt7o03JlSkXjqKKopST+F/MNoEqHNeJlYcWFYDG61TBy8ndfPHJk6vjpb4kMo1WWyARr1veRSBt0nhIpj8/Y0U2ZGSOtPAT6qL8XLRI3mY5N7U2YcE0K1nKSwFXC8W2SgrPthphJmJUnQxAhFqk2ho5aza1kfnexu1Q3X8FFquRQYeaVOvmFzN6VTZcfrH+3aVdg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/14/24 07:26, Anton Altaparmakov wrote: > /* image of the saved processor state */ > struct saved_context { > - /* > - * On x86_32, all segment registers except gs are saved at kernel > - * entry in pt_regs. > - */ > - u16 gs; > unsigned long cr0, cr2, cr3, cr4; > u64 misc_enable; > struct saved_msrs saved_msrs; > @@ -27,6 +22,11 @@ struct saved_context { > unsigned long tr; > unsigned long safety; > unsigned long return_address; > + /* > + * On x86_32, all segment registers except gs are saved at kernel > + * entry in pt_regs. > + */ > + u16 gs; > bool misc_enable_saved; > } __attribute__((packed)); Isn't this just kinda poking at the symptoms? This seems to be basically the exact same bug as b0b592cf08, just with a different source of unaligned structure members. There's nothing to keep folks from reintroducing these kinds of issues and evidently no way to detect when they happen without lengthy reproducers.