From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F5D1C43463 for ; Thu, 17 Sep 2020 20:55:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1309C20878 for ; Thu, 17 Sep 2020 20:55:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="MQPydcNW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1309C20878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D31B6B005C; Thu, 17 Sep 2020 16:55:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0840D6B005D; Thu, 17 Sep 2020 16:55:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDA7D6B0062; Thu, 17 Sep 2020 16:55:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id D63676B005C for ; Thu, 17 Sep 2020 16:55:23 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9557D8249980 for ; Thu, 17 Sep 2020 20:55:23 +0000 (UTC) X-FDA: 77273758926.04.quiet49_3d134b627125 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 714E8800EFA0 for ; Thu, 17 Sep 2020 20:55:23 +0000 (UTC) X-HE-Tag: quiet49_3d134b627125 X-Filterd-Recvd-Size: 5204 Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Sep 2020 20:55:22 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 17 Sep 2020 13:55:08 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 17 Sep 2020 13:55:21 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 17 Sep 2020 13:55:21 -0700 Received: from [10.2.173.225] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 17 Sep 2020 20:55:16 +0000 From: Zi Yan To: Daniel Jordan CC: Andrew Morton , , , Anshuman Khandual Subject: Re: [PATCH] mm/migrate: correct thp migration stats. Date: Thu, 17 Sep 2020 16:55:14 -0400 X-Mailer: MailMate (1.13.1r5705) Message-ID: <70175233-F250-4072-AEF4-659DF73F9F7C@nvidia.com> In-Reply-To: <20200917205912.fljcyldna6bg7m4l@ca-dmjordan1.us.oracle.com> References: <20200917202729.1460743-1-zi.yan@sent.com> <20200917205912.fljcyldna6bg7m4l@ca-dmjordan1.us.oracle.com> MIME-Version: 1.0 X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: multipart/signed; boundary="=_MailMate_AB6C36DA-A6A6-4127-B6B8-6BD347044092_="; micalg=pgp-sha512; protocol="application/pgp-signature" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600376108; bh=YvADe2ZL90eoOWfjmzJTDfz7rKtmDxYSNyCrdCAx3kc=; h=X-PGP-Universal:From:To:CC:Subject:Date:X-Mailer:Message-ID: In-Reply-To:References:MIME-Version:X-Originating-IP: X-ClientProxiedBy:Content-Type; b=MQPydcNWJEUPiYdzWav0XURQ5C6jZf7w49Os0xHgSdXpo4txmgYnl2UkHpt2Yj5Y2 8lVyFAdWkljBK4tnTj7/cmXe0W82kXydnZQfhRBAHISbnOPJRGsN5kVVq2I46XBMJV ipdigaOLzf+sOyokI5W1cZ3q0de6HCh6CoEpbgG69keLYYzpKhosWPAvDUaoFXCdfq YD86M9yPLA1mdJGv5i7JhxXbb08bYNutTyUH2qpKcxv3jziAZTFPvjan0drqc2/WIs LwwTZ/UtB3kivi+djCZrHGcAX2DLxmiBQRafpbwHEgtagZTGZIOZMbiuueENJU3O9M c5c9dWN/RFJ/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=_MailMate_AB6C36DA-A6A6-4127-B6B8-6BD347044092_= Content-Type: text/plain; charset="UTF-8"; markup=markdown Content-Transfer-Encoding: quoted-printable On 17 Sep 2020, at 16:59, Daniel Jordan wrote: > On Thu, Sep 17, 2020 at 04:27:29PM -0400, Zi Yan wrote: >> From: Zi Yan >> >> PageTransHuge returns true for both thp and hugetlb, so thp stats was >> counting both thp and hugetlb migrations. Exclude hugetlb migration by= >> setting is_thp variable right. > > Yeah, shoot. > >> Fixes: 1a5bae25e3cf ("mm/vmstat: add events for THP migration without = split") >> Signed-off-by: Zi Yan > > Reviewed-by: Daniel Jordan Thanks. > > If you wanted, you could also do this. > > diff --git a/mm/migrate.c b/mm/migrate.c > index d1ad964165e5..6bc9559afc70 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1471,7 +1471,7 @@ int migrate_pages(struct list_head *from, new_pag= e_t get_new_page, > * we encounter them after the rest of the list > * is processed. > */ > - if (PageTransHuge(page) && !PageHuge(page)) { > + if (is_thp) { > lock_page(page); > rc =3D split_huge_page_to_list(page, from); > unlock_page(page); > @@ -1480,8 +1480,7 @@ int migrate_pages(struct list_head *from, new_pag= e_t get_new_page, > nr_thp_split++; > goto retry; > } > - } > - if (is_thp) { > + > nr_thp_failed++; > nr_failed +=3D nr_subpages; > goto out; Yeah, makes sense to me. Let me send V2 to include this. =E2=80=94 Best Regards, Yan Zi --=_MailMate_AB6C36DA-A6A6-4127-B6B8-6BD347044092_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAl9jzTIPHHppeUBudmlk aWEuY29tAAoJEJ2yUfNrYfqKnysQAKMogiBkhHXHcsYRoMTuXzPAcuvY7YdD8Vi6 j7RLsGNeZ/Sb+meTDrRaBRZiSAETgYCDiQUTJw7BJGDE9D4KVtoqccAugoEeO4+2 YT4Yg4/sVlZpZ4kXv9kc5VAIsKgilfB+UVA31p4xJVF/6a667SehXkAlfRtjEPhH o7CHggVYaPMhEk+1CnzSA47en8Xh1Q1+FAxnZc5+bUxN2s6xzH92DqfW9irpYNXr 1TkVBKwPRBc8FgDeDV1iEnXMv7frxFFNomkNMzr5mBf8xJQdxcUtilaYxedflb6i 2ROw3cTQ35ndFAKlJl0KKICL3xhe/yLA6vyXnyw8z1gNDPQC5WcP1pJ3xmrrHASX CYrRzeZJI6JTOOqEo3eoU4HE43CQlFxxMLwZv8qjTnL7dSTdf8cTRAWjQ1DnvRyB fmJ91QUmYQ4WGB6BFkG9SAGiV1w8eWKj6qJQ8xQAjg5ZQphsS/Prr9gK/auxmSc5 p0HLzNFtZvzH40Gkv+GRMstcBgZj9jjsVt+RFHX+blr7ux6QZq8OCE+KgPlHO6xd WzeglXTA7DRSUKYAUEvQHalLK2YSekqMfZqxaIWdzbKZEAoF3YIHh6Qj2gWEuyzj PgvRha9oekAYaN2/AwCL3EBr5UVX9n77Q25eMfeiuurJ25BT5/JA7PZ2bvRnWx8i k5dTUmQY =iPpR -----END PGP SIGNATURE----- --=_MailMate_AB6C36DA-A6A6-4127-B6B8-6BD347044092_=--