From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C884D216A7 for ; Tue, 15 Oct 2024 13:53:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7B706B0083; Tue, 15 Oct 2024 09:53:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2C326B0088; Tue, 15 Oct 2024 09:53:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7D576B0089; Tue, 15 Oct 2024 09:53:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 938676B0083 for ; Tue, 15 Oct 2024 09:53:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8E3A9ABDC7 for ; Tue, 15 Oct 2024 13:52:51 +0000 (UTC) X-FDA: 82675977888.10.125C00B Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf19.hostedemail.com (Postfix) with ESMTP id 6AFEC1A0019 for ; Tue, 15 Oct 2024 13:52:56 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=MzHkfJcC; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=si2aXKh0; spf=pass (imf19.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729000195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uWptQMHMx4JfLdyzJJmRbbxYnkUIFHS5oGsF+EPd3OM=; b=ORI4gYxMcBeDB2RJJ7R2v5pLKjwtkHXwVEe5m4WuO/fL3Ryy637Qs53Lr5fM54cXwcYjtq QAXQnc6lpKOudXCgsKU9sSNVjaOCru7aAv3RhtR+ZI3HfBEwxnEBbWzCMrp/fPRz86Dd8X 51O9/Eq7v4xPQFhYEpWUIrjXMWYbzgw= ARC-Authentication-Results: i=2; imf19.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=MzHkfJcC; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=si2aXKh0; spf=pass (imf19.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729000195; a=rsa-sha256; cv=pass; b=1Q1PA5KLJgSXtOSiiSWbu1mf2JEfB11aKP5VAvel3WglntAgy9l2B0SP3Eguh2uKNcHPnG NweHdDbW9Th639sGqLxoS27+BWDuKto54f16LcsXm/KYicDJpL3nJsaP9Rk3BviT/kBLQQ cMNG4nR3kZfRpLH0TGxMsFP/3kM6F3s= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49FDMgGt012292; Tue, 15 Oct 2024 13:53:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=uWptQMHMx4JfLdyzJJ mRbbxYnkUIFHS5oGsF+EPd3OM=; b=MzHkfJcCpfKTCWDxOwpglxqgQiFYGEs43e P5BbiK4q7cm2XDFKeHI8++trxZK/fhLEuZECcwVVqje/13PSEIqgm32KQpaIe667 8GfgpoJJlC2vosb2K+gioEBhZXbGqkwpmSs2lEVAXAH4bWf6jXWumv4E4Y8wc9jF mpcxikNEQQUr0I2QhfN4gW77ijUAaCtP0ObWLjZ3IDIqJMVcdfQvNXXaUjQPNBT3 Gt6d1tzq5v0dw8N+O3XLW+Hm7TyChUocz8C4PCx3KFl2cs2TNlg+TlpUSkycp4lV h48B4EXiu5qj454RIYXMeb3EKzrzcB/xnCuWCveZiB17L6ummYjw== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 427g1ah0vy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 13:53:02 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49FDftNE014020; Tue, 15 Oct 2024 13:53:02 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2048.outbound.protection.outlook.com [104.47.55.48]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 427fj7etya-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 13:53:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xQmv7Ns93Gil4Yb/ZUy20EHRNb5v80K6PRgmeH0MxbkJ2/pMAdaFrEeZUCOLBSs5j8Ym5Dj0Cwd8SNrYO9oXzdF81A2TPFnQdwsc1SHiHabBV6WvlRM8Io/zjYMKnjinFlnSHXV87hcawNyHffp1NMsg0HTuhPB+MmrB15DItJLQyQf1N4eWko3OfijUA+QzGVBSjbGSOnZ0npbg8HqMAY3F1+7j+ibwF+2Na774WXsDeEemvGf1qHrT0LNncVaDfo5nqtve28k58526QBKWYdQuzoilYIFh7hKy5okk+jWBuXzMnp5Bg8M5pjRT/tXtShzM4OEhDjiVBATSn+fNAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uWptQMHMx4JfLdyzJJmRbbxYnkUIFHS5oGsF+EPd3OM=; b=lIqWt2BGQ/2NXNRixwGN/pCZc++/HshB3+JjWfKEOf3jYxQgL1oWdq/ir/TC+3wKZkItN2BfmUj29PWGbjrn8RrCM9YGutLCcHowQk1H65WaDfJr12xpnQxalnYXJH0ccT0uKrbpn1asiHoWC467T5IExKKCYyS74EFrePHy5i/N0pXEW4FvQCa29ZjZfANlQkXpUj0BlSP95MXHloSWpTxeYIbyfP8scQVqqjRTH+DIiqaN3YQfjVSVUn7I3JeDusryCtl+RN+kmroCy9A437xHvzLC089r9vuSWvmhyk14BOhYJm6N3sm3t9yimaxm8jAyz9s9GcSItZvFvFXglg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uWptQMHMx4JfLdyzJJmRbbxYnkUIFHS5oGsF+EPd3OM=; b=si2aXKh0RCVQXpEOUJbivFZ2/kSKgH2Fb82wY3o/52kXRkAaktQud+lZEtogUmmBSsE1JLJr7y2e+z2vhBK3tew9tnJ6Xj7lsfMuGNxz/X/6Oqtci8NiNAp6rKOxtOZC97vaRVa8MeT1Ngj6Y+t8p3XQZtR9oKv8TS3VZ9TfYcg= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by CH0PR10MB4860.namprd10.prod.outlook.com (2603:10b6:610:db::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.27; Tue, 15 Oct 2024 13:53:00 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.8069.016; Tue, 15 Oct 2024 13:52:59 +0000 Date: Tue, 15 Oct 2024 09:52:58 -0400 From: "Liam R. Howlett" To: Wei Yang Cc: linux-mm@kvack.org, Andrew Morton , Jiazi Li , linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org Subject: Re: [PATCH 2/2] maple_tree: Add some alloc node test case Message-ID: <6zslkyydiamukudqgakplkxfr2ie6jfdnltfinnishseb3twbk@eszq5q3gkgwo> Mail-Followup-To: "Liam R. Howlett" , Wei Yang , linux-mm@kvack.org, Andrew Morton , Jiazi Li , linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org References: <20240626160631.3636515-1-Liam.Howlett@oracle.com> <20240626160631.3636515-2-Liam.Howlett@oracle.com> <20241011011759.wbw56sqgmhzjwo4k@master> <20241015133125.aixhbw5kunbme2nt@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241015133125.aixhbw5kunbme2nt@master> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT3PR01CA0029.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:86::35) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|CH0PR10MB4860:EE_ X-MS-Office365-Filtering-Correlation-Id: 3b905dcf-e84d-4a61-bcbf-08dced20ae39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mOkfuSIJDjpw943qeNY5T+mcZZR+e5jyRPwRHBPmTygo4Cetdh9SQ97n/IcV?= =?us-ascii?Q?60WThtMeoNKKiOZpvHeilRObX2PnkCd/TFYUCnKCuefdE7doz57KAyVIdbpP?= =?us-ascii?Q?oCfowtsHPyXFq90BF2FQCEDF3lZaDEx71NzDJAYIDG0bLx38PO9l7ISUeE2U?= =?us-ascii?Q?cgJQGgpl4iVeGrp/6jsBOYRyvarFeseMIS6Til7EyFFxBYgnUHdt5/U38Xxv?= =?us-ascii?Q?YDsaFngIsZEWZ53T6dTezRI/E0GV68zTTclpUDL3WYqvBgLIbR3MLK1ihuhJ?= =?us-ascii?Q?LlC6KSk2hazPy6ezEo5rk6ACTKw5I2vxDQ8geHwsccmEagyPAACIevb1UJg0?= =?us-ascii?Q?2V+YmIMUB4+GArQXrzoGD1plflNGhtG8UWZb2j/yCgq40dxLJowxW7PygHJC?= =?us-ascii?Q?WDd8skow1xY6V6GMSUTs+7hGKZHJhs+LeNJDdsZxw2IiCJ2ZSvvJynvcwLpu?= =?us-ascii?Q?TkOV0vGsUA8WHMIfgUnmj9OL2E0ehNRVO/A0iLJPh0HQ1a0rhxU7FQovoJhr?= =?us-ascii?Q?ea3e4BYyoCU4EruMJWY24kFe2oZ5Gzc106JbkrAI5NgbCwE55OQ2sVEsRtKP?= =?us-ascii?Q?5FHpx6GL6tT/9hJfFOpkpeb4/Out94pKHrIMjOPyR4crh6dATX5e+D2c9lLU?= =?us-ascii?Q?NPNaGzVkhDckJyCBr+HmKs+A2bbBdhs1H013A+D97WHJIcQT2XxYilSB+6PE?= =?us-ascii?Q?AHBnZfgRBZxENmjDH1ZSCJdUbQ7o+kKuXy4YJ+6d+lkiP7athTkultkiGCSP?= =?us-ascii?Q?Jb296eowVyx3h4wpfB9PcTY/mRCyc84rBUBK8+y58BruThSz5PU/JRN2UA5r?= =?us-ascii?Q?NgPb4BOnUBeqRUHwXCI9/ac/1xDZXpNuJ6cx6JSzLZkyrJdI40Hyy/sRKA7v?= =?us-ascii?Q?wfq/8q5ANof/qyySTjiy6ezqHcQ+1xnL08cLqZ5GqW+aezn16/H0t04hqxXV?= =?us-ascii?Q?+DPvhCvSOwprnjlAihk/Y7MxQpA64PVz/XCILbvAPZSZ5zb2BAIORGX5p0Kw?= =?us-ascii?Q?wXifkIvsYbDjcHrmFuDClFtfItAT6VjGCyyZ7rPTD8fBNrzcz+RJscyqpsKs?= =?us-ascii?Q?FCa9RzflpVua6HQzXd5k5PducdxUnag8FaoQq2lddoUPGizIOhZaaHLvJ/6q?= =?us-ascii?Q?l55I0OESdysPDjW3OKQI/wkdTpj8ddUFI3gg0zmO2qAKqDPmeKhO22uboy8V?= =?us-ascii?Q?aKwxj+xOEgHOv4wx9o/I2UyrN/lUYx4IvZjsW1bhjFb2y/PS2gNVXPWHZXCj?= =?us-ascii?Q?D6AyWZi/i7bS+FAyNIIX6t8IVDFxWw5UYTdpB4yGDQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vBUcpsxhG9ThyWFBzgjJ6GBqYdt0+eXFcescKFIzpcuzvBXBh3AGDBpcwdld?= =?us-ascii?Q?7MzrHHQtnlIi/JeSgMbjUnIZOM1paRN23B296IXFyb0Q5iqiF5earAjCT08C?= =?us-ascii?Q?4xmDK8ovqaunZOp7fW7vQmXCY3RLivDacfpHE4iJHYQ1l2/eoi2s/bCPdVYc?= =?us-ascii?Q?2ILd0tNWUNgh0/eeZDU7Lf/QoNyl41vjB9uNuJ1hOmiP5M7ZYRv9bMt31KMA?= =?us-ascii?Q?p9d4pQb6+R4ZgSH5+QhEgQt8yHdy7RY1RNyPYcGniPud6nQWkGGWlCib/vfH?= =?us-ascii?Q?JR99W1Sn6Q1JbSfTUoFyd37RF0snO1pf6XueRjn7dPFd6ce/0QRY7Og5kGX1?= =?us-ascii?Q?n8hnazBMRBDLne5WEeGsYmm71MyLqVE2twJ1eJqkQvxEhIu2+kjcfOt0exR7?= =?us-ascii?Q?Sdj4szypEvIwEAoNgy9wjfvZZ02nNX8YcIITQFNPnK754aiK4cVVXw/g0LbF?= =?us-ascii?Q?R5GrTwnripgI/a4l9Yjul5gEXzqmX91pYngj20h7MRBQVuU1dheNwkXI/qD9?= =?us-ascii?Q?FHgSAFMtz6rvf4ZJiSOUZpsLBJVKWUfFC1Kdu3cxoYbsR+Q2qIWijWriz4CV?= =?us-ascii?Q?ORnnXeaz3oLsJTXHJdX6+SmmSrjnvnrGRyN7riW2THIsox7cu5rS3gLJiL4R?= =?us-ascii?Q?zzUEZU3M1AEA43zRlcCYGd5q3AIK+P/4oDzBRX3F6OmhBC9Ihs3C+/SDbJvO?= =?us-ascii?Q?5o03ncvUdIh6m5ZvKUP2mL8m6D+1AlRA8AoSSK63Hz9tzCIaD2QR2gIuHra6?= =?us-ascii?Q?P6n71TPGyH4+2rMpFMBSywvmH/08YVkrAJZCX/JiET12cOjVP9tkB+wH748/?= =?us-ascii?Q?MKEX19BsFHZtZ07koul1ls/wZO7+t0ULJUw3PjZGp5HBqCMy/hoaifHXf+ue?= =?us-ascii?Q?/rf24hZSjmZOW34AtuQmSeHVEzkRo0I5+i/zx5Gp6eA9rmpb4fKCJYB3rqoH?= =?us-ascii?Q?+IeQuYJGdqrcRSFwJzKZsnkwCJqOi7gMp/Qpu5f6a7Yo8fVRXPrzsQhLix/L?= =?us-ascii?Q?0T0QJWz98t8zMgANisE5WYmv8Ana5Uw4nN394kJFc4yMyqNqEbxDg88XgL5Q?= =?us-ascii?Q?enWBhGJgcooflmBVt4WFv+PGA75OoBmHYrv1YjJK0jktC7l6UPFTmMA0qxni?= =?us-ascii?Q?gBIh9oDmVflf7+ETCCqtofPH3C7PJlqTL+Fq0XIYebhfDvVXfVBuVGoH2W23?= =?us-ascii?Q?4CHAqsdBDeVvY9mktVl5i4r66DHcpJL//TVUR2dUl5b8VPgsmtNaS80uYQUN?= =?us-ascii?Q?1xPW6VQL9nXL+l8OchRWtfDvYZEtM5U5XukWmDrtBu/Q+lZCWkk4M9OfZvGr?= =?us-ascii?Q?0tHMAOLmNytEt0o/9v/QgqB7TSBgsjNBY4o/05L3OYi4nz1ZfOXOqJU/vS5z?= =?us-ascii?Q?4iKlmlvHr0LtSvZvax31mmvVx8oUWRM5BagGrmjIhJHQPx8xxZIuSeivnJlZ?= =?us-ascii?Q?5LeTwkHhJCgvFL5Zlfl21oKxDBFSkrTskG9bSxE3Riz/wiwyGp5nYC6NOsDE?= =?us-ascii?Q?BDjuHX6bEW0cvnAaO3bGaUTdXTf4UBRBDu+YFI/SWcsTiqn27wA4qpnoXU2V?= =?us-ascii?Q?XSHPtdQTO6tHTLun7oehVLWx+HUXjzKpZN4KeN9T/vLCN/oLhdr8TCMnJk/W?= =?us-ascii?Q?nA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: JaVHetOkPS8z2n8u7ih86or0MSN5sav3QVrM9+2Yi4JV82QwZcqniI83Lyl1z54V6oVi9tMZXrqiDiLC1FDeb57E3UvuaQnLRHIWhUs/lSxA+kY9jphmr8JZnJ9x33Koe8GZEwo98sL/tE3mZ7AAaL1WwLs1AEaBU0mHk9oQPADrB2vuVxKNMhBUnpX3dzc2VX/J0X3tcnjpUJLfkRBncMrZxHi/veSF2gKcbEI3g3STXhGH6zDuAMoi2Cp5GlqJi09PfaZQu7YLxWjfI6fch3mcanv4eE5pUA+QT2VLMiWlgAVAOToskQUkA9Jfwwuoh5hbbBdRPPp3csc1TRpQLVbImLjF/QbApNujxrs0VXR6L7TQBIHYM9bpZ/6YYOLhuBPOfRyJwaZcHvD0ah7BeG8c3JhpdFq46ZUW7JQBz6G/uKlHmlG2B2YypP3+mXam6LLxzrJF2+roWa5Apuj4GoO+82B32yHNSPFAXf1d1aBTMxmChvBJnP//qJj2dFwmXsuU89qYGYvU577WXi/unQ63RMJndJvMUPpZNVETQom6qKokf41w/q1zd4IBsuOfwl3hxesf0M3wR3BkzoNbXJs8cBrZ3nARNcn1cKUarB4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b905dcf-e84d-4a61-bcbf-08dced20ae39 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2024 13:52:59.9251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J84zLbE9XksuNwvVPgUP9E1NL2ZHfJJwbFdY6d+p6mScTXBNG0SeDTNK49NWf9oAuQin4qElasoyjdwT/PsGbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4860 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_09,2024-10-15_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410150094 X-Proofpoint-GUID: xPK3BYv67fCuBMxgA4ezEWj4G9jtKwgw X-Proofpoint-ORIG-GUID: xPK3BYv67fCuBMxgA4ezEWj4G9jtKwgw X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6AFEC1A0019 X-Stat-Signature: nztaz1gjyt9o83m535arrsznaz1spw7g X-Rspam-User: X-HE-Tag: 1729000376-119756 X-HE-Meta: U2FsdGVkX1+VVvtPEEi/m3bAf8XElmwMilML+7vNGUeBe7THIJqSiF1yZo7FLgdAeyFgG0aWaGprSNMr2sKZUJOuppABZQm/7PExDTH9SnzQouLIqK3BQ+6KBp7SwJhcJZfjLnbm8GYc3DM5ODAAz2I3btV4froWABUm0Ea5Oyt6O3hdLk/ZSCHjf1YNCeir/D4QWOOa6ejooYVrZeET9zR+LiPWIbw44HRjM1CvaPOlsQEUfDLLG5iUtRV9Kr2B5s/SohKVs36e1i7ZskIhCNQFbpM8mxji5nc14LbdsVIcPT+Bo2ApFb4U6j5H3VB7OdcMXdJDvTJhTCLcaf+Gh9/Pt8dL5QlYnUJ3QXqO1/2D0/FKHpb6ICMeD6UlVQj7jgAu5yoCHsp+7A5zmeHZgfh907LabDfWJ+PiZq98ksTjGp5kxuFWUXKBTcpmWaddwQi1zbNABs60UMR4XxJ+WSnS0kVeWQsclW1JoXex2MSz+0wNGcCUx2go7YWOEvXPSmlJXCXyFUMleF2swRqfoZArmZ1zj6tIP63tpIQQ/T+Pcz+C64kE6wwuahsFFMys4y2/nQRAGzRFAg7XQg63vpUwjxoK4foyXiJr7isbXywoX6er3sWhlcAWbqSfY2LkVi1xbrU5E9hQ7gP2fIMIpWm4msVtGHpLvQFt1G8N0wt0bWFkX724ijDUOvKgJjV7DydGEebXTIDB5bf7bR97vXwCsdSQ9+iMhV/wRJWxn26TBNeNQeF81LyC0W/A44XWE/G6yDtmBq1E/AsZkrTBSOKJMjsx7IGQU4Kww37yx4gFrsWl7RycP9AKyCR1mt+S7hPG/fGm4T3yijGC3gcbtI3xfBfNKDtzqHiLvWqwZz2P+3CIdaUav0d2ZNKJZZTwYzFsfSIVBsp8IGj5gtTiY8TLPpvP1pVDbOn470OZFFV2ePq4w7PjKNhHrSRnShgfYmyXHTut5T3XbewvlmW 3x857Rx2 m/Gh+toOAD14vrzxJZGI/SLjTmm1EJ3u/EkSavcr4OxzP4aJPQLH0V3Ke0Zfgvp0BjVa0SGLnDLptiuKznoHunv/ST/TuW5+Xl+NbkxIEFqgN/waguPEoPfVWJIpPCroIOEa/WYowP4S9gxEVV+pvh2VIhl6zl7RYCOiOYWLCBRrUx5SGw34mlBDutNnH6rujYWaus7O77A13qc5gXsRjoGbBwJm+F9gOj4VYgHXnzOgDbjP0tt4ejelu/sR31ysiA2hHaiFBtnBPCkr5ZMeTB6IB5WO60CgOCoDGQu8zoMjAMG96uK3GnlZCnLFdMSSQU3q9SS9pTj44tceaD7JVNkuvATAWpoq+GPq/lqhFetPz7aMtEA1JoWn6HTxQr1hm18uYv4jd04RXiko92IgtxXX+f/1VJbbbv9FiIBTX7PldDoMtSRXu32zWWWPuxo6B6dhCxqX15eswxgtxwTyUEkk3IBJ9P0TWvK5QYEEGJy3WdnsCcbZI2ze3I7CIdsBxxnkxvT2BKiqaLWs0WGmXORJ8UyD14+sdN+j/gevurd4nfZr3/EDWTInlGjqS2Ur8SKwuazalL1r7brv8Ffd51y8WsvWK+shh1suVj55xBwcbDkbfLM6Giw0rCglzq4FgXWRfxWQYb1CLs4P3MvE4fC0o08t1EHQHcTIY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [241015 09:31]: > On Mon, Oct 14, 2024 at 09:15:07PM -0400, Liam R. Howlett wrote: > >* Wei Yang [241010 21:18]: > >> On Wed, Jun 26, 2024 at 12:06:31PM -0400, Liam R. Howlett wrote: > >> >From: Jiazi Li > >> > > >> >Add some maple_tree alloc node tese case. > >> > > >> >Suggested-by: Liam R. Howlett > >> >Signed-off-by: Jiazi Li > >> >Signed-off-by: Liam R. Howlett > >> >--- > >> > tools/testing/radix-tree/maple.c | 22 ++++++++++++++++++++++ > >> > 1 file changed, 22 insertions(+) > >> > > >> >diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c > >> >index 11f1efdf83f9..b4b5fd9f294d 100644 > >> >--- a/tools/testing/radix-tree/maple.c > >> >+++ b/tools/testing/radix-tree/maple.c > >> >@@ -462,6 +462,28 @@ static noinline void __init check_new_node(struct maple_tree *mt) > >> > MT_BUG_ON(mt, mas_allocated(&mas) != 10 + MAPLE_ALLOC_SLOTS - 1); > >> > mas_destroy(&mas); > >> > > >> >+ mas.node = MA_ERROR(-ENOMEM); > >> >+ mas_node_count(&mas, MAPLE_ALLOC_SLOTS + 1); /* Request */ > >> >+ mas_nomem(&mas, GFP_KERNEL); /* Fill request */ > >> > >> I am not sure why mas_nomem() is here. > >> > >> Without this one, we still can trigger the original bug. > > > >It will fill the maple state allocation. Might not be needed but > >doesn't hurt. > > > > I took another look at it. We really need mas_nomem() here, since we call > mt_set_non_kernel(0) at the beginning of check_new_node(). > > So mas_node_count() just set the request count and mas_nomem() does the real > allocation. > > Any reason to design test case like this? There are two types of testing that we do: ones that can call internal functions to poke at stuff (like this one), and ones that can't which is more like what users can do (lives in lib/test_maple_tree.c). Both are important as this checks what we think will happen while the other tests the integration of all our work together. As for this particular test, the two parts work together most of the time, but if we run out of memory then we need to test them in parts to make sure both are doing what we think. It also means that we can easily set up tests for scenarios that are harder to synthesize using the external api - but they can happen. I'm not sure if this is the case for this test, but there were tests already setting the allocations into certain positions and this is now just another one of those tests. I hope this helps explain some more of the testing work here as it is extremely important. I'm very pleased to have this setup to recreate issues for both fixing issues and ensuring they do not return - especially on large refactoring, new features or algorithms. Thanks, Liam