From: "Michal Koutný" <mkoutny@suse.com>
To: Chen Ridong <chenridong@huaweicloud.com>
Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev,
shakeel.butt@linux.dev, muchun.song@linux.dev,
akpm@linux-foundation.org, axelrasmussen@google.com,
yuanchu@google.com, weixugc@google.com, david@kernel.org,
zhengqi.arch@bytedance.com, lorenzo.stoakes@oracle.com,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, lujialin4@huawei.com
Subject: Re: [PATCH -next v3 2/2] memcg: remove mem_cgroup_size()
Date: Tue, 16 Dec 2025 14:55:43 +0100 [thread overview]
Message-ID: <6wm77ncacitv7fb2nc7sshpjjqshsh4xffey4qxhzu6oz4gevl@qehhysirzyhq> (raw)
In-Reply-To: <476fcde5-d54d-4b15-9870-844b3b8c700a@huaweicloud.com>
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
On Tue, Dec 16, 2025 at 08:34:40PM +0800, Chen Ridong <chenridong@huaweicloud.com> wrote:
> In my v2 patch, I was reading the usage directly:
>
> + unsigned long usage = page_counter_read(&memcg->memory);
>
> This works fine when CONFIG_MEMCG=y, but fails to compile when memory cgroups are disabled. To
> handle this, I initially added #ifdef CONFIG_MEMCG guards.
Ah, !CONFIG_MEMCG, I get it now. Sorry for the noise.
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]
prev parent reply other threads:[~2025-12-16 13:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 1:30 [PATCH -next v3 0/2] memcg cleanups Chen Ridong
2025-12-11 1:30 ` [PATCH -next v3 1/2] memcg: move mem_cgroup_usage memcontrol-v1.c Chen Ridong
2025-12-12 0:36 ` Shakeel Butt
2025-12-15 16:28 ` Michal Koutný
2025-12-11 1:30 ` [PATCH -next v3 2/2] memcg: remove mem_cgroup_size() Chen Ridong
2025-12-11 2:58 ` Johannes Weiner
2025-12-11 10:48 ` Michal Hocko
2025-12-12 0:37 ` Shakeel Butt
2025-12-15 16:28 ` Michal Koutný
2025-12-16 12:34 ` Chen Ridong
2025-12-16 13:55 ` Michal Koutný [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6wm77ncacitv7fb2nc7sshpjjqshsh4xffey4qxhzu6oz4gevl@qehhysirzyhq \
--to=mkoutny@suse.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huaweicloud.com \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lujialin4@huawei.com \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox