From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97EDC3DA45 for ; Thu, 11 Jul 2024 15:59:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 714F96B0095; Thu, 11 Jul 2024 11:59:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EB526B0096; Thu, 11 Jul 2024 11:59:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53E4D6B0098; Thu, 11 Jul 2024 11:59:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 312826B0095 for ; Thu, 11 Jul 2024 11:59:57 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AD81B1A056A for ; Thu, 11 Jul 2024 15:59:56 +0000 (UTC) X-FDA: 82327932792.04.F90D732 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf24.hostedemail.com (Postfix) with ESMTP id 04A64180016 for ; Thu, 11 Jul 2024 15:59:52 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=nFhDw+we; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=PJx4ivRK; spf=pass (imf24.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720713577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ShDvrSd+viRNeBNU+FfjoOh2yPOx+MwVBfECN1HdLFc=; b=yF0FNzJHodcUYlT71Z3JM2Cbo3KINpjizwdwBkLWD7ytOez7TKuVYS9g9oH0q/BHuUrAmF d5ESMEUTJ+p1Cm8wdkpvjnXymRFWs2HqvLQzOviRdp9/EplilYd04+wucOFw40DSeF+Loq jjc5h6P+XfeN6OrCDSTrHni8u+FrWf8= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=nFhDw+we; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=PJx4ivRK; spf=pass (imf24.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1720713577; a=rsa-sha256; cv=pass; b=cVJ3wetmJz/nWAcmwpPxt6FUm5K30LVzhyXtOjrfDDn3JpUmDraPg7mQ1FDptNTieV4qsJ 6TXarlVioirED5B1ntw5c31YI9u6Z/PFuIDwHet+7LQ+zFyTepW2K4tsAi6U85WrCcRDik 67vLP6thQVlWtK4Yemhtgdjl5aEppqk= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46BFBZlF008221; Thu, 11 Jul 2024 15:59:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :content-transfer-encoding:in-reply-to:mime-version; s= corp-2023-11-20; bh=ShDvrSd+viRNeBNU+FfjoOh2yPOx+MwVBfECN1HdLFc=; b= nFhDw+wesxA97vWBSI6F4yOMsMqSIzMl17kJDLl8PoTPampHdM+5URTfqAUqmJya KRhP/OApoJn6E9UzTAd5y6AItqsgSiOYUsAooJ+nJn/ISZBg87JxUNHkSyUnAf6H UbXKI4bTdI8vR3o2hKoAmLi2kawIuST3ZyUwuqvEnwpOphgmCctoShkzshuK9+b7 aTXiCUbb01eiq7Irfa6wf+ICzGUJJxJCHMwqe44Ci/VkLQoudaT+fnZ09K7i4scd e6RJH8c9j8tBJV5xWUH4PbL3lacC14W2E6j9wgeGFhWfdIwe8Ej+nxRfGZ6Kp0Ea 8mYIIoMoxFVQEqdXJNlDMw== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 406wkya2wb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jul 2024 15:59:34 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 46BEcqXe030101; Thu, 11 Jul 2024 15:59:32 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 409vvbf8sc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jul 2024 15:59:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xzUL2fdxJAp2XWENB5yh/mwxBn7aWpZH5dWSqMiiAoD93JiyaMlwUfuyk7k4ouGH9pCAJVbVkKGqxLoVUszm9KLvhaHjMe8j0+WodxUBzOksyqH+dnH7hlZj4zsOkHBt4KSYjDJLnJtc73q+dDpV+Wa31/VQRGt2uP+Qg4jm4O6oAjYfV1vTIHtu91pnLa4CM4a6BKUfQwH8XSQKl4wGQBQ4LPQ2IhNWYleSFhtHWRBDf+2hCFdbO0MLjRoxdbRsmt4u2j5InT/kXdALYVkvHjPrBYB9pKuLljWoC0XLnRkW7W8CcWBFNmfiQXay5deHlZamzLLEf/zP7522DFZX5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ShDvrSd+viRNeBNU+FfjoOh2yPOx+MwVBfECN1HdLFc=; b=BN8Ew9Am/hkZU+siKIqejE8cFQnCG7zL011frD1EpbPkw3xJEit0jsru6njNwhW+sW2VDOf+uF+R5PJ2qMfFk/WkKI8iN+4U37ziw4t4GKNSItBBpWH+w3IB/iqI7we0S1ZTjNiqhTTzqWbeqVz2gcjfDQXJek0w7FwcOS5GnM9XfqJV993VuwOMrK9F5Wo8OUsl/O2F9GDUgdnXTZxhM3BBXb7b9cwNVCt2I/evUjp/AUvdsK36kCYlCArAwJGxNDJuc85jAJwhEcNsBrrGoGanpueXHfedGEqsHdwaHBty7Fw+/9xhHihZfYtuAQOlSy+SqcmghhfepGAxxNbZeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ShDvrSd+viRNeBNU+FfjoOh2yPOx+MwVBfECN1HdLFc=; b=PJx4ivRKdhNs2vPe3DmCOd4EjxwE8nbApppejKkyXUioznqJRHffDtXPhVk6nhJ//jm9iBS2ZuMHXQOhyF9IHwU7XM/CKmQJV9Dwe5SCssfomL0+Zij77FprwYeDdLE1GcCH0bZJdNn7B3DagvS0tEcqBG/+W0yjRKia263hHZs= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by BN0PR10MB4967.namprd10.prod.outlook.com (2603:10b6:408:123::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22; Thu, 11 Jul 2024 15:59:29 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%3]) with mapi id 15.20.7741.033; Thu, 11 Jul 2024 15:59:29 +0000 Date: Thu, 11 Jul 2024 11:59:25 -0400 From: "Liam R. Howlett" To: LEROY Christophe Cc: "linux-mm@kvack.org" , Andrew Morton , Suren Baghdasaryan , Vlastimil Babka , Lorenzo Stoakes , Matthew Wilcox , "sidhartha.kumar@oracle.com" , "Paul E . McKenney" , Bert Karwatzki , Jiri Olsa , "linux-kernel@vger.kernel.org" , Kees Cook , Dave Hansen , "linuxppc-dev@lists.ozlabs.org" , Dmitry Safonov , Michael Ellerman Subject: Re: [PATCH v4 17/21] mm/mmap: Drop arch_unmap() call from all archs Message-ID: <6vhuf2uuaibrmtb47tqf6qm6ckpsvmxgrh776wyrpd4ezccrnr@vdbv7msydynk> Mail-Followup-To: "Liam R. Howlett" , LEROY Christophe , "linux-mm@kvack.org" , Andrew Morton , Suren Baghdasaryan , Vlastimil Babka , Lorenzo Stoakes , Matthew Wilcox , "sidhartha.kumar@oracle.com" , "Paul E . McKenney" , Bert Karwatzki , Jiri Olsa , "linux-kernel@vger.kernel.org" , Kees Cook , Dave Hansen , "linuxppc-dev@lists.ozlabs.org" , Dmitry Safonov , Michael Ellerman References: <20240710192250.4114783-1-Liam.Howlett@oracle.com> <20240710192250.4114783-18-Liam.Howlett@oracle.com> <3843b797-8e31-498c-adff-153f9568505e@cs-soprasteria.com> <26f9353e-fe0e-4a2e-ae12-8021f0c7bf40@cs-soprasteria.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <26f9353e-fe0e-4a2e-ae12-8021f0c7bf40@cs-soprasteria.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT1P288CA0006.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01::19) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|BN0PR10MB4967:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e2167fe-1502-42a8-ade9-08dca1c2721b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?uG7RwWDC+2nYteS47tN19O8KWH/xKi7vqmO+nsGehBOj/qM5waUK1fZnyl?= =?iso-8859-1?Q?iqpuCBlbXqAnK1Aom8LEb1Z5+Xg4aWuwwO4zUHQpSJD/tihaSIbX09g/72?= =?iso-8859-1?Q?L0tOsHawac3Y0PJ++7GXUv/x9bgRjGfrvOWwF9CvXAuWf7aRCKKfadXhLd?= =?iso-8859-1?Q?eJZq9pAJm1m1FVyXkLf7LZ+sRuvDVUyWxrFezDSTgKJwLrmpTr3qlUw8wB?= =?iso-8859-1?Q?Ix4C5Q+RuckbWZZs6EbpTFcUGvdWybdaHY1KtlF0zW5S8LFSdK8uPVr1fe?= =?iso-8859-1?Q?epMYkqb1Pzw+R+o7N8YlNBLMZCYuZ9y7Z3Y+r8aFj6kVjDRnAY+BTKgaVl?= =?iso-8859-1?Q?GFmBWL7uPAgoN2jc1dPecRBIuORQgdzbKJcr7j3b4HYhxvy3o48Cg3+Kyb?= =?iso-8859-1?Q?s2Jhz6vrwjDE+jixWj7rI1esuumvO+SgUd50TjPnzPs35IslJSteC+HXYG?= =?iso-8859-1?Q?1TMIfugVSN4Gs9CSky4yNhdpqmp8/VF+hELSe7emT11mJkYferftU3kPFK?= =?iso-8859-1?Q?dDu/edMZBLyvWvFKtsHMoLgZu71mqF8PD8dFAhfpdbNU8vhoP7auhmvWts?= =?iso-8859-1?Q?lF1uTJOWD9f9KDpAgYtt5voIP02ew35daG16HNQlExz8bhsLUNRXjqxH1r?= =?iso-8859-1?Q?Wnf4x5jhs1qvtIjXWfLviW1S7gFPygjwpMHucLIMpuMw/E+E1sPnnes3d3?= =?iso-8859-1?Q?Z1sggAE/0nGxIXU+mUqbb+YH6BeZXQDS6WRQXu++OiA2LL9brYb/l2SZ53?= =?iso-8859-1?Q?RHLoapbT3NxvKsCWYmyacWEHIKyH1a3isvN1WtmdG1AY8SQxKNWnSHtYVg?= =?iso-8859-1?Q?gaLdJZBo2UddKv6EKKUXLTSVEPgqUBLCEEcO2CeryVPHtWM7XaxYPvP4zo?= =?iso-8859-1?Q?aBEl5tEiKATcdTa2UrQjKaMU/hrtJZeyhO5+JK0sRqEwLTgD1yPQxhRwVu?= =?iso-8859-1?Q?SjZj1wDqc566HubrW2g94KAOnJXp/i08I8KMZn23ITiKEKbELnUmNgBBIY?= =?iso-8859-1?Q?lIzJNLc+wf+rZH+Sj0bz4yjHcmfPpm2PO6vlgMpOzrklNY+dE3Mgv9tnDV?= =?iso-8859-1?Q?xn+tFiy1tvhfcy5Lu8vwRql51s6MEW/D7nrNzjwHFTvGSmSFns18OVE/+f?= =?iso-8859-1?Q?DpuJm8+NEAwwkFY82ZRx1Vt+pU0ciVrP12lVhHRVET5EchUO1V89eyix8S?= =?iso-8859-1?Q?7dAxNYjw1K5ye2SbFsDRFgM3PYQl4mP+oEv8mnbj0TGmioAg7fP97mI9VC?= =?iso-8859-1?Q?4pzO6+bz5P7XFjz+Ne5gdqfoqdSWXhBYS2w4rDyuBTEzNo6xDeLwv9n5Lu?= =?iso-8859-1?Q?RTFCiF8F4ckGSOxsApbmeRy5vi7Cz1AjMFm8uoyDCKbsFUI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?0p0ZPwDLeIzQaR5SqIxF37HbnzbQAkIy4wpvfDQSjtgWsHJf9yppfJ2trQ?= =?iso-8859-1?Q?rWvHHr3UiCmKjtoPZ0IsqvvVY1vK43j+nVQDVOJYSYa79zGswpINHpq3+y?= =?iso-8859-1?Q?+FKqC5IveUoVOxlwDZWK5UOc6Mu9IW4nGhUAtFNlp0u0fFn/WnbxyRqVBI?= =?iso-8859-1?Q?53SfPcoPgiGm5RNFWtYpMnU3i6V2T4PDHRFVWkJnfpOXKs6ypyZ6BGLBy0?= =?iso-8859-1?Q?y0mvF67mA8ITmPtf9mctwU0ybCSQkDvLuie+SSp0mnJwMo6ehqMWB+1Jxj?= =?iso-8859-1?Q?MdGngPEehz8d1Dz5P0kCegpf+ckHcvo0qC9LHFAp13kYWMMGHThcR6Mg6e?= =?iso-8859-1?Q?D1McX9bsva5eAkZr7RpQq0qEBsxaEYZ2UI0/dwWkeHxkyumdFj6gQ/tGBd?= =?iso-8859-1?Q?dIBVlBa0Q89tYwktuLF+g0w2lNnpti6r8bYD1/px66SCzJ6NrfaIHKUDDZ?= =?iso-8859-1?Q?JR9TXqTZWjvUIfvbR6A8W+EdHQ+chxbazOILJ0V31noOj/PJCMw3poB1m9?= =?iso-8859-1?Q?Q/W1rR0CBBcrXrYSx9QKZBkWuz2H4peTrkiIvury/tHaQuA9g0klURVDgN?= =?iso-8859-1?Q?KRCp9IkdiCgu42+wnc3kvLxz7IiorCuZSqG/+nZ/649zZvfPBLFcseP5ww?= =?iso-8859-1?Q?Kh+P+dDUhAEoa7weRxNXo0MZ0APUzm6chu3PKgyJyI+x3DboYeLksOhukI?= =?iso-8859-1?Q?f+AuJPK9d1QXQlNgCCo4f0KmGGYkvtVMZu6bc7FtkmjZaz1bIrBaPPceyW?= =?iso-8859-1?Q?rZ8ynZ6INyttxtMSS7yi6kVmlrzwbvpRSJWxmKh8/9S/jPOVlmMxOZZFc/?= =?iso-8859-1?Q?9xd8P2owpeaeCmUO5VHX0kYpP7lHtcj4SDL5twzMq4COHpNFl+XMK/L6v7?= =?iso-8859-1?Q?XYJx/6K9LsidB3YQV+wMAqS4cIiP3PHrexN70Lhh6UGYhQYn9JAq3hN7x/?= =?iso-8859-1?Q?442xxvmFXNzUX6tLri2gjmuQx5FRdexkkzS4eZ2i9dLE0Lca33TryAz0P8?= =?iso-8859-1?Q?Kk84n0l2e39J2LxcKZCISsTFhXWP+C0IYKTNx+VrCTn7oyN4MJdCWNo/XI?= =?iso-8859-1?Q?e2oCNkSiAkrz8FY/flw0lGm+Tg3BJ+uQ2Z4rNKTvq/ePEGv4WdthsiN2ka?= =?iso-8859-1?Q?Rs9o2dekWm3zD7C5QW2VHdbYOpmIfXHd3oRNoLcZsrUcP7RrR9z2xWhBCd?= =?iso-8859-1?Q?QdMUoG/H8xsTAjbag9bex5Wvvqbvx+2NqeUxGCH9wZq8I2kCxT0Ky5FQ5K?= =?iso-8859-1?Q?bKSdlNJM6vBG4YXhxXqDPWrWMVa2I6IFPAbfwKP0kXOh4srIjxR12VIsAL?= =?iso-8859-1?Q?SbTKZS6rwtfOcmKDpwhp0rDeAyzDNciTWRUoytOV+MvNed0hrH0xgcIPhI?= =?iso-8859-1?Q?LkAkJknOWZoGp6tpXvtWGvfksbLgGZlnfFlX2FsB103swO90lhtWI54tDZ?= =?iso-8859-1?Q?53Yvs3mpIoUlaMmbIp2jGD0yfSgm8qmhlP+XgmjViTiz1T0KWZ5LuGBO9H?= =?iso-8859-1?Q?H62SgLG4x80j9ZeI4yKu+HjLo5jk72WvymFfNBwtfGgmWaAIJKrfGenFJi?= =?iso-8859-1?Q?uYLTSLCHLwqCOy4CiRmhmmGhxQBEXQMU6qttlPxS3EnLFJ5DwtmoGMkNmS?= =?iso-8859-1?Q?AXgARPbxX+dvvdhM026rH2lLeqwiNCmj9uupGdYAolLmcaU0FoWSuN/Q?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: GkF3YaMZcpJ5JDzDK+QTcLU80Ff1lpQYoxksWLxcxH6VWnsQTWtJz2/VmgyU9tGKe77EFerorvvZzpDMh0H7AVS753U8Q4zaR6dt+Ku+0y99lUi9gRwk9QpO1qVmnOOQ/R3oyA5gWnd2bx7FbS1toeldTjk/Gip8+0ATH3yqYhQhuk9RHKviNIfDhELf8lkKS+FUYzkrRwsKuWKvvn56vAglLf3e5Q6dVKJ5H0sSnZFs4d3AjWXAK83SsuPoBKFEk3vncQLezgXUi+r43Cow6VRmiYsRFPm7/N+vPJ0NisCI1UMdGCvHBBT392U+6XvIwIqY6kDRBuGH1OI4DqAZcvzUSHMGephm/FBI8MyJ/8YxXgcV66FKu/LVhAMo+jw8xBL+L1xCntRmi/G+EHd2mL6rxOxngaeZFcvKby+oyV0ZvOAVDDLCRbHHyw7+QANDY8GckOFcHfRPIJPjiwWEMAtnfmyW7N2wO9xFNSVGDjc/OVJCyk8DgaRplQVjnjOqnPm5U6aMluETFJjL8x26WiIcoYgTC6MrKHTpZRvtKaw4C1S35Rcr0vL0myS87EJWC+e6PTnz8F7OSMahC/OvZE1+a9AEN4nMQmJsDyFM4RE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e2167fe-1502-42a8-ade9-08dca1c2721b X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2024 15:59:29.1538 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ePdDkduIIz4StVh+VaUUscdB3fZ7tI23iph1wTZTvgJV9bMq5eDKkzAcr8LDSvcT3LflZ01bOh76BrnFqh7vlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4967 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-11_11,2024-07-11_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2406180000 definitions=main-2407110111 X-Proofpoint-ORIG-GUID: mQTLj6X0JrXz-bWitmVbYFgHAd1JQckY X-Proofpoint-GUID: mQTLj6X0JrXz-bWitmVbYFgHAd1JQckY X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 04A64180016 X-Stat-Signature: rrt44i3uyemrjwzcdzz7xy7c933z67tr X-HE-Tag: 1720713592-116809 X-HE-Meta: U2FsdGVkX1/U8R27de/x4o/XUrfJMEDhxraOabJPbA2HuEWCifRL7Un1kTn6FAKt6tB5BgWIQ8Sqc4p90U53ljM4zZbcc4AU7WKyCKCN618ccHmZh9yLFACPMujOkxLBaxXL4SLP5IQqtD49ioqhKs2dnlqVy2nKtbtmrMk30Zdofc/Be7UiOiSRV1WuVvRIVbVO8uueWLSp2TtCm5W8z7cbdg8sZn+aKk2l1ueIyWmay7RydrydkTaiJ5M2afrE8sVzNqxupJp7wlGYeQTsx9E22+ExQClSs6ml1UKrko0iYwdo62fFmh+No2dtRIsqlWWwbDxX2FcPACm2xYiVxMuH/3lxd/+3h43Lf5Aq2eB6J67UJD+s7d1duoen+dDfJXSRBLszQELH4K2l/0wiPbh7mCBtVj0cC9UrmSzPNOZr1oysVSfSYjbCDGze86zPzLnCpS0tIrJ4CPeZFTolxhVA9oKdRASx5xXQc9pNChbeWBUnsVMNFWF3Gb6ktlx8eErESuI3yp28wH7HJBk1yJaUJXwrSzFMBqVCCj7Ay5ktFIZI+FuQn2N7r3lXhrkycSBIGp3UoP/iIfl2paoNYpSDbmzf3j71zSqpzPX95VSWBxKmmz/e9UNzEBc6fdVl2SCqcot6TX2W4VFRZCVFsrpRp/66tnXU2whPeKFxjLcEIW3NszBgZfLWxT6LI/6N8yH3efx9AB+5XURsyxbbxIBWr/W4zOkYQjDGbqtBOKo0D8S5css1S0vt7ZxODJG05LoR3kohoOn8qXGDUwMpKzEcNk1YMEQMd59aRA58/7d+7YVLOpvpxZxXUrsg2cEW+aLhemLxdHXS4jam/USwwtJXnQFnfWbMOH6OkmSOH2xnmsXITv837sVQrWMxVQPZn7YbFDGg4CWMOwdRw7SSkBfFg/5eMl88Ug3E7PbV4VklWREMIl9GeRLWZMBwclWieFMlyzwZbyV3OFAWy2O 1sghttfO YNmuCIC/1uqvspkPDqUMsSHnzEXRqEE3FfMXDI81aMXrp2B8fCk3JZfsAoKJ9xUx/dohZmJMpVPAFSBoOkyMO/1eqCH32KgBYLHnIiwOF6T25412WDh5MinmIVvZBY62FA6DbcRZA8rl+6kGD6cX+jjKP5+heDCEmWYUKeBzzoxXwt+dL8j6n+cIaD8Fuu39OGoL0SGLjXkAOytaVtLqifF/zBRdKxcedgljym2al/bhVoQKwKPxADmflC26ZpnBkOe8Hak99sXkg0kGLK0XqDEA1GZwjvFrOgVZ1RLbcovZ2sipwF8bnkEN5oEBql6GTsB7eRXyER0VEGCx+oHrzvIMgoeDgDWcMJNDEsoxQ5tcLt1TrPLR7G5hHQicTvoTE7k5g8OG+Xhe7xnrrmoOVkW84xwOW94Jm70u69jo0RhWyWMq4SsLuQqNGwQrBdQSBBb5VE3Wc2J3+c82XSpFnrdCJuCsbeSH3RJlYPu1BjQ+la+r09kmlLjkb4CXzB50NPX1080klPLhhdCWe1pKA4aY1+NccW3QoTJl/pxQZ2YjDC/LLAz0xUP2nqMsDnVYsNlpoK8D3Fy+pO720WnJ1wBbNQ7oX9cPXgFChlYdKe/frJSrm/Ib5B//poo2H+gfmWXry X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * LEROY Christophe [240711 04:28]: >=20 >=20 > Le 11/07/2024 =E0 01:26, Liam R. Howlett a =E9crit : > > * LEROY Christophe [240710 17:02= ]: > >> > >> > >> Le 10/07/2024 =E0 21:22, Liam R. Howlett a =E9crit : > >>> From: "Liam R. Howlett" > >>> > >>> The arch_unmap call was previously moved above the rbtree modificatio= ns > >>> in commit 5a28fc94c914 ("x86/mpx, mm/core: Fix recursive munmap() > >>> corruption"). The move was motivated by an issue with calling > >>> arch_unmap() after the rbtree was modified. > >>> > >>> Since the above commit, mpx was dropped from the kernel in 45fc24e89b= 7c > >>> ("x86/mpx: remove MPX from arch/x86"), so the motivation for calling > >>> arch_unmap() prior to modifying the vma tree no longer exists > >>> (regardless of rbtree or maple tree implementations). > >>> > >>> Furthermore, the powerpc implementation is also no longer needed as p= er > >>> [1] and [2]. So the arch_unmap() function can be completely removed. > >> > >> I'm not sure to understand. Is it replaced by something else ? > >> We wanted to get rid of arch_unmap() but it was supposed to be replace= d > >> by some core function because the functionnality itself is still > >> required and indeed all the discussion around [2] demonstrated that no= t > >> only powerpc but at least arm and probably others needed to properly > >> clean-up reference to VDSO mappings on unmapping. > >> > >> So as mentioned by Michael you can't just drop that without replacing = it > >> by something else. We need the VDSO signal handling to properly fallba= ck > >> on stack-based trampoline when the VDSO trampoline gets mapped out. > > > > I'll address this after the part I missed.. >=20 > After ? What do you mean ? It needs to be addressed _before_ removing > arch_unmap() After the later comments in this email, sorry that wasn't clear. >=20 > > > >> > >> Or did I miss something ? > >> > > > > I think I missed something in regards to what you need in ppc. >=20 > It is not only powerpc. Powerpc is the only one doing it at the moment > but investigation has demonstrated that other architectures are affected. >=20 > > > > From what I understand, other platforms still map and use the vdso > > (context.vdso is set), but unmap_arch() does nothing. It is only the > > powerpc version that clears the vdso pointer if it is unmapped. >=20 > Yes on powerpc it works. On other platforms like arm it segfaults so it > should be fixed > (https://lore.kernel.org/lkml/87imd5h5kb.fsf@mpe.ellerman.id.au/) >=20 > Could be fixed by properly implementing arch_unmap() on every arch, or > carry-on with Dmitry's series. Okay, I understand what you are saying now. I'm not going to tackle that change within this series, so I'll just relocate the arch_munmap() back to where it was, after the removal of the vmas in v5. > I think you fully understand that it doesn't work as it is except on > powerpc. Again the goal should be to make it work on all architectures. Got it, thanks for clarifying. Regards, Liam