From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2982DC369B1 for ; Wed, 16 Apr 2025 09:38:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EB4B2800FD; Wed, 16 Apr 2025 05:38:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67EE22800D9; Wed, 16 Apr 2025 05:38:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EEE72800FD; Wed, 16 Apr 2025 05:38:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2A8B52800D9 for ; Wed, 16 Apr 2025 05:38:53 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1B98A14042B for ; Wed, 16 Apr 2025 09:38:55 +0000 (UTC) X-FDA: 83339407830.01.8A2F23D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id 0189F80008 for ; Wed, 16 Apr 2025 09:38:52 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nrhdX0ES; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/9ERkXod"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nrhdX0ES; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/9ERkXod"; spf=pass (imf30.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744796333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CwKUhCev7DSKFNU9JiOO8wb+m3mv7Nt4AZi2zzinDyg=; b=2TUfAZF4vluVPY7tpfKK6WIaheY8oFmZAQSmcw6G9zd5f8BnFl9lplbxy5ngZW1wrRBjZM RZ760gs1dBT5IcmkfE9YEz/g5AUCRRRX+RjiG84b4SwreYZsNOuk/VYFIdIMpWfr5YlB5L Cc4fGI/u9vjMl2i+XTk0X/c9ee6UIIE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nrhdX0ES; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/9ERkXod"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nrhdX0ES; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/9ERkXod"; spf=pass (imf30.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744796333; a=rsa-sha256; cv=none; b=mUBK9qSoMGbimEUn+oPSmunOUhNKohIycjOcp1go7Z15q5KH50HN/NyhuFsXcIwSh2qrW6 2AI2KKvUKCGMvTBBj8dfJVuxA7doTiLuppI7nkRiUUPyegw4ukAw7yGQJlQoSCSuvTxiS8 QTWKoVl5B6YM3KKOeBsSwc6TJGuSMP0= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7DE71211A0; Wed, 16 Apr 2025 09:38:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744796331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CwKUhCev7DSKFNU9JiOO8wb+m3mv7Nt4AZi2zzinDyg=; b=nrhdX0ESmLpdFEDz0p6S15Mz8CwUJZAdLfavK+9DmTl1EzSGF9N368QETp5U+zeIrskSNc A9H9BMiXQrTbAzj4z2MOh7qNWErM0aQMVE+5qCVbyxmIGew/cO8qmrPTDCxWNdrEK0Vrk2 QrHBYwru8V3io81WwyG2xZNtphfnn1c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744796331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CwKUhCev7DSKFNU9JiOO8wb+m3mv7Nt4AZi2zzinDyg=; b=/9ERkXodQS8u3ZM1bEVenxcco9BRDYLaEZUJvY1gHECJKeIU9Cxr9lsEUlg/u1aRmIf7Ff yRqSOUWsLWq5hMAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744796331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CwKUhCev7DSKFNU9JiOO8wb+m3mv7Nt4AZi2zzinDyg=; b=nrhdX0ESmLpdFEDz0p6S15Mz8CwUJZAdLfavK+9DmTl1EzSGF9N368QETp5U+zeIrskSNc A9H9BMiXQrTbAzj4z2MOh7qNWErM0aQMVE+5qCVbyxmIGew/cO8qmrPTDCxWNdrEK0Vrk2 QrHBYwru8V3io81WwyG2xZNtphfnn1c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744796331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CwKUhCev7DSKFNU9JiOO8wb+m3mv7Nt4AZi2zzinDyg=; b=/9ERkXodQS8u3ZM1bEVenxcco9BRDYLaEZUJvY1gHECJKeIU9Cxr9lsEUlg/u1aRmIf7Ff yRqSOUWsLWq5hMAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7360B13976; Wed, 16 Apr 2025 09:38:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id I80uHKt6/2cvdQAAD6G6ig (envelope-from ); Wed, 16 Apr 2025 09:38:51 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 37F83A0947; Wed, 16 Apr 2025 11:38:47 +0200 (CEST) Date: Wed, 16 Apr 2025 11:38:47 +0200 From: Jan Kara To: Davidlohr Bueso Cc: jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, brauner@kernel.org, mcgrof@kernel.org, willy@infradead.org, hare@suse.de, djwong@kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5/7] fs/jbd2: use sleeping version of __find_get_block() Message-ID: <6tqny4muvkyejvokjkx6gh53ihc2duxleonzwqlkl6hn7y6w7n@r3x6dns3q6pn> References: <20250415231635.83960-1-dave@stgolabs.net> <20250415231635.83960-6-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415231635.83960-6-dave@stgolabs.net> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0189F80008 X-Stat-Signature: azfgtoignkftsm3ipy469wsno6towcz4 X-HE-Tag: 1744796332-624107 X-HE-Meta: U2FsdGVkX19hNe58Det+7md5Bmxzh2FO2/rf1vo1/wmb6Mg7Gro1nCNTPQpomtb6JB9uTkOu+jClXU0r7dWIdzYRO29styl3LNdwTWzR4ujrnOnkeOYDVux5vwNQmJw3zFyFX8RJp/yEQgNEeYDcPU5hVczxTROxb52VA6798SSG0h9uKjLcf9kI3Fy7rY3dIctBV387+WoHhgSYOQnch8N1VSJ6Cz1eEqx/U+xKkJ86opQQYiMOzO1FoLr7iOJYoUiC9foQNYZr76N4HcPIRXFOcOx4tdLr8uQjsZwYOoVTBSPjeDX+EHk+jMvLEUxE7m1vNbGf0cPbQk4rzKKkW22bKAirKpzVRerlPe/oxCv+WOKbOg9mKZyrftHrgQeT8BoqVCxrF0kmsQPKIu3idBfk8mWCZZ1zFtP+SQecgoq0g6O9EcnvJaQG8Mbz0Rotl/U4neDEuGVtVO5icvszzkRQrJD1KBawX91fu1fIys9iQiI1bZtwi1ASjrmouKNpvk1yTPIodb034D2sZlFyRnfQJ0SkCyY3LYzNAXVCCJL7Smu5k5T5deagif5aC+DjyBfNH6djc7Ra3aCltqiXJHKbeV9Una9sfvrDH7qapKQWHWc3VoYv8dNhG8f5eyKgLnNNz2Xk6g1GaESsyQiq8zy9qIttMo0an0YpvzT5pqV9K5xavwmk/G3LuWDuloSwtfAMAJ5sz/CvDgG3U8JhO/+Gy+gwA43juBM9f98CzFgAy3oHHYUTx1IGiG91qMWF0Z7GYwMQVlSIj2YQtDmekyVxTeq7gbXq+BJsLk9TwFMy+TRWRBPqek4znQlwm+ZlWEgE9PQ4DNiovTDpLj45OXJi2j2IE5ZKXvMymoVrM80ld99QyEy8qLoU5pwWG+8aEOJv7vbhdA/tOIM3qHyKl811gTKdqGCHpQ/vTxHC20OMhrc45JnigPuBRX/8QXBBMA5cflhXG80BStrEgp/ r3wa0Sl1 ZPf7e X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 15-04-25 16:16:33, Davidlohr Bueso wrote: > Convert to the new nonatomic flavor to benefit from potential > performance benefits and adapt in the future vs migration such > that semantics are kept. > > - jbd2_journal_revoke(): can sleep (has might_sleep() in the beginning) > > - jbd2_journal_cancel_revoke(): only used from do_get_write_access() and > do_get_create_access() which do sleep. So can sleep. > > - jbd2_clear_buffer_revoked_flags() - only called from journal commit code > which sleeps. So can sleep. > > Suggested-by: Jan Kara > Signed-off-by: Davidlohr Bueso Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/jbd2/revoke.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/fs/jbd2/revoke.c b/fs/jbd2/revoke.c > index 0cf0fddbee81..1467f6790747 100644 > --- a/fs/jbd2/revoke.c > +++ b/fs/jbd2/revoke.c > @@ -345,7 +345,8 @@ int jbd2_journal_revoke(handle_t *handle, unsigned long long blocknr, > bh = bh_in; > > if (!bh) { > - bh = __find_get_block(bdev, blocknr, journal->j_blocksize); > + bh = __find_get_block_nonatomic(bdev, blocknr, > + journal->j_blocksize); > if (bh) > BUFFER_TRACE(bh, "found on hash"); > } > @@ -355,7 +356,8 @@ int jbd2_journal_revoke(handle_t *handle, unsigned long long blocknr, > > /* If there is a different buffer_head lying around in > * memory anywhere... */ > - bh2 = __find_get_block(bdev, blocknr, journal->j_blocksize); > + bh2 = __find_get_block_nonatomic(bdev, blocknr, > + journal->j_blocksize); > if (bh2) { > /* ... and it has RevokeValid status... */ > if (bh2 != bh && buffer_revokevalid(bh2)) > @@ -464,7 +466,8 @@ void jbd2_journal_cancel_revoke(handle_t *handle, struct journal_head *jh) > * state machine will get very upset later on. */ > if (need_cancel) { > struct buffer_head *bh2; > - bh2 = __find_get_block(bh->b_bdev, bh->b_blocknr, bh->b_size); > + bh2 = __find_get_block_nonatomic(bh->b_bdev, bh->b_blocknr, > + bh->b_size); > if (bh2) { > if (bh2 != bh) > clear_buffer_revoked(bh2); > @@ -492,9 +495,9 @@ void jbd2_clear_buffer_revoked_flags(journal_t *journal) > struct jbd2_revoke_record_s *record; > struct buffer_head *bh; > record = (struct jbd2_revoke_record_s *)list_entry; > - bh = __find_get_block(journal->j_fs_dev, > - record->blocknr, > - journal->j_blocksize); > + bh = __find_get_block_nonatomic(journal->j_fs_dev, > + record->blocknr, > + journal->j_blocksize); > if (bh) { > clear_buffer_revoked(bh); > __brelse(bh); > -- > 2.39.5 > -- Jan Kara SUSE Labs, CR