From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A37A4C83F3F for ; Mon, 4 Sep 2023 15:29:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE6938D000A; Mon, 4 Sep 2023 11:29:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B96778D0001; Mon, 4 Sep 2023 11:29:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5F818D000A; Mon, 4 Sep 2023 11:29:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 937868D0001 for ; Mon, 4 Sep 2023 11:29:20 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6F6701CA1C3 for ; Mon, 4 Sep 2023 15:29:20 +0000 (UTC) X-FDA: 81199298880.14.A0C57CF Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf26.hostedemail.com (Postfix) with ESMTP id 80BD1140010 for ; Mon, 4 Sep 2023 15:29:18 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="j299Sc/T"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf26.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693841358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dJLufghybCMa24PDpvfycL/ikAXyEs0VewOCLgkv2eg=; b=AaZrNhmNW6TbNTpHvbp1QMFvxvNXMnuuSC/dMM65E+hjUa5CkIXlNWjYRi+D7MohecA8Qa Ay808hqLI8nSgCmoVXKu1ocqq+zhs8Blwv7HmI842N00yAn2qPXUhbpCnvDGgAl/rP+sWT AOPN4v9ZycSi5CYJu5ylCQdoXE6rzIE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="j299Sc/T"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf26.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693841358; a=rsa-sha256; cv=none; b=PNAa/qLOj+S6wv8oyTHZWETIsdY/T4ly1pamBZAX6bu5KRkZbbXQYra7IqFfWE4F1qNE+6 /5a1uyGOrB9YQD+ft+tubwAcrpAzvjnL5JU3ihQVDzDbOnL/LW76dHpFBS/Iixu480wzid FGwp5oIRqhBUaHIT3fz553QlsA+q7q0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 45CBB1F74D; Mon, 4 Sep 2023 15:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1693841356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dJLufghybCMa24PDpvfycL/ikAXyEs0VewOCLgkv2eg=; b=j299Sc/TsT+nZFscMydQEj2Gnb7vTxcXBX03rHpI6p62mNFZ0JNS37/wHT+lxSh8I4HRio T7WshfgDW2/PHpCAFYArzL5GQ/X6MIYbfmkqyng04a5RByI7GD2aQt+OrG4IbPK7KD9Wl4 qrNllUW9brGOnw5F/f9Q580XqOYnNUk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0D10013585; Mon, 4 Sep 2023 15:29:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CCljAsz39WTNTgAAMHmgww (envelope-from ); Mon, 04 Sep 2023 15:29:16 +0000 Date: Mon, 4 Sep 2023 17:29:14 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Michal Hocko Cc: Yosry Ahmed , Andrew Morton , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Ivan Babrou , Tejun Heo , Waiman Long , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/4] mm: memcg: let non-unified root stats flushes help unified flushes Message-ID: <6tne52ip62ucev7nmnim3m7fhcydnwcytyxynrlxxgaf4cbqea@r4hec425izap> References: <20230831165611.2610118-1-yosryahmed@google.com> <20230831165611.2610118-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="syrk2v4vngqj4sdi" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 80BD1140010 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: btqd8wd4m53m511k4ub3xfqrne5pbyyi X-HE-Tag: 1693841358-241884 X-HE-Meta: U2FsdGVkX1/m/TS3H1baKedKNCXzkxuS8Phnl0guQEmy4bWgH9mnnW0xmjTkm6zCVbva8yagXcOX/jr1j85Wc4EaA0JPgre7yYZiOiCwNKwJH3X3p/pFkz5O10+PKE+iRs8EiKXqIU0zujEZ3e1owASYTRgfGYw2IJ/sCivNdOD3/w/Ofeg7Zf43iAuBSioPu2Y9fr2LncdE9+KlHvDbsUCzlOGrczHKf62eKZt0JMn1tsjp5m/pILJXq61Ft0Je2dCHEZE3SCBDIPjeOEB5dytrYKCFdrnmILM8q8qJ5jCcsavozPzxUmIUsQVmtjhYPQkpuAXSfwE2oOxo3lk6lYsda9GW/hRyhBbv7Ml+rx+zhn4v9fApk7POiXQE0r8kC5dZx8xnRPNQ8nmNYr1z7J4yL8AEwXf5SkO8qFuuEH2M473brP51TMa3knWpZLA9N22BCr7B9Ov8k03VCzv20b8VspZ91LwFK++Jx5Q1BWVGt/8BwYkAvkGoQMbnrJdKvgpjPDIdaoL9+yO2kXDdEq9LMktM33Gdlq+vEHt70rRIfYcZaJq7OfmyMvi0xudLAjZ5cs6gvs1hI8XZZX0GZW5uxCePN9xIY50fXW9C3tdEWGJCv7c4v+YHvB8qhmiWyCQzhbMy/VfNk2jE4kNQQ0W3z+i4Dsi0jd7VFewpxmUITV+5bUJYn6uDVbqIk25yWVbj57LwuOdXrstWkbH78GfR1CODvhJ/nbtMJO1tPxtp+aHnlnLW+hgewx5MGDYYNAR6cqGKImqoVBJGFWi9Ar3/ZjAUMBpey26zOrndbtj52vsR/bMg7vCQ23fd50HFNqL4Sq98fGs5qbr7rMzwmUo3OcWyF4h30LynewaNgKG51DaUttWbCrvC6BZocAC4iw9VLHEXbK39CUcBcSpHNXe4dB9bdl69B2UcY94SdBga6HFVoso2oh+BKnTWH0Sdf/0MI9TAO7I2l35v0gC Q5IQNe1e nDF7KfQ55DCO8DRa4S3q8dL5r7PinSk0IXsfHvph79D+cVDDN0d65c515Qbe/Z3JiRntBhmRUrYmdwOD2m3KwWYBMOQn6sY0peTQYKDX1T1ToK1AQNYS3Mo5juCyNGnYZFavxHJcOTBo/UABQwyjOIgORelAmt5AIAtv9wCKf4FxY7Y856afLVnGh8BQM459fntFOMPn/sI8D+N58Sujc5YfejPyVaFLK42UHIUQDLKhb4zrpmOERwnecpEVCvXA97iW8n67r3GQ+vRBzVDiObi54AQobtrgUsYJ1wMbEmwh9D2l54ebKxfhkkXrUaBH/phGSVIGoX61udt0AYgE+SOjdCRB+HiuebxrcDk4jB9CtyEHBCEf+NzTtD89Ru4MUBiw2Q3vZsbxdPeE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --syrk2v4vngqj4sdi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello. On Mon, Sep 04, 2023 at 04:50:15PM +0200, Michal Hocko wrote: > I have hard time to follow why we really want/need this. Does this cause > any observable changes to the behavior? Behavior change depends on how much userspace triggers the root memcg flush, from nothing to effectively offloading flushing to userspace tasks. (Theory^^^) It keeps stats_flush_threshold up to date representing global error estimate so that error-tolerant readers may save their time and it keeps the reasoning about the stats_flush_threshold effect simple. Michal --syrk2v4vngqj4sdi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZPX3wwAKCRAGvrMr/1gc jrH9AQDraTQKzMHznCeTIWsFz0m6SziVQ0WMnHb90hQ5OGjzQQD/dPHTWpaxgO+S ff5xBhybWn1PrJqNeXXnqzuYpF1d/gA= =ACcJ -----END PGP SIGNATURE----- --syrk2v4vngqj4sdi--