From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBE1DC282D0 for ; Fri, 7 Mar 2025 05:19:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC81E280002; Fri, 7 Mar 2025 00:19:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E7763280001; Fri, 7 Mar 2025 00:19:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3F78280002; Fri, 7 Mar 2025 00:19:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B6260280001 for ; Fri, 7 Mar 2025 00:19:30 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E5EECA48D4 for ; Fri, 7 Mar 2025 05:19:31 +0000 (UTC) X-FDA: 83193602142.28.46958C9 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf30.hostedemail.com (Postfix) with ESMTP id E18FA8000B for ; Fri, 7 Mar 2025 05:19:29 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=lVyEDez5; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741324770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I41lBq1Kk3lA1enOkQsq9Bf6kp48L0kLMkvHsbpE3h8=; b=WUW+zggqjND3oCBLRnet2XiC9Hrc5SbzWU0BmPY8Or6Pw1rKUKJyPf4EqjKHTbXSm1jTXF Ek/a5Hv5US0tDMOViTzUbR/sYN/5c15lSDKX5qKFQZiyBSFobj3R8hzb/+33uFJc7w4eNG RAGn14sOyqa5Oqxn4jKFsR187xz2sgw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=lVyEDez5; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741324770; a=rsa-sha256; cv=none; b=1ZPrQHBXXfLzwgg0xFJTLHlIQYnJsT4Ff1FkIErPByeiCQwGxl60S7DpQQOYaw/GIOoEqJ GOEoqXFKDS0giJ9mn8ycAYQ0AX4poOJG+V2WHg0nJFdOig+r8giUldulzjGaI6TbpU0F1f +UOvM33UqNF58BwhK6gkH1vUtgcPmE0= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-22401f4d35aso26687365ad.2 for ; Thu, 06 Mar 2025 21:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1741324769; x=1741929569; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I41lBq1Kk3lA1enOkQsq9Bf6kp48L0kLMkvHsbpE3h8=; b=lVyEDez5DyQrcb0fylonbOe0JN5EN6Tv+eBOAq4qWHVl8c5bFaJCutsESqynxMN3BO Wk6wvWKMs8HlpAte73oc1HCjmxjKZuwMlkXWZI6JpxkwVB1KaiIsWIlS63EQeSltpyLh t8gp4GrxF4WhVWp7/A+cqEuzaMvn0COMTKca4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741324769; x=1741929569; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I41lBq1Kk3lA1enOkQsq9Bf6kp48L0kLMkvHsbpE3h8=; b=X/y6TBPXPHe0ck60avBsSR7T3M3m1LjsRHjq+ehYA8m1PV0h5Xg3ZjMdN+NCk9b4mp ZMj4r9Z4IFyP4pz3gmG0mxXaAW6sLPwvqi5ka3Nnk49aWy3I+CDre+0a+KQXd7vjnb/N rYEhNY+UK+ZSCSFthHzg+aMMVBeHHZI1cQYNzcMFY13OY+1jMjn/R2uVwqLcuTSo2Aou 5JVLIkLo7wk/wpp4lIoOSDtW6DscngkKYa+xvBW5dd/sy+PVsVtIRVb1bMf7C08tYUYz RGsw1NtlJg5zm9D0SwikBMIVYvX5jDgKRM3DfP7g4CKkF7DHDnyf9Sg1mgV232kU4vnz 60Zw== X-Forwarded-Encrypted: i=1; AJvYcCU20cWvngKT69qm1ixv/g9Z+YXz8MYPVFXVOHHlwUyzKTHs5fb+oPG76okmlmkSam8Gg2BW1ddwsQ==@kvack.org X-Gm-Message-State: AOJu0YzlgZn3sRQ1Gy/82Vuqd4oLz3NNj+AlLgSpNyqz/FzN3vNfYs1u 0C6Tqw3cq/4XaD3yXa/cfQ3JOlH+ex7leb3Kpd9r3wI3co5WfPZf+JTiL+ZKCQ== X-Gm-Gg: ASbGncuIWva/GIgDc1eWBWHpkaLcru1R8RXZ0uQV+tbPDFQHwGrHmP8v2XOy3C6J4V3 UtiCBp/MfOy8OKudFBFXHmbGAgNxmAdoEAucgJndxYOub0V65cI4kPP+5RocZe1/e7wH2+7X0LO UvnbruEb2hI5UkgxpSQYOlVOXkG9i9oab8H80urJluXnKbmWJoKTxQOrKHzgPz1ZWDiWVYQEWbt 6yjy8QuoRGxLgd60CmjuXFdSBWIb7S1DeiAyG+J+ATiQ0RsnNSyz7C5Zitph6dyA7v3qTRGqjWV 3uLCnenuWZYyb26ilTKCkD0kdw8zKUAALXfSK75tMcvNvLA= X-Google-Smtp-Source: AGHT+IF16s9ouPXqgk3zQFipS55nSpIxZDxUa+HP2BQJAI1twAJk6NEzN/hQ637L6tb+s8Xpn5Z/vA== X-Received: by 2002:a17:902:f68a:b0:224:78e:4ebe with SMTP id d9443c01a7336-22428ac90b1mr26083455ad.33.1741324768746; Thu, 06 Mar 2025 21:19:28 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:47b5:912a:f34:d434]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22410a91bd2sm21291115ad.193.2025.03.06.21.19.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 21:19:28 -0800 (PST) Date: Fri, 7 Mar 2025 14:19:23 +0900 From: Sergey Senozhatsky To: Herbert Xu Cc: Yosry Ahmed , Sergey Senozhatsky , Andrew Morton , Johannes Weiner , Nhat Pham , Chengming Zhou , Minchan Kim , Thomas Gleixner , Peter Zijlstra , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable 3/5] mm: zpool: Remove object mapping APIs Message-ID: <6nuc6oijrfn3aejkzr74vuzipijuyodgqc56y526sv6d75kiwk@mmxi65rmj3yn> References: <20250305061134.4105762-1-yosry.ahmed@linux.dev> <20250305061134.4105762-4-yosry.ahmed@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 7s71xzq1s88kozdwoekanoj1urz4ptm4 X-Rspamd-Queue-Id: E18FA8000B X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741324769-191175 X-HE-Meta: U2FsdGVkX1+IJpolgIkpDv05RxA/SbVH+68Wq04VRbgH9//l47RXNAMgNgO6ZcbWhity+0AWFTE8Yjnzhs9OWFvyoE5NSitMRNTE+vf2rss6ALqt4fWVGN1W97tp/qLoHQjwVNBHz2cBr+Y3ha+LZHA+pvmnWYuXo8S3tGc9m10+B3KZ01e3caR7OcGEbtuvfc+erAKObfcAMxo8tBaRiNdHxk+KXpdZR4KskS+DQSdpTcQ1dG2i8N95YHAz2lY2dwYi6ijlB/fDx1LPeWM+AuD49IpqQ8rDdtuBnE8+1gDSLkr51bEUCRLKwkaumXpiQYUFUJuZYsc54ieNzwiWYPbScujVC4wQ0Jo9nkrKeU2VVjnKJb+YrWm7SuHFGucPR8RttqBUZVuMniGB6QLoGfOMT6np+5mSwrhvmJp/F7bg6N+egxc+mC69N51A3meMhb0+fklY0wXdPjDWld3lbHf9dNxhJJWCWEsNQjLGEf4i0eIvYwWSPrIjVs0fUf8bfklwAL/SLmauSgEyvb+Y0uY//U+u9SROtP4QsQ4EaG58+/92Vg7twFSTT+IAFswbmFHdEfNOvrR0T1FXv/hV/VF894gRiJr36xWBExAntybhLA1JYn6yTPHojIkB672W/PVIAg3jK2sYB9K5EFTpWw1D1uSYdRAvToW1jnyVD5utNBh+96jrZvDFMqiSqoHiuTlKjn24GM/47oerW7wRVgoJN1xavuFmzpt26yq7Vr2tus1UiBxQ5rHG6FFbbwN6euUbWDtgcPu6c4ZpfqBVIytmsg0j3YkKsjLM/nvvWmQxbO/F8c7IQa9w+6HgRO2rc0e/PTDCK5oGNvhfXeYm2waT3cmBNCpI1wc1wBc1BpuyJ6sYNuB8cMVhAp5Lp8yDL5hrm7SvNGIfkSMHU9QQ+ASGZQR/c7cZ8/HT1ZlkicPvur0eepxJONMIROh3YgGKt0SYs4CeHz3FMoQHHtA Q2SKu41G jmRpxlUOLa2vIcXFBn327rqiZ2s/YkGvgallyEAmf/m5YvxLj/ud4qYa/n5tMFtXWRjosFeJtz205rEO/nXjmLREyt4SKbp16dZph8WTbtGUBk/KcIONaOJ/eN3FFkoP0KLBhmK9XJFa3HBxACVxiORYg2NiSZLifp5o8SPnVcYK7S8wbiRUNY2/cqkeHgxC43CfFWQnqRBQakq3n0rSNmVuKC+j3JI+pdT+KJw8m5KRHR6YtpdaQbxalZoMgtHjfR42GKwDKnfmhbgYbOSteGMEPRzxqe3SKwx+3m5DakUBM1351yKWUwd7EvCWIFZq/O4vQLTPjaaSUB2VH7FdAclw5EJ6Aj6zSLoVbixRXSwuK298= X-Bogosity: Ham, tests=bogofilter, spamicity=0.026939, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/03/07 10:38), Herbert Xu wrote: > On Thu, Mar 06, 2025 at 04:55:07PM +0000, Yosry Ahmed wrote: > > > > The zswap and zsmalloc look good and the code is simpler. I am fine with > > this approach if Sergey is fine with it, although I wonder if we should > > update Sergey's patches in mm-unstable do this directly. Currently we > > are switching from mapping APIs to read/write APIs, and then quickly to > > the pinning APIs. The history will be confusing. > > > > Sergey, do you prefer if we keep things as-is, or if you update your > > series to incorporate Herbert's changes for zsmalloc/zram, then I can > > update my series to incorporate the changes in zswap? > > > > We can also combine the series into a single updated one with > > zsmalloc/zram/zswap changes. > > > > Let me know what you prefer. > > This patch is only illustrating what zswap would look like once we > move to an SG-based interface. So I'm not actually submitting it > for inclusion at this time. Ah, OK, that's good to know, I was also a bit puzzled. Perhaps next time we can label such patches as "POC" or something. > Sergey has volunteed to add parameter support to acomp. Let's > wait for that before making these changes to zsmalloc/zswap. Yup, I'll keep you posted (once I have something.)