From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E42C71136 for ; Tue, 17 Jun 2025 10:28:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78B456B009B; Tue, 17 Jun 2025 06:28:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73C046B00A1; Tue, 17 Jun 2025 06:28:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 603A16B00A2; Tue, 17 Jun 2025 06:28:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 50F796B009B for ; Tue, 17 Jun 2025 06:28:23 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2488CC0541 for ; Tue, 17 Jun 2025 10:28:23 +0000 (UTC) X-FDA: 83564518086.30.CC1208B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf09.hostedemail.com (Postfix) with ESMTP id D7E5B140006 for ; Tue, 17 Jun 2025 10:28:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WmjG5byt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pnny5t+1; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=V8XAlhZj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZOSe9hUD; dmarc=none; spf=pass (imf09.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750156101; a=rsa-sha256; cv=none; b=KY5J6VtSUtMtkr51sCLd0/WthvFFpCu0PbOluHRgvglw5oWtQCscdQCsAL76NVtMAS4V4T Rw3sLbWVsDXNkW6soHl/sltb3ftj58lvKxY9I9b7FtjTLS0ozp1cy7YCV+Cvw1xa5QN8Js 7DrrYIY9nXGnBbiwx+iR82UIrQiv4N8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WmjG5byt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pnny5t+1; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=V8XAlhZj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZOSe9hUD; dmarc=none; spf=pass (imf09.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750156101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yRL1pzyzWfZkEwjIrh5EPK0DyvqO4jGpH7nTdQIDJOU=; b=KBsdgLnLfYn4SP9dqb3hvi3v/FXXct0b8ysZjtI++VJimFnrnCgYp40j5m3Owcf4ylSzH9 YW1LufNq9aOot3ImiP0yHFHl/c3mh2Yq5y6IW/U6KgAwssBNcqkHGoAzCbfDoFFbhy5bXZ boetToXGgJuK7qqFKfpmEE9edZxM2IA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B96F2211BF; Tue, 17 Jun 2025 10:28:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750156098; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yRL1pzyzWfZkEwjIrh5EPK0DyvqO4jGpH7nTdQIDJOU=; b=WmjG5bytiy7I3a/BBLvW+VsIqotD5+JByi3+kYC+pJMvBTbqXyJesHTAiZz3I9gAH/sqUN odZ44BsgYcizKb8oLgEt7TVYvcI+tsVcCM6mtUrfDsIhCmfjtb9owBPB4UGS70/DLklX3/ Jo0XXlko/aZ2t3BgHpHVI8npx+gZ584= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750156098; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yRL1pzyzWfZkEwjIrh5EPK0DyvqO4jGpH7nTdQIDJOU=; b=pnny5t+1R3s5+oz10RPJdQZOZNrWl6PZC680u7CImBF6HezK9+Kt7F3opuQwryTFcHQpGE YCJF0/Vphg/IO3AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750156097; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yRL1pzyzWfZkEwjIrh5EPK0DyvqO4jGpH7nTdQIDJOU=; b=V8XAlhZjNOq8a7kiGH50OFfxbQped1myZsJ2VgF89KEp1B7ttzza88fJJmn8NOg1DW9f4B dsvPKunu7OasSmWwBpOOEngmUB1By6xbruLi8CNwnB8xMEMKKX3pNnCpg41JdP5EXk1cj4 +u3B2fWZyjPE8HDYsGAxwXD53Fd47Mk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750156097; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yRL1pzyzWfZkEwjIrh5EPK0DyvqO4jGpH7nTdQIDJOU=; b=ZOSe9hUD5u6zOvVCb2BXorJhOv5ONladUC3MF82cZkGy3ZY15cD1s7zoZ2vwuLM5JGKDm5 jOxbp0QBEPV9MGAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9FB9E13A69; Tue, 17 Jun 2025 10:28:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2Ed6JkFDUWjFHQAAD6G6ig (envelope-from ); Tue, 17 Jun 2025 10:28:17 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 4465FA29F0; Tue, 17 Jun 2025 12:28:17 +0200 (CEST) Date: Tue, 17 Jun 2025 12:28:17 +0200 From: Jan Kara To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings Message-ID: <6nktgdc7ygt6hncfnl33d2jlwvlydspiiklwf6oxiqxxcjhzs2@j6f36ktyv774> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspam01 X-Stat-Signature: 95knr1pxg14xpmdfwy5sbr43buakwhn8 X-Rspamd-Queue-Id: D7E5B140006 X-Rspam-User: X-HE-Tag: 1750156100-259479 X-HE-Meta: U2FsdGVkX18cELKdempAFN+/NU82mF7gReE4nC9cdvorUCDpTCyDFIcCWY4L9UXU1lX8b/BNLIlcpG6SwSdzd4mctOcB+hLoOQa69wQYLn8nRiQhitKn4A0N26A37teRu2f4VDoFSeVdVzeL07v9AsTKXmiEG+sWDDHneuQ//HquZwNIDO96Y5QLKbECGGRorunju5UGe9N3+vz5SPVvgF4GLP5uy2/OOn9nG+10pwUXZVAExSOnLDWbJbX5XYOwPuI8RqUafyyex8emtOKrEc57+ul79S8saQ3JUFdYKNHT8NPYc7lhLOB1s3CCkedOpM5lw+0eXk4nPUl2Gc7P//MjK+TCrKnqQbMCpkMpPRzVEJ/B1BqNDboX8uA+IaXHWjOEU8EMl2+Djidrw+rIPvbMdLJ7n+RmxEl4WegYSf5T51N6GhVyR8Wq2kx5Sp/TbF8dEaFn7yl8uQnFtUk7RwneubftkQGIfBCO8J87dnPTsF+Y5HncXzbwEBwR3eBMy6CzvMufDC5ypR/74PLnzPOfx1rN8z4CvvqjuGWV+wQORkHuA1HOwdgz8yqpPP4mFxL7UncW1blAnRXYvLoXo+3sEaeQ5fp6I0jPit7azMXGA/BSBRmx411UEB0KzaDpbNjbxyao6DsasBi7y0dNfx1Het9VPzcUq0fL2C2LRpgde7PKkG/TcNeNa+A1NTr962rnS2c/G6A45xPmBXiutuTHrPPcOBvNoDXFL74PxbCi04xxAZV+eOrxsV/Wa0+A+8PJdMecHcTzsb4fACTGDccltQhE0dF4Ew7d2HIZhtQogO3QjltCeeIQSZOCFdVvuUUZohtzoLfZ8Gf1PN14txuVFfLaoSvPaFVlicaloDdGTtuSxADsqD+FW3SGeJ1bD5U9UFMYiPzVISyD3sfuE6a4NJBAPSCTFJFlHR1lzv1kcPW+kj6/8wS8COtsptsWkSNEk3tN7ubpEyQjTd5 ypX3B/RA kFsat+v6IGgDAwHIm/gT61nWSn48z7Ih10xyzzVo4lb4boYN0H0VCeJgE6so9L20eEEvnVM8wmq0id5ozYy2mFw5oje72xWqLIPB57Z1rzTmbXHDiphMWGmV5ulH/GIaiP/xna+gD4E5Cnd4Kh/AQG8Y9EoARBqEoFOLfStCceP2HZ+32IsMp8T+mgppJ/GOIKOPlb5X4pPsp1ElIVTmZZkXYhtaEBSHVaQlWrfZwdoTSRf6BkYxeO/6McuHWItYy7gHvTduk8AdT1O19fyyiISJPg+rAu1l72adu9b2MV3ug6mJaj79lmPKOGMAIA19f7MivX7LWaQNFuV0/8etgmwlsCcwc1kZ3M8cdQ/zv25X0Wsc6AF6YRHQg3K1VcJkIZpAOIoV1A798TOQLcBGUygn4feov9sPvC0xKD4x0oIXuKyn6PbcyYSwm97mZeyV2XdlBDKDXwb/qXifkkG7Fvge9D+S2yrhCSR0jYQO7TVrX1tg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 16-06-25 20:33:29, Lorenzo Stoakes wrote: > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > This callback is invoked in the mmap() logic far earlier, so error handling > can be performed more safely without complicated and bug-prone state > unwinding required should an error arise. > > This hook also avoids passing a pointer to a not-yet-correctly-established > VMA avoiding any issues with referencing this data structure. > > It rather provides a pointer to the new struct vm_area_desc descriptor type > which contains all required state and allows easy setting of required > parameters without any consideration needing to be paid to locking or > reference counts. > > Note that nested filesystems like overlayfs are compatible with an > .mmap_prepare() callback since commit bb666b7c2707 ("mm: add mmap_prepare() > compatibility layer for nested file systems"). > > In this patch we apply this change to file systems with relatively simple > mmap() hook logic - exfat, ceph, f2fs, bcachefs, zonefs, btrfs, ocfs2, > orangefs, nilfs2, romfs, ramfs and aio. > > Signed-off-by: Lorenzo Stoakes Two small nits below. Otherwise feel free to add: Reviewed-by: Jan Kara > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index 60a621b00c65..37522137c380 100644 > --- a/fs/ceph/addr.c > +++ b/fs/ceph/addr.c > @@ -2330,13 +2330,14 @@ static const struct vm_operations_struct ceph_vmops = { > .page_mkwrite = ceph_page_mkwrite, > }; > > -int ceph_mmap(struct file *file, struct vm_area_struct *vma) > +int ceph_mmap_prepare(struct vm_area_desc *desc) > { > + struct file *file = desc->file; > struct address_space *mapping = file->f_mapping; Pointless local variable here... > > if (!mapping->a_ops->read_folio) > return -ENOEXEC; > - vma->vm_ops = &ceph_vmops; > + desc->vm_ops = &ceph_vmops; > return 0; > } > ... > diff --git a/fs/exfat/file.c b/fs/exfat/file.c > index 841a5b18e3df..d63213c8a823 100644 > --- a/fs/exfat/file.c > +++ b/fs/exfat/file.c > @@ -683,13 +683,14 @@ static const struct vm_operations_struct exfat_file_vm_ops = { > .page_mkwrite = exfat_page_mkwrite, > }; > > -static int exfat_file_mmap(struct file *file, struct vm_area_struct *vma) > +static int exfat_file_mmap_prepare(struct vm_area_desc *desc) > { > + struct file *file = desc->file; Missing empty line here. > if (unlikely(exfat_forced_shutdown(file_inode(file)->i_sb))) > return -EIO; > > file_accessed(file); > - vma->vm_ops = &exfat_file_vm_ops; > + desc->vm_ops = &exfat_file_vm_ops; > return 0; > } > Honza -- Jan Kara SUSE Labs, CR