From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B366EC4829E for ; Thu, 15 Feb 2024 23:54:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BE996B0098; Thu, 15 Feb 2024 18:54:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 348568D0007; Thu, 15 Feb 2024 18:54:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19A966B009C; Thu, 15 Feb 2024 18:54:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 007456B0098 for ; Thu, 15 Feb 2024 18:54:40 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ADAC9C04D4 for ; Thu, 15 Feb 2024 23:54:40 +0000 (UTC) X-FDA: 81795695520.24.0D98DF5 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf25.hostedemail.com (Postfix) with ESMTP id D7E46A0008 for ; Thu, 15 Feb 2024 23:54:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=V1agdiFf; spf=pass (imf25.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708041279; a=rsa-sha256; cv=none; b=R9NDPaqo2S5DP/ifwdOW78BbNAm+TKXR6ooxmBVTzvbBccgVeJpkdJp0uvUDWPTnpq+4N4 Z2AEek42JOIf9z5kxjYyQc/CSJjl1cALXT6toXopLjqalTeInvbc4mkrJ3EzexpA6LKc7H dTHNh5GXBasbZ/BbfWKpxlnT13KsSsI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=V1agdiFf; spf=pass (imf25.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708041279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K2uij+2SL3ce4+254m7l2JMunInmvxqqhYhnbhOg6QE=; b=aX2ucCwE3UsuG7jxrTHyifaUlne88ASrikE82J/AzQsRk40GBzbeGcIGgsscozjtJk8gYv 1wYBKFX9o+jVnI3d+WfWynN7uNnlRKepcXyTTkpTIG6lIuZntrfU77DNOPgWsfMXry0ZjP xCW/x2pK5IPOuDot6v97oI7i1ssQvo8= Date: Thu, 15 Feb 2024 18:54:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708041276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K2uij+2SL3ce4+254m7l2JMunInmvxqqhYhnbhOg6QE=; b=V1agdiFf2PWalNLvXcX/pEaaYs1LzTR99jNKgHHksR9pk5/i4sCMiqHAc6qlownhM5WAyl OqzNpW/LSM50S1rLe7LeKiTEyj4Uqd2FpbwOOt1xn3GjS5Kqmd+qtGSoP3zkFaJ1MFitLS Rmu6c2taXzQ47IwNRs2zeWhJq1hQz2g= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Dave Hansen Cc: Steven Rostedt , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , akpm@linux-foundation.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 31/35] lib: add memory allocations report in show_mem() Message-ID: <6mjunla45lkwqvkq7jegiw5lfmufg4y53zegevep3iwvy77xub@2nfmbeo6tvz2> References: <20240212213922.783301-32-surenb@google.com> <320cd134-b767-4f29-869b-d219793ba8a1@suse.cz> <20240215180742.34470209@gandalf.local.home> <38e34171-e116-46ee-8e2b-de7cc96d265e@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38e34171-e116-46ee-8e2b-de7cc96d265e@intel.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D7E46A0008 X-Stat-Signature: r6enyc8wtzg8iqw77ehez8m1xcfzpmf6 X-Rspam-User: X-HE-Tag: 1708041278-431694 X-HE-Meta: U2FsdGVkX1/jxU13zrRpcCaxtsY4grHgE8L1NZgazEy60cXnKHv5vvEg0EWp11MrP2jHTVWQ1YzzNxUNMa/fjsqwIhozni5xaZ1EdZYy/yYQvME3JAimwLSqP7dYC25R4dfVFICz2DhS+0tvZB3gvTr5PxSSaMdMfLT8kQuv4cSYRGPMUl8xWahmr9thzBY8Ex1ReWFKM13ToGETw7Gfs7+ql1fLp12KkaWFGcAqB/soKQTPybrs+O+2l48jpcoQ1T8rfC5oZszMRj8wK2mk4aDXkU/MpUrWIL5X+woXNqcwt6pOZzoOSnBuTr6cEMGtyyPBeJf99rVjexO1zJLXRqvTFo+1Sgzv3Lc5bbNQmAXiOv67dadynxjMDD5MQ81nmvFHLdLQSsZs27fl11OvHMu6OEO5GtzTmoecrtDuTPCaTHSyeL4bmZw5Fx7UJkRy40z6jQhY6be2VwdaHcSE6uBasld5ESeARftm6pa7fV1qbJ+o64BrBZCRy0cx1QJgqnw6qFi49EWmFg83eV1bk46WWbbDn+Ww4G/J5LU3bLHlptkylDvDrRO9aZ8l8t0C6+bjxllha98mG4avChx2pgZIhX/h08UJLgAcdJXle3+OvULF3rrNqJCs/ugU77AXgQii2UDTinN0Nepp/Dw/UTcIBUAnv0QZ+6VF3fnCzmgyC+aAWyrc3SPOT05hogsIPYyR8CXFS5mUZ3IkOaw4HruFJMNSWrhWnQVeNqlay5uzYqG/sZ6bt7ThkoOwS1sWKYsxdwzcAAWbs3NPMIs9+Q6KK+KfOVgZ3yDvuqgta+lxDj3IBFnjeqBz8YA6ziv/7mPSyEfzLHvTIYFl4mWOp5jq2nkFic8SJSr7WjO2hQALQg4Ze1UFuUEFPoUK76/pySOj1ufshqvPBcBXBFpgSConlpgTYiWOexh0vz4Z7/m6ZIquzlpV05tm2GyF9KQfZjL79CUeoFvD7OcXlqN R4ljOfZI Rcn/+5lDg8QFDg67GgVP4OJLTg7l+LPR+3/XFjcUBLs81jS8+sw+7pe9u32Ubft18Og1iyKsbOqRv5bDbnw5OMNbRox9lzQ1i+UcARN76C2qq/+GMz2Y4ck5RjRmPqhlnTO4HTrG7ON/mpadebUK5Zk2cBfp6DI5PKQQtGdHz6+WTUW3DdxPeNzWTrhAd+y5MASgKtEUghTMAnXo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 03:19:33PM -0800, Dave Hansen wrote: > On 2/15/24 15:07, Steven Rostedt wrote: > > Just adding the patches increases the size by 5k. But the rest shows an > > increase of 259k, and you are worried about 4k (and possibly less?)??? > > Doesn't the new page_ext thingy add a pointer per 'struct page', or > ~0.2% of RAM, or ~32MB on a 16GB laptop? I, too, am confused why 4k is > even remotely an issue. page_ext adds a separate per-page array; it itself does not add a pointer to strugt page, it's an array lookup that uses the page pfn. We do add a pointer to page_ext, and that's (for now) unavoidable overhead - but we'll be looking at referencing code tags by index, and if that works out we'll be able to kill the page_ext dependency and just store the alloc tag index in page bits.