From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8410BC369A2 for ; Mon, 14 Apr 2025 13:55:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F18CB280055; Mon, 14 Apr 2025 09:55:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECA05280054; Mon, 14 Apr 2025 09:55:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D91D4280055; Mon, 14 Apr 2025 09:55:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BBFB5280054 for ; Mon, 14 Apr 2025 09:55:41 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CDF1F1C7FDD for ; Mon, 14 Apr 2025 13:55:41 +0000 (UTC) X-FDA: 83332797282.02.EEE3F0A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf25.hostedemail.com (Postfix) with ESMTP id 8B963A0008 for ; Mon, 14 Apr 2025 13:55:39 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wzXiY1yE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jkmHq+hM; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zSCtMWf+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5g0P9LPk; dmarc=none; spf=pass (imf25.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744638940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wbd2u8etanLwCgjaIHVqyALGaQfIGhfcAWH4/UjSTEE=; b=MjfA/Aa3BsQYLQyOgztYndkdDxcPXC+Lp/tlnNtbHk1NuwhIwQ8tcS0EBWLF7r6CL82RQi lqdNb99Xqsro1sIBTi++7tviLGm0EsyROZjeOdU1ct1ChZ1JsMbRjkQWWb959uET786+rb UoEG0U743RIfiFEBPfAze4L0GKv98TM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744638940; a=rsa-sha256; cv=none; b=Dqw1v9FF4kQ9hAH8r3B0xj72eoLCR+/AMPOEM/0SRMhBD4bG1svMEwgI8ZOzKN5pZDHSbW mbFomdVWinMMj7E4wDXAsv7oRB4uOeAo1etwoeDpm6Iw6/wDU8MXaZDNTXCP7jvqLaxAqC OdeoudhqdzusdCi8NdDa2UUm0Vrtt98= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wzXiY1yE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jkmHq+hM; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zSCtMWf+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5g0P9LPk; dmarc=none; spf=pass (imf25.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D03E621285; Mon, 14 Apr 2025 13:55:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744638938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wbd2u8etanLwCgjaIHVqyALGaQfIGhfcAWH4/UjSTEE=; b=wzXiY1yEB95AiDyYGkUPUatZ9ka1UIFfMtbMDujew0olVoBozXiZR3IXuiJaYyAvTjqlkc ffGO0f94WvOSs/xcQoqqwApb+2SFKirTk29CUyFmKop8kdxjcmc3pzRGesjisa0WgoxfaZ 0rHYasaNyE+Uho7MFybleatnaoJMeIc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744638938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wbd2u8etanLwCgjaIHVqyALGaQfIGhfcAWH4/UjSTEE=; b=jkmHq+hMZAS6lbShgn5oI5j2rUY6ilru8Ar/+qf2J/hXF7S/O+HZ0feC98biWPQbQT+wK1 fMAigSvixFRWXpCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744638937; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wbd2u8etanLwCgjaIHVqyALGaQfIGhfcAWH4/UjSTEE=; b=zSCtMWf+wT1fhUG+omccUMiztbWCX65tCmfZiXn1TU+piEb0fdPM+SItvg8fOrkVI0Qq++ Be0wOFSqxXG5UMI1MZngpKytcvPQh/1jx+xBIlQZ1ne6UCR9FAKpM9zEiu217v4Zm7gJ6Y ogSV1GoNG5p2rvylUQsyVrIv8323Wok= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744638937; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wbd2u8etanLwCgjaIHVqyALGaQfIGhfcAWH4/UjSTEE=; b=5g0P9LPkS3R44MdBt8w2sXAG2b9UySsrKbbDHxg+/Y0huVTFxkB/9YYICVCkJ9SnLorJps 3UKyAVMmijCpgYCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C597B136A7; Mon, 14 Apr 2025 13:55:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Edo1MNkT/WcYBwAAD6G6ig (envelope-from ); Mon, 14 Apr 2025 13:55:37 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 67CC0A094B; Mon, 14 Apr 2025 15:55:37 +0200 (CEST) Date: Mon, 14 Apr 2025 15:55:37 +0200 From: Jan Kara To: Andreas Gruenbacher Cc: cgroups@vger.kernel.org, Jan Kara , Tetsuo Handa , Rafael Aquini , gfs2@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v3 2/2] writeback: Fix false warning in inode_to_wb() Message-ID: <6k6kbrcw5bythxn7xu2u7xm4ssaiprnzr42qmf2oqyd6igdoy7@cyv67iatitvq> References: <20250412163914.3773459-1-agruenba@redhat.com> <20250412163914.3773459-3-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250412163914.3773459-3-agruenba@redhat.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8B963A0008 X-Stat-Signature: r33ktc4src7xx9iu5nwb4rgej4moxxwd X-Rspam-User: X-HE-Tag: 1744638939-330268 X-HE-Meta: U2FsdGVkX197ooFWnm/zUcMdaWD+4aY++pcVu60BrluUGYcWRgSoFrRpviqx3Y8fO5jra+hFCeWO2k0P0MF4Nvj4lh8T99G/z7mnCByaVEXUnyRMBoQN06Eo/onQh3dda/faq2u17BKzMXtcm/jlg2jVmXiEDUPdNH+hql76z8n03PRuyK+9vR3ZZq/UM7q5kY+mXTJoiJjuIT51Xt3JsFqEapDOVo09Vpcrz0fRBC8QKUS+WY5XURaWOHswOa24Cq3cLnEkqMjVGusRrUeDrM/BQ3qnlyembkuKzGysavI2oO8tTsYjZ1bep02t3b7ZNpSWjxbu0BIJY1uxgQUuuevDxUwg3xDSK+54rKYSxVkNfMCOv6p4L1w7UUWXLhkQ6WOhDx+M5FHgiKSHW8T8VVlh7mvDNJSdkPV031r4y9MC/5+gvQHReVcnJX640yIOU1HNAObbczdI5TGKwO4PazwsGQrOoXjVSt1YDJP6EfHUli7W77FHF6NwmfjCls5HlxLyaaQC0VFmC53I6cPD2EEvR8OWIm6ceOrYJjbrvc+Xdvuu7mnBGf2RICDw4JlW/B3Q8iixpRkqMqDeMzjkGGfM149Na2wRJ17VyTU0+kxKSPxAftwMkZYB+5uR/MxfabFeu9gJAznUU9LZEn3WhIJ4BFZX5MuVnYx3ZLs096vraxrQQW5ws/v0G0EfsyBNwk53dL39414PclXixeDBTykKQ7RNUjqR5+X85g3IuKEGEStyjiS55KdDxAnVobsRVOJBwIh7J7L2BOQLXDgOCO0L6Z0McP1jrWl1vl2xknnsyDuKlFLbqdyl6cV8OXftHXiWBneQQvUjYM+todD12WIkaH0DUQBVNqhLu353jGNr9vdH53hL6Uc1hQZSwTb/FBZDTvkTSaw0ygvSVdmmnDrLNs5RNk7tbFZnIKau4tjxG5amwzW5YirtlkqzSiWjhqXp/qDr62Jna+BNoyZ vleW3Uk1 D4m9z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew! Can you please take this patch through MM tree? Thanks! Andreas is already taking the first patch in the series through GFS2 tree. Honza On Sat 12-04-25 18:39:12, Andreas Gruenbacher wrote: > From: Jan Kara > > inode_to_wb() is used also for filesystems that don't support cgroup > writeback. For these filesystems inode->i_wb is stable during the > lifetime of the inode (it points to bdi->wb) and there's no need to hold > locks protecting the inode->i_wb dereference. Improve the warning in > inode_to_wb() to not trigger for these filesystems. > > Signed-off-by: Jan Kara > Reviewed-by: Andreas Gruenbacher > --- > include/linux/backing-dev.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h > index 8e7af9a03b41..e721148c95d0 100644 > --- a/include/linux/backing-dev.h > +++ b/include/linux/backing-dev.h > @@ -249,6 +249,7 @@ static inline struct bdi_writeback *inode_to_wb(const struct inode *inode) > { > #ifdef CONFIG_LOCKDEP > WARN_ON_ONCE(debug_locks && > + (inode->i_sb->s_iflags & SB_I_CGROUPWB) && > (!lockdep_is_held(&inode->i_lock) && > !lockdep_is_held(&inode->i_mapping->i_pages.xa_lock) && > !lockdep_is_held(&inode->i_wb->list_lock))); > -- > 2.48.1 > -- Jan Kara SUSE Labs, CR