From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E311CF34AD for ; Thu, 3 Oct 2024 20:40:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C3B36B03CF; Thu, 3 Oct 2024 16:40:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 801B76B043D; Thu, 3 Oct 2024 16:40:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CDF06B03CF; Thu, 3 Oct 2024 16:40:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4A81B6B03CF for ; Thu, 3 Oct 2024 16:40:00 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C87A280AF3 for ; Thu, 3 Oct 2024 20:39:59 +0000 (UTC) X-FDA: 82633457718.29.D873278 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf12.hostedemail.com (Postfix) with ESMTP id D7ACF4000A for ; Thu, 3 Oct 2024 20:39:57 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vCwbHIpc; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727987931; a=rsa-sha256; cv=none; b=Pr+saKE9riIWvENWY65EW8adIHFQvPOGz/t4sffGYB2SFqg5+cH+XzTqE3cANmRT9sKqR2 SISo3GpYpKUufSfi1fSY9qV7mua/OlVaRcmRC6BdXH3lh044THQtL8W8f7ZL1uLB91VnUW +H3XhICHucWx0oh3z3D38mkLCfBCKV4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vCwbHIpc; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727987931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1GXP4MsEFjVh6723D6q9r7Kp5xVj4bm6p/OLLkYcAE4=; b=La4DhhaP7SfTd3i48dGVsy3IyS9qMkCBCsyEL17V+JJo7uzrNNK2hjAoEr5/3CBX9V+4K0 kwW7MAHx3JGsKmNVHcc4k+TU2cBn3JbgBAIssE4E0HmVX3NC+LUOedTipCEbRyccn5D3of SO7hoU2RcQTPQvEb7cuw06LSeYtZefo= Date: Thu, 3 Oct 2024 13:39:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727987995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1GXP4MsEFjVh6723D6q9r7Kp5xVj4bm6p/OLLkYcAE4=; b=vCwbHIpcJ5WVzm0mX2BFL4VqWdtE/KYv9oL9Jv+f15FRlFuVIyhz54SI5zWFU7QqKPZWcf rAju3c5oHSkQaCKq1UpYCffUKyK1Da+wUgePHNIzzhdr4XwlVZVW7s6m0hgwzSGWXqmTti vJQn48OCIE1wts0wsKtQkCAtNZttgas= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Michal Hocko Cc: Christoph Hellwig , Qu Wenruo , Qu Wenruo , linux-btrfs@vger.kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, "Vlastimil Babka (SUSE)" Subject: Re: [PATCH] btrfs: root memcgroup for metadata filemap_add_folio() Message-ID: <6fnaifzq7iufgqbj67v6e5runho74lfmjnleltc5upu33gtruc@utjdg2zuksby> References: <5d3f4dca-f7f3-4228-8645-ad92c7a1e5ac@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: uqwoyoxkygcqakyxrdk956g93nbfqwc7 X-Rspamd-Queue-Id: D7ACF4000A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1727987997-701207 X-HE-Meta: U2FsdGVkX1/T65EJW/S5PcSaT8e5AvS2oer2ShAEG54G9RiNGhxe2fX49X8esM/dpToF6c6FweyVut2NPbbkzikeM0ZwdxxAz13DmzGcy0GMs0eA80bBE/LoCaeluIqP6/PTcaIK/0aZ5xDPeouku1fVd2KDF9H9tfj6WoCVs3kssHeHFATpYjSi/yTEpeWNvwh6p5cdRwcNouJ+XazFWhXv7C95GtVA2e41tsPJvuIrDyWxbXjVbMd5l1ERyDMVMD7L5qdM8umZW2Njs7UyZ9FfxGhILWlaf3dnFbpZGy0nKIo9kowzTY3F4USmG/s+Tra6S9Tq/pmU86jDmDrfNTBTDRoaXzRlS+I052eq2EnA9Ha7abuYEl5da1Q+Ga0kKuaihsollcTmWX7Kw+fXZDB2hcQ2rbxcfb22GiZBbbxS6rEYCe3UF8VbAZnAOPnZ1RgvXHSrf3IALRV6J9eCWPEb1im9W1VXnHTkRYpR9+95WX5AW+Qw2B62fTgdOeVU249c0fnWLuYLexM9XM/D36FdntV4X4cZvEWEI9SUHM65XrOF8RJaKfOxzRD7bOFG4K5p9aZdpktLyCZgbs2eQ+e9WF2Akn/qzFPdIb1mYKYBviTsyWJk0C0LOE0viEaT05rS5CWm3vtJfu/vo3QHkTDtfFGNvwa3By0WHxK0cG9yA5L7Bqxbl2CT6tIDyXx5Jwb34ELX7kDngSNsw2Rkg+UFJv69YvrVTCveuYYg5R0aecGUXYrqSaYT4QeOG8BiP6153kYbKgtFRNbYcvtsKtBi3c4iXxhMxR2MxD+TVsYKM1+KmeH4Rez/A5IYEuLkmavXzqArmsma6UhqWBxg7WkLUu7scR9Sr914JgJkfb9bZ5gvNVnnLNuAgjYxtXY5YZ59d+VoCgarkCpafFshiV4N7y21MXkLcrGtSQD9YvJ9e3lD96nERR7z4vA/amgZt2VMIPLuxefk8eCd7l5 hZdlYqmU gUGxnUPf0NT7qtuUD7LI1br5zOQEN0uZ0BTRZ5g3eB0jC5wEdAb8PsVB8ErP9STJcO0+sd1NXhWsaINcHElwCStdTl3hM+CFpOdg+l/LYNup/XeQgbL8lCjNRDZtejsQKH7csAfRnTiQUAPm/rec/thDMkKxzU9ZI2GEclQAbNSaDdyfM2LMW8HO7l7Kb1I9/BW04Ze4jC1IckQDKGWZR1oCvi7dcLGgdO/rU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 03, 2024 at 10:07:33AM GMT, Michal Hocko wrote: > On Wed 02-10-24 00:41:29, Christoph Hellwig wrote: > [...] > > What I'd propose is something like the patch below, plus proper > > documentation. Note that this now does the uncharge on the unlocked > > folio in the error case. From a quick look that should be fine, but > > someone who actually knows the code needs to confirm that. > > yes, this is a much cleaner solution. filemap_add_folio_nocharge would > need documentation explaining when this is supposed to be used. > I feel like we should not make bypassing cgroup accounting easier but rather make it more awkward :P, so folks give much more thought before opting to do so. Though I agree filemap_add_folio_nocharge() is easy to grep.