From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B76C7EE29 for ; Wed, 7 Jun 2023 11:37:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DB74900002; Wed, 7 Jun 2023 07:37:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78C548E0002; Wed, 7 Jun 2023 07:37:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 652FD900002; Wed, 7 Jun 2023 07:37:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5529E8E0002 for ; Wed, 7 Jun 2023 07:37:17 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1E574160233 for ; Wed, 7 Jun 2023 11:37:17 +0000 (UTC) X-FDA: 80875750914.28.E7AAF9D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id B08FF40010 for ; Wed, 7 Jun 2023 11:37:14 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dRCOF5Ia; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686137834; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Of8F7oP9DxodgyCzUqZAYENpIjCyox0604fXJEC1XUw=; b=pgHLobxNbRX8It+nh6pMkxrNXdwoZKFmx1urWqrPJFzHDDZEp17vi20Iv1sKoU1Xu9dM+p zFu9Kmw19OmHA7crUa0n8jakDTF7b1uRvopxUiTps3khOJJFLV8bGi9hKR7ox40M0cqJaH I88Ob5k4dIu9WYcIkdp3XebK5Dz1aWI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dRCOF5Ia; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686137834; a=rsa-sha256; cv=none; b=PpuW8qQhjMe6Ov9ISgTE5qNyXjkJnCK9qhAxlJk0YsDZXO/qWv4MfszvgFQqCLL6TCV7rr 37Q/tJKB5LjYa3KxoY74qlvXdOGIgLCPm8q2jl5YpjPN1ar1FMw8BK258GNyHKy/WSg86i 64fdbmMOr/NAKOqR5f8HQ3Mn2SRoWZc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686137831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Of8F7oP9DxodgyCzUqZAYENpIjCyox0604fXJEC1XUw=; b=dRCOF5IauimwKpi2rTcSeePrXBQdLGIG2y1Otf/++Q7PAGYXvV3KQ3B1V7LWi+iM8hnkgV ezHcHI/5x2nQ4SGuwmxX+nEFXv2yHPSZ/u1qvHaXo+6UGPibm7QYOfa4MjApyqMs1F34Wg 0c5ZA7yaJ5dDDt7zN5y0VKZPFmN9J0I= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-hiKcoTUgMYmhmSz-LaSPqA-1; Wed, 07 Jun 2023 07:37:07 -0400 X-MC-Unique: hiKcoTUgMYmhmSz-LaSPqA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f5fc8581a9so36340375e9.0 for ; Wed, 07 Jun 2023 04:37:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686137826; x=1688729826; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Of8F7oP9DxodgyCzUqZAYENpIjCyox0604fXJEC1XUw=; b=gihDZEcu9ctQQ5LCNuKGV6E8xuWOVgnDTgr+0Y2TtKrb2L297KTiiuh7iQr/eNRBnW rpxJyQ0Jcb8yN36zVBVsiHfsItYuIUrGhXn7ktoZwPCGwnLuqejw8O4JvbV8CRlGj74d w97opPSz+g+TCP8b6GUrtAjT9QbNE4ugkVvsWie+zcZqVmfff67aenCs/MbNxY3x6pqF 9RJF7S34YJoeZejRkopRPHEeqilhb8+UDFCazbg0Sr8uX5ewvAeQx9tUV+hRA2scbXoL z60XMuNLUzbs4Dl1xEmj+iIIHCS2PrsX4lTZDCnBU5AhizsRJQuJ9py/+0fqqe48daxE ymUg== X-Gm-Message-State: AC+VfDyTPsvSPukUclgnHGb1HYMkBh8meSjYNBzAhTE7gEVFFXiGzKuE eBYCL2KhjK/w7C/AnT9fsjfUPMsB/S61YdDPh7akXunq8zX0TP8RtlKXqDTSK8WYyQU49cZJ3sW n+t1BFQgbYco= X-Received: by 2002:a5d:480b:0:b0:30e:5b7c:de1c with SMTP id l11-20020a5d480b000000b0030e5b7cde1cmr1271453wrq.11.1686137826603; Wed, 07 Jun 2023 04:37:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4MUOjtFrG5onWxT2DxxqjjxHSYc3VMSVJB1Wn+zwDFfZnCS5zfDSPT78n2RmXbz+ZcAbVfWw== X-Received: by 2002:a5d:480b:0:b0:30e:5b7c:de1c with SMTP id l11-20020a5d480b000000b0030e5b7cde1cmr1271442wrq.11.1686137826261; Wed, 07 Jun 2023 04:37:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:9c00:8d26:3031:d131:455c? (p200300cbc70e9c008d263031d131455c.dip0.t-ipconnect.de. [2003:cb:c70e:9c00:8d26:3031:d131:455c]) by smtp.gmail.com with ESMTPSA id h8-20020adfe988000000b0030ae5a0516csm15272856wrm.17.2023.06.07.04.37.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 04:37:05 -0700 (PDT) Message-ID: <6ff9bcb0-3fa8-59ab-418d-7a53714efafe@redhat.com> Date: Wed, 7 Jun 2023 13:37:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 1/2] mm/memory_hotplug: remove reset_node_managed_pages() in hotadd_init_pgdat() To: Haifeng Xu Cc: rppt@kernel.org, mhocko@kernel.org, osalvador@suse.de, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230607024548.1240-1-haifeng.xu@shopee.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230607024548.1240-1-haifeng.xu@shopee.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: nsmd9pxh94qrd6y5waobamf5fgfkyh1t X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B08FF40010 X-HE-Tag: 1686137834-11957 X-HE-Meta: U2FsdGVkX1/yNvdL+nKcPFZDGn0WorcJSRHJh//S1uBvu80RmYL99RKSdSOLxIF+u7Ja5ObMhe5cADPdAXC4gdWQ+Nyp/1+irrnusxADDKkhuwX9G48IyBsA6qbWaiOkjlaiKJNBOn4UVkwR5lb3Rlr7jY3k2gic7xSNnvJ59jO+LIU5a/lM+E72QmTs7ozuJyv0BCbIeACdl0Qci/1vwj296I8fLLnDIf9P0iCk8VslB79/P9YV+eLOclKkGd2aYTK3iEHw39MwcBHH94k1IkGgd3LuiqQfw1yoNJBIn/ZkHGMejbagd2D6hOYx2feXU4PUE3q/Ho2zTMSDdkKqVzN6f3jY6SVkW92y0zNKiQSY6SIEoMMazJ8TY7ba637bd0PZPjIx7fZdaGkFCi4kklFh4la0UmmwhHdLl9wqAOy8KIDtfJNrmQBnNsGzoBbdt2xxc08+TMYPXJaQOLLDosksheKe17oyjeCPOa4NXVgotMrwrbip6nPme18PeHRKmGTcwEVqa/rTWhlPLWi61Fvx54S2zB13tU4Wks5sR8ZksItR+25+GT86aBwFs1OU9ETbk3myj3nj0MNSErs1m3NrGf7GtqnCPkJ973AASkk6o1dnC8wWCkwMDrlH9HPNnYlLLU34A8gLesLMzXm2F8t8HYQgEfVQwqHAwhmMYIvc7HhhYykrK5uHAaiDHma+/b716PGBAyrYZFSJjOiuwVrbcd5YK2/BQpg21UtXXW1IbTN1mR6RPh+4Qx0HlhZC8/Q1y+HMTigBY+fg3U2q8rNj8I5dB0u17iOfYkvjbSLXvb51D2931KtlNGq724/svkXX5fwiwo0dbdBw3uvKzWX/ZL1iPyzZ5R8cc5JrmYYghxQx3iSSY9LCAhQpSTPYFeEtYkMD1aRnzLl1wdqQ59EAqHBF3vGkeGpu2guyllUYQFYPfXES4YzEC41+PNSET/mGPaEh1gW7MS4Su1N 7yEn708A KlUJmPoNBeW8E590U375b6Uh7SkdEGUmQ00Fbxi1UbbuHiQa++jgq6LwENVGR269E1DfxV6MzwULBhVSpU8J8DCz5Om/a+3xqih9jzr98a79kiEVbmxdHHFUIPwfZZgOnwLMolZJ2N2tvo+54Hym+2hNKYGz+TpMScfrM0to59IXGLeXHYCSrZUQqwhgWpmsm70CeteA5Cx403bK+QjtQFUVlcE6OlcgE7wxH2h8NDyNtbq7dS+XyGlGPzbAGocbp3nVLDvErTH/qKm46FHo35vQ/PkhvZnGDUldALSiJhWSo1tHBn4wEHV+SuzjFx0EHTxDK5crjtVcNTG1UHBP1BM4RZyW//fMN6B3gSbsVWCmXwyc8kNvXkkURXrBfJGuf9KTqxQ2P1WwAU3CEDMzCHTawhnNgSJaHkGt79ZGqhQlxqOQLW2r5NG9HLN+TVYDsJlHCFtCE4ZTQp/gaOf6x1uOw2SS5Z+734Gyf87zd6YO68cfm4H/oC0ODZXoFMX2OGmCF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.06.23 04:45, Haifeng Xu wrote: > managed pages has already been set to 0 in free_area_init_core_hotplug(), > via zone_init_internals() on each zone. It's pointless to reset again. > > Furthermore, reset_node_managed_pages() no longer needs to be exposed > outside of mm/memblock.c. Remove declaration in include/linux/memblock.h > and define it as static. > > In addtion to this, the only caller of reset_node_managed_pages() is > reset_all_zones_managed_pages(), which is annotated with __init, so it > should be safe to also mark reset_node_managed_pages() as __init. > > Signed-off-by: Haifeng Xu > Suggested-by: David Hildenbrand > --- > v2: > - unexport reset_node_managed_pages() > - mark reset_node_managed_pages() as __init > - update commit message > --- > include/linux/memblock.h | 1 - > mm/memblock.c | 2 +- > mm/memory_hotplug.c | 1 - > 3 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index f82ee3fac1cd..f71ff9f0ec81 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -128,7 +128,6 @@ int memblock_clear_nomap(phys_addr_t base, phys_addr_t size); > > void memblock_free_all(void); > void memblock_free(void *ptr, size_t size); > -void reset_node_managed_pages(pg_data_t *pgdat); > void reset_all_zones_managed_pages(void); > > /* Low level functions */ > diff --git a/mm/memblock.c b/mm/memblock.c > index 3feafea06ab2..da4264528e1e 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2122,7 +2122,7 @@ static unsigned long __init free_low_memory_core_early(void) > > static int reset_managed_pages_done __initdata; > > -void reset_node_managed_pages(pg_data_t *pgdat) > +static void __init reset_node_managed_pages(pg_data_t *pgdat) > { > struct zone *z; > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8e0fa209d533..65e385f34679 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1210,7 +1210,6 @@ static pg_data_t __ref *hotadd_init_pgdat(int nid) > * online_pages() and offline_pages(). > * TODO: should be in free_area_init_core_hotplug? > */ > - reset_node_managed_pages(pgdat); > reset_node_present_pages(pgdat); > > return pgdat; Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb