From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE75C4829E for ; Thu, 15 Feb 2024 10:43:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66B736B008C; Thu, 15 Feb 2024 05:43:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61B986B009E; Thu, 15 Feb 2024 05:43:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 495A56B009F; Thu, 15 Feb 2024 05:43:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 39A396B009E for ; Thu, 15 Feb 2024 05:43:14 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1DABD160FB1 for ; Thu, 15 Feb 2024 10:43:13 +0000 (UTC) X-FDA: 81793701066.15.8022076 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id DF78DC0010 for ; Thu, 15 Feb 2024 10:43:10 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aE0z6y7M; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707993791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zKRa0yC+0MiLHkj8ok+qOeouxMk5BBGoR5MWSe6wX3I=; b=JH+rHYdubLSuRNvS+YQk5RMDerapo0dlotBeiOc7qIhAWH+xVxDXWReoV8vSM/2HdSxjmN KGJSVquSQiOOzvmiP2q3T8HUw/KYqasLM5hs++iluiEApkaA0xjnKDb+zmrFco68G+I7wq xWzKlHZYLGTpJHhFOhkl1f+7AbbkgKE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707993791; a=rsa-sha256; cv=none; b=CsJjn4e4PGo6scGwuNzMZGFJuiKozbHhbxa8EJ+iFI0WFeFHkvsS9E/6bZwQiSxAdS51Qt vXb/V3MSmXCPKYrSlGkgZPMTYbImO3W6PwMGdzxDho/U3gvmzcD6F37EmOn6aEf7MGraUN HeMzJDnHUTqsLxvPwJvDVTDlG3ddT38= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aE0z6y7M; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707993790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zKRa0yC+0MiLHkj8ok+qOeouxMk5BBGoR5MWSe6wX3I=; b=aE0z6y7MflOrdHBeDSyB/31pyYy+c41jMDgVG6nMlJb8qlzfksCncFqNz/Ma7R/6/JQW8B M0GhBrb3ICr9KqncfuX+06B6sEiYqRQKHI6K3zrA6hUN5zv7uRQ65boWXGgjlvcuZV7pxd iwT8tU9jDXGok1EJ5EThEBMa0bkFqAA= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-467-xN1wvTDWMeSElitWNsjblA-1; Thu, 15 Feb 2024 05:43:06 -0500 X-MC-Unique: xN1wvTDWMeSElitWNsjblA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-68c43b9f71aso10796316d6.0 for ; Thu, 15 Feb 2024 02:43:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707993786; x=1708598586; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zKRa0yC+0MiLHkj8ok+qOeouxMk5BBGoR5MWSe6wX3I=; b=BUSuMu8VaxWXqqlXz3r8MBYTD7ZCjzDux6KJVaLvtuJqePoLIjFk4K3opf7B/uPYde AoKyovXCyzkQ6zfq1cw0ROK4jDF6Cd+SRHTBUhl0Nvi41fdTWd247+ga/Lh9m+jF7/AU LN7tRiQ2SHCxvMhnAa/WFwxFt9HnYTdQFIGw3TRRc+YLeLv9Sbw8S3DxtrRB6aZtAiJU htuYGJMS3y+DTDgFPy5x2/NVsivxvGAh+9827+96ASDuVx6K3NGdMHZzD3U4aBWh4ksp XbGnxtT7Hkj3HAm8pCiqo+xl7AFE2FfDx5pookEXuc/nFmE0Mp0k4FH+e73QkNPoyLot jlug== X-Forwarded-Encrypted: i=1; AJvYcCV0avj9MY/eucPV2AUzUVGr4l/p5j+4OXpPrKOX2q1clFqX4f3kkf45kHdrLFt24wTMHXxudDT8qR00NPwN3zhiJk0= X-Gm-Message-State: AOJu0YwcbO/yGPFQnDS6jC7RTxaMNcWatGO0OvP3ShftXgvVQ5FA9id1 46XnMN5OyVGHd0yt0wPuJHsGqBTdcEabqzgKENXVF1+HQ8S6WA2ba2+izFB1Z0yO3mbLJ4goVuY lT3QOGwitK7A2mZMzv4puK3V2opPW8HwxjFzsQ7XPJT37rwdD X-Received: by 2002:a0c:f3d4:0:b0:68f:a59:1216 with SMTP id f20-20020a0cf3d4000000b0068f0a591216mr1190724qvm.50.1707993786027; Thu, 15 Feb 2024 02:43:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFte3jUXgsQjEwGNjWUY1CBYrm9xQ6Kr/3wAjZMWIx5O2ISAeI1pj/H170QLB8FxdTao4yy5w== X-Received: by 2002:a0c:f3d4:0:b0:68f:a59:1216 with SMTP id f20-20020a0cf3d4000000b0068f0a591216mr1190707qvm.50.1707993785672; Thu, 15 Feb 2024 02:43:05 -0800 (PST) Received: from ?IPV6:2003:d8:2f3c:3f00:7177:eb0c:d3d2:4b0e? (p200300d82f3c3f007177eb0cd3d24b0e.dip0.t-ipconnect.de. [2003:d8:2f3c:3f00:7177:eb0c:d3d2:4b0e]) by smtp.gmail.com with ESMTPSA id lu7-20020a0562145a0700b0068efbe2235asm535657qvb.54.2024.02.15.02.43.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Feb 2024 02:43:05 -0800 (PST) Message-ID: <6ff877c4-dc97-4572-b45c-2384c1d40fba@redhat.com> Date: Thu, 15 Feb 2024 11:43:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 05/18] x86/mm: Convert pte_next_pfn() to pte_advance_pfn() To: Ryan Roberts , Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Mark Rutland , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Cc: linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-6-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240215103205.2607016-6-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DF78DC0010 X-Rspam-User: X-Stat-Signature: fwtp79armc9uzsnzdkqf3sxrnr669p3o X-Rspamd-Server: rspam03 X-HE-Tag: 1707993790-71243 X-HE-Meta: U2FsdGVkX18Pkj4JoEbPNdTbjsX6gX10VDll1CS2laPtGQv1oYWUW8M0VTP7d/L1hESAOSFWJMLTv71uSwl6PMxyVBUC3AHUQ5Om0V0ZEuyZjnTXpdZMk3W5zMcemD4/UC/o4spGvg2FuRy2kafq0kqgOWfYnIvRg2YFDaMBJF2/O4fT5qK84rliuoT0v0OzddYrCGlmqIh4AUQMWN9VuPMsP+Ur33pgAbwxdnxPYo1kDY0GnZZOzJJfJxKK4QFAxJOX11hOw9y2UFh4nU3fcoRwCdi5YUV4mzwLise5CPJT9qSPbNzgh7NRr5nP0wobeNVDpCH+zxFW/UlBNpcboNzWq9n4uj7zuLJq/AqRdtom6M2Bx6BuJPYwDmzISg5N5OLVaNQwrorepFft6dgaVyBeTsVl642U+ykf/HNU5sy4II3meh5vEHdeGDd3I9XYjHHe3xOibTXXong/kOgmC3QUvP74qTBEsYC6sgKCJM+VG3v1GR81bnIPrOZOYLlFwc/QtIAYGmg9DKDfMsZQ5Ysq8A+3+wab3LGS6QOrcbIuJG7lltj7brKvEQ8HS7HwZMyt7O4WUtlehMSuTdci94Y1rLYGxmOt2yP1llPP5+KOEGOFXo7jipk3rJZD5C6tIVXXE6yEvPZvCuJR20F+MB9Kjn0R+ZFbdwg/FcEXCmiTYAocnfk6opCrf8hZSKufvEcCQYkI5sjb2fdrVSfZEqcp6yAIDJlZn/Aa7dEdxZrpys9TdfDqS2XIvr+ph/8ybqztB06j5C65OhWvVwG9ZdYS4eyO8TNYFYmD+T1owZ9q//qpFzFMSfuU72X0+hQPYgeGUbvAqbegmJtJ2UfH4z5JbyBH+7S5jUi/VPXNO93jUqnxJGwpkhGHUOpGHrg5lhyYjjE6Fd2yvaJPE2lm2q/kqD5UkeQTa+q/aJ6VW/a1V+9CU2XtPAfAa8AQPLEAhxcAPI5rwbhC5sS3tiz SqpHJFIx 5Gq59nHMwh5khuv8lNq3dHvuV1FME7jTPc2NlpqLsJAkGvWXfjVinQg/QglF8Yq2nBVnpPXje1iMO8pmfZKwsu+rnRHdyQqb+fq/FXOdn80qgwsH3awX5weiOnOqBC421HKZ/4LNzsosMHMP0JBH7WQ8M7LllXrrBw4M/3aEblf3GHSRXidG+Y2g5mE1tcBEaRjSPtNIPrrdLoI5NHp/9COnbPb8LbdK6YdDqPNQI9nO7WlM1cXXu8bG6jN4kttTtTWdIt/TdQEH89QJ9J8Rf/P3AlZEKjQXD1yaoGg1hNDraMMTXjkRZSvVglAHKQ8CIDoUIncu7/ZcU26O6HybJ0mEVMY4iDuFnybHyitFPzvrKfw6/BVj7xTn5Im8Djq+knfH4IzNgOGyFx2p+HIq+cpKVHb705pgM9zwC5Z7jAb5tzF6vdIM3Yp/+MRmrASGpvGsE2UUUcVJbBG5W1HxWisQrCHuoVeFHP7T4TxneCjjk0yErc3FSSCIlwf+ZQoVm0ts3MlS/OMeIQzHngkeoVgqMKkuClbh48RXve0/wEhvSxYYG50A6TemT3AznNR31m0Ll9xZ6FPtSnJyfxy+ljvk3C3h7fEcl6Iu91E3B6RkoFlofte3WP5mJSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.02.24 11:31, Ryan Roberts wrote: > Core-mm needs to be able to advance the pfn by an arbitrary amount, so > override the new pte_advance_pfn() API to do so. > > Signed-off-by: Ryan Roberts > --- > arch/x86/include/asm/pgtable.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index b50b2ef63672..69ed0ea0641b 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -955,13 +955,13 @@ static inline int pte_same(pte_t a, pte_t b) > return a.pte == b.pte; > } > > -static inline pte_t pte_next_pfn(pte_t pte) > +static inline pte_t pte_advance_pfn(pte_t pte, unsigned long nr) > { > if (__pte_needs_invert(pte_val(pte))) > - return __pte(pte_val(pte) - (1UL << PFN_PTE_SHIFT)); > - return __pte(pte_val(pte) + (1UL << PFN_PTE_SHIFT)); > + return __pte(pte_val(pte) - (nr << PFN_PTE_SHIFT)); > + return __pte(pte_val(pte) + (nr << PFN_PTE_SHIFT)); > } > -#define pte_next_pfn pte_next_pfn > +#define pte_advance_pfn pte_advance_pfn > > static inline int pte_present(pte_t a) > { Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb