From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AA6DC4345F for ; Wed, 24 Apr 2024 14:58:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C558F6B02AC; Wed, 24 Apr 2024 10:58:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C057C6B02AD; Wed, 24 Apr 2024 10:58:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7F4D6B02AE; Wed, 24 Apr 2024 10:58:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 893A36B02AC for ; Wed, 24 Apr 2024 10:58:18 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4A9B781043 for ; Wed, 24 Apr 2024 14:58:18 +0000 (UTC) X-FDA: 82044731076.01.DBCD5DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 002971C0011 for ; Wed, 24 Apr 2024 14:58:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eeg8Clsc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713970696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nJhlqeBNmwWNfn0uY2vec6oGf1Jwqynj84aMoMG9ITk=; b=X7Fdr9bibTVVma7/9igUIfc8fGegG03/e7+DcvjrZt5Kr5E9NYl8uMNFarp9zdV14HSyO7 9V4TKUa0dznbLm3m6BhKGjgdlf4RvLzScflULPkyRpTYI2lF7PK1mF0OFll5nV6NhdhzbK 5G6VBP9lzBUcvzsSRpNywL4qwdsug3w= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eeg8Clsc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713970696; a=rsa-sha256; cv=none; b=v2vBVl02FxOKB/XJh+/wFe/V418XcKn+ui32Hw16Pp6edcDF6C0KXbtNVM45wzko6BQlqQ xyZLT4+kWnnD/9VbESAbR7yJXxKqnHB8WYkjhwt4W89nHEHqzzS3B+XlpFViqDJPCquJ3F vc0sYJCGK0Lh1zZIDoelJGm3SsMr6qs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713970695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nJhlqeBNmwWNfn0uY2vec6oGf1Jwqynj84aMoMG9ITk=; b=eeg8ClscsZ7alB5JT8d4vnUWWRwi1J+FQS736goh2UJugpDAqubCbv2gnN43A36+Bn1kZD WGYthpqUs5+/pBFtqzTqFNfW4BMZqamP9FNlaCxGRbTNZ1YOG4EgD5d3K60b+HvUCFU0Cg RGUYh3Nal5HFCBsegLyu/20i4ZDrL4g= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-ZaKBCfaWMeafUTE3RcgIeQ-1; Wed, 24 Apr 2024 10:58:13 -0400 X-MC-Unique: ZaKBCfaWMeafUTE3RcgIeQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-34b3fe78c59so2023807f8f.1 for ; Wed, 24 Apr 2024 07:58:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713970692; x=1714575492; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=nJhlqeBNmwWNfn0uY2vec6oGf1Jwqynj84aMoMG9ITk=; b=vMh5aanYQ7DYiyEVDiCXiR+ZkmuzdSdLyAY8hEQQlRZqfHF7NubkK6LfsFUlaAHLKE Sm8kPVPJGSiX5wiyPiPGOfA3TfrdXDXvsuoCFR1UrEwkXDXruZrD6jmKyirxi+fyboeS yvFV3jFrmdBRggOuK4GpoS5+VjIWzWE1B9/FtS4kCI1iPkpkTQXskjlhDNzMk/Os5nb3 uNWN1PxbM+bvWqoSjehFQ58xT4A6s8kCvb/hKwuIivNYgwdTJkTHi9QcIEU1EKrMERq6 yRXSpTb4alCzelxjtYkoLwK8Q4XYn2jLOz1x2boS7grt8onfD3ULJFsqadAXEpIJhUId O+6Q== X-Gm-Message-State: AOJu0YxuKh8FgopyyQxyGCTET6M0dDddw0qV4jpHOb+NnLESNsSZVPcb JSzY9oxfOuavMN5SNrUM+gwmRj6IC3TvXeh3YUbCWTs+xE06Cr3d1F9p/qeQertz66obAbGhlXs g27/jfNqvn6IPfFkSJZ52SctTghG98E8ud0Jzd4IpP5eRK9W/ X-Received: by 2002:a05:6000:707:b0:34b:ef9c:c994 with SMTP id bs7-20020a056000070700b0034bef9cc994mr157274wrb.60.1713970692482; Wed, 24 Apr 2024 07:58:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHifwr+0lYcI3nUtzyos4sBvzwcLhg6pzmB4gCmUb2B9eWYRtC1yZryY8jyI4yFkbRE4ESIQw== X-Received: by 2002:a05:6000:707:b0:34b:ef9c:c994 with SMTP id bs7-20020a056000070700b0034bef9cc994mr157263wrb.60.1713970692212; Wed, 24 Apr 2024 07:58:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:1f00:7a4e:8f21:98db:baef? (p200300cbc70d1f007a4e8f2198dbbaef.dip0.t-ipconnect.de. [2003:cb:c70d:1f00:7a4e:8f21:98db:baef]) by smtp.gmail.com with ESMTPSA id b4-20020a5d6344000000b00347363b77dasm17259421wrw.33.2024.04.24.07.58.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 07:58:11 -0700 (PDT) Message-ID: <6febd97e-20ca-4396-b7a4-c361e7608d8f@redhat.com> Date: Wed, 24 Apr 2024 16:58:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: add more readable thp_vma_allowable_order_foo() To: Ryan Roberts , Kefeng Wang , Andrew Morton Cc: linux-mm@kvack.org References: <20240424140715.5838-1-wangkefeng.wang@huawei.com> <2e878f93-2b45-401c-8ee1-00338e22866b@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <2e878f93-2b45-401c-8ee1-00338e22866b@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 002971C0011 X-Stat-Signature: 4riwcs7316e15wzdad6wzgxnt8tcbgh6 X-HE-Tag: 1713970695-341252 X-HE-Meta: U2FsdGVkX1//tS/pKEies6pa7HuXADN7nTBllmO6lpYZPwJOp/MiNkoE0eCAjoA9IOQ06wxnNTCV6YfrYMoKBBv05rA4ohuLIq88OpQaJL22cI98aq2VxYWgg4LKiWuAkPopxoJhh/lLZCa9n0uNSBgOW9CX16S1JF4Ap/hDDKZN16M/e8sXOqLG8iSGv6KXQpy1oWQrGKiQic//9uiAmc8KK4Q4C2/tK1wVGsVV7l9ZUxUmiX7veJ4ySueiKtPEntmJplfKCGUuQnyKEm4HeWkPrYS/Bci2teN9Ny7HB1CXMUZNxyMA5JjaELD4maKTUlOAlSmRgvk765vtzeba2NN/oZVaaJXrFNszVYBFUq/s8kFSk46KZzFfcZ1KOjt7NpU17Dbr2i5s/EKqdM+T8riZwcXawl7uEW3OOygF7hoZyDmuz7lrezw+8LhZfjk5pWvgQ+wr+1/8dWfylabIjaaGLI6hupbQAStWYjkVdUHh02REH5zfnEMtw0VMhL+TYBOfS0Tcl86nyB2NyeX/qHrv/moCjOrPC/izH2T8hE3ZrFinb1q/RwZCHZFyrh7J5t2D8hB8ZZvBcgxXdh42lSppucoGenYniJTtzDeclMnNzvq7uzj4bweL2nuNajFGTuRGDyroQJhV0MP3xcpux2F3vnvUMGo6eSyNoF+0sF9HqUpZuJSJJpSwBLqjzAGSU5rX6aTiGP7Pt68EKTQ8rjiGwMBUbzvami2ib5MchNM5Er4IfIRmfAxS+LFO2h55Cq3pOnwU3eBUnhJbJI8JiK0L3JuaUC3Mzzy+zT1tqXn72h6VkU1UhWmvxBNRSu4dcSBdUMNtNs1LXXS69BfstUrxTp8rsbcFwaFA8W/HqXopzOc7HDm1IgwCVNgqKOOs5SCOe9agtSRlA4SIUH22qG1KUcKpUXbzCLYga6mZsRLo9jmyEhdjSwCwiQe7epKUt/GZpJLf3Q/KEC1efcA Gwr/RtBU 4ROJiF/iljIdQpB17NU1fS8dBWPZW25w9Qemn0GyISKbvgpz7qC28JlNxD0kGZ9f9UrSNHfuREYENWOJWt273FC9WwjorC8JO2j4M43WFKmMu6zTPJ779Rd3KHHd45GuNmWqBR85il91dIj2DjkgdREujsOGAEDkrKGHDX7IK5AHWaeEbsWXynvUE6liNSHPGvtrCSpZtNR7/esxdC7kY4kjxFMRDXCXU7mdr7YH6N1+RClDGmnzGb0gSpfQXvusADTlLXtWW3a5tGygkWyKdlBHtkYbW0Ae/12ErF8jprxNFrOTe9KVLC9wz/L0CZbD3oPC94eAcO43j5ZJRPTr/dQSIQlKntMvwPP5Kic/vdMBf4V//AIn4i7Rwam94fgIb7tT2+6aJGI2xZIVaCAJlFXzKSHHh42bPzpAdJWdi/gVXi1AjgSqOjjGldUmJHPbanbeiwa8gfvj4PKa4ycxznS8FwT2EIp67uXzH3gMvITzPGHhZ8ASRC+3jkNQLfj+n6asvOmjov3QS7U6g7JWfmYcn53qM53WcGFYSmPX9z7XE6+k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.24 16:05, Ryan Roberts wrote: > On 24/04/2024 15:07, Kefeng Wang wrote: >> There are too many bool arguments in thp_vma_allowable_orders(), adding >> some more readable thp_vma_allowable_order_foo(), >> >> thp_vma_allowable_orders_insmaps() is used in samps >> thp_vma_allowable_order[s]_inpf() is used in page fault >> thp_vma_allowable_pmd_order_inhuge is used in khugepaged scan and madvise >> >> Signed-off-by: Kefeng Wang > > Just one nit below. With that addressed: > > Reviewed-by: Ryan Roberts > >> --- >> fs/proc/task_mmu.c | 3 +-- >> include/linux/huge_mm.h | 14 ++++++++++++-- >> mm/khugepaged.c | 20 ++++++++------------ >> mm/memory.c | 8 ++++---- >> 4 files changed, 25 insertions(+), 20 deletions(-) >> >> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c >> index f4259b7edfde..1136aa97f143 100644 >> --- a/fs/proc/task_mmu.c >> +++ b/fs/proc/task_mmu.c >> @@ -871,8 +871,7 @@ static int show_smap(struct seq_file *m, void *v) >> __show_smap(m, &mss, false); >> >> seq_printf(m, "THPeligible: %8u\n", >> - !!thp_vma_allowable_orders(vma, vma->vm_flags, true, false, >> - true, THP_ORDERS_ALL)); >> + thp_vma_allowable_orders_insmaps(vma, vma->vm_flags)); >> >> if (arch_pkeys_enabled()) >> seq_printf(m, "ProtectionKey: %8u\n", vma_pkey(vma)); >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >> index 56c7ea73090b..345cf394480b 100644 >> --- a/include/linux/huge_mm.h >> +++ b/include/linux/huge_mm.h >> @@ -83,8 +83,18 @@ extern struct kobj_attribute shmem_enabled_attr; >> */ >> #define THP_ORDERS_ALL (THP_ORDERS_ALL_ANON | THP_ORDERS_ALL_FILE) >> >> -#define thp_vma_allowable_order(vma, vm_flags, smaps, in_pf, enforce_sysfs, order) \ >> - (!!thp_vma_allowable_orders(vma, vm_flags, smaps, in_pf, enforce_sysfs, BIT(order))) >> +#define thp_vma_allowable_orders_insmaps(vma, vm_flags) \ >> + (!!thp_vma_allowable_orders(vma, vm_flags, true, false, true, THP_ORDERS_ALL)) >> + >> +#define thp_vma_allowable_orders_inpf(vma, vm_flags, orders) \ >> + (!!thp_vma_allowable_orders(vma, vm_flags, false, true, true, orders)) >> + >> +#define thp_vma_allowable_order_inpf(vma, vm_flags, order) \ >> + (!!thp_vma_allowable_orders_inpf(vma, vm_flags, BIT(order))) >> + >> +#define thp_vma_allowable_pmd_order_inhuge(vma, vm_flags, enforce_sysfs) \ >> + (!!thp_vma_allowable_orders(vma, vm_flags, false, false, enforce_sysfs, BIT(PMD_ORDER))) > > nit: Personally I'd leave the order as an argument rather than encoding it in > the name. It's likely that khugepaged will grow support for non-PMD-size Agreed. > collapse in future. The first part of the name "thp_vma_allowable_order" is then > consistent and easy to search for all variants. And perhaps "inkhuge" is more > precise? "_khugepaged" or something else that people can actually parse and understand. -- Cheers, David / dhildenb