From: Vlastimil Babka <vbabka@suse.cz>
To: Baolin Wang <baolin.wang@linux.alibaba.com>, akpm@linux-foundation.org
Cc: mgorman@techsingularity.net, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] mm: compaction: drop the redundant page validation in update_pageblock_skip()
Date: Tue, 30 May 2023 09:27:59 +0200 [thread overview]
Message-ID: <6feab6b0-ec49-8651-bc8e-14ec40249017@suse.cz> (raw)
In-Reply-To: <5142e15b9295fe8c447dbb39b7907a20177a1413.1685018752.git.baolin.wang@linux.alibaba.com>
On 5/25/23 14:53, Baolin Wang wrote:
> The caller has validated the page before calling pdate_pageblock_skip(),
^ u
> thus drop the redundant page validation in update_pageblock_skip().
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/compaction.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 163e2ec70aff..426bb6ce070b 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -436,9 +436,6 @@ static void update_pageblock_skip(struct compact_control *cc,
> if (cc->no_set_skip_hint)
> return;
>
> - if (!page)
> - return;
> -
> set_pageblock_skip(page);
>
> /* Update where async and sync compaction should restart */
next prev parent reply other threads:[~2023-05-30 7:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 12:53 [PATCH 0/6] Misc cleanups and improvements for compaction Baolin Wang
2023-05-25 12:53 ` [PATCH 1/6] mm: compaction: drop the redundant page validation in update_pageblock_skip() Baolin Wang
2023-05-30 7:27 ` Vlastimil Babka [this message]
2023-05-31 1:44 ` Baolin Wang
2023-05-25 12:53 ` [PATCH 2/6] mm: compaction: change fast_isolate_freepages() to void type Baolin Wang
2023-05-30 7:29 ` Vlastimil Babka
2023-05-25 12:53 ` [PATCH 3/6] mm: compaction: skip more fully scanned pageblock Baolin Wang
2023-05-30 7:59 ` Vlastimil Babka
2023-05-25 12:53 ` [PATCH 4/6] mm: compaction: only set skip flag if cc->no_set_skip_hint is false Baolin Wang
2023-05-30 8:03 ` Vlastimil Babka
2023-05-25 12:54 ` [PATCH 5/6] mm: compaction: add trace event for fast freepages isolation Baolin Wang
2023-05-30 8:24 ` Vlastimil Babka
2023-05-25 12:54 ` [PATCH 6/6] mm: compaction: skip fast freepages isolation if enough freepages are isolated Baolin Wang
2023-05-30 8:32 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6feab6b0-ec49-8651-bc8e-14ec40249017@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox