From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFE55C41513 for ; Wed, 18 Oct 2023 07:37:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10EC28D013C; Wed, 18 Oct 2023 03:37:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BE8B8D0016; Wed, 18 Oct 2023 03:37:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEF968D013C; Wed, 18 Oct 2023 03:37:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DD3D28D0016 for ; Wed, 18 Oct 2023 03:37:44 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A600314017D for ; Wed, 18 Oct 2023 07:37:44 +0000 (UTC) X-FDA: 81357777648.11.3832F38 Received: from out-206.mta0.migadu.com (out-206.mta0.migadu.com [91.218.175.206]) by imf08.hostedemail.com (Postfix) with ESMTP id 3679616001A for ; Wed, 18 Oct 2023 07:37:40 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GD9g58o9; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.206 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697614661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=foiCuM1H7ljhyJH1H/r+XAx2HhX//BkMMbSuBQo9fHc=; b=tD3FmVjrHBNFzyaKhxRn5zAYWkKU8hx0qKUH11GjaImQ3hdZcWzPJJHDQbA6Hp13ECvwA4 9JYBGpGf2gyzzoj7erR1+NHQtcJYAPTVYztSpAJneDj3CTjj7hQj3ItuEkuMeS31nOUUbU gLTYl4AU8eKqjUevjlZWmtpeJaEc2E0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GD9g58o9; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.206 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697614661; a=rsa-sha256; cv=none; b=PruOYiIPcFevFUMfszQZwOuyGKmlGp5+/5yfYZatrw++AhfrTYWkzP4rjYSXKKc291sLdI aAN+SnZY+zqna7lHVcxesgu18vqHugiwlgyyf958NUBxIHrnWIAKB9AYYe/gbtakFBUqyX WjgkN9rwXATGt2KkwgVJfnydmXWOryc= Message-ID: <6fdb2e74-2918-4cd2-bbda-f00745b03b97@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697614658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=foiCuM1H7ljhyJH1H/r+XAx2HhX//BkMMbSuBQo9fHc=; b=GD9g58o9Ib0PEYOKxZHm/qm0HvTmWCnn2WxHVvnrlecED1sl9Q9Y7vSRp1xOMFPUylP138 Wxgnw7qZh78PzRrVX7deqYD8HOlReBCO0vwZqvoweQBC5muS3aCyrQAH0ia7hLleHlGI8o palR01VPvGo5OxcXcthkMzEtu4d0GAA= Date: Wed, 18 Oct 2023 15:37:09 +0800 MIME-Version: 1.0 Subject: Re: [RFC PATCH 1/5] slub: Introduce on_partial() Content-Language: en-US To: Matthew Wilcox Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou References: <20231017154439.3036608-1-chengming.zhou@linux.dev> <20231017154439.3036608-2-chengming.zhou@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 3679616001A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 94cnmyfw733ebz8k5axc4s44cxw4bqug X-HE-Tag: 1697614660-755134 X-HE-Meta: U2FsdGVkX18WhRHxj1BEqjN6Djs9viRzmomTg1hzCSdERmd7SnLmbN/fOIspnzkkznTML8AGKTMR1HJLPUXrSISbqjiRx5nuGShiUphGQveDyD4Qf5rbUhKTi6SIxbBD9yB+Ni/MwDaW38rHObaPZQWIAYeLTxOpjOle+uQu3y4dTnv7U/v8TC0hB7LL0LGKKavthoUgzx9QMCqR8h75Iw6x2xckC2uGiNepS9cm9asKfIDi96HfUWwimrDW4YVakq4cZK2VLmb3lTzu9TimMw0MGYs4djGM4yNkCE7XIlzUlh1ttCkkewhqw+cgtodPKTrgyaKnqBYJKVR82tjzAlAyWMpLzpivkogjux3bbdcVgfqCYzL51FBLvdlFzVWLeZAwdjQBNCz0PrsYA0LNi7EOcojEKpTSoYZFNO8yph1aDdOWXvQ9/D544erAptbpWXH3WiNfz/s7glmkguRyaPS86AQSL4ooXf3oxtSzkUD4UPzJVh4dq4/swLMHpFrUoZQn2yNdFY3/t4jlGYlA6sb2flPOr1b4Z8O6uPnbXv4Rdza4KZR7q72fxnrFqcjeCjYD3pwz27JcC7EjvoG9ENrCJHzzgKoI3hgS/yifVPtZGsNAU/eK4dNEWbvr2NgQWN//c3LkFKqapuqCa5ChYP/7p+jBDmFMVuvr53wA+FB+uMzx9YAzG75Ef9YR8CJWMiRsDcs9FZwtxGweQi6p7QOGHlhSCZoZ4IvfK6j9J9RSlRKKRN+Lssym7oqS2Pm56TYglGM4v4qPU9Rn+hqWZ4871hU8Wsort+8D7kgEyx82sX+LlZMdgCaCysthlKFNFwQsyvwtDfyJ2asJUgoRqtsnRkPeNJJWbxntyNLfmneoR5EEGlrDHIv+4T/yUOhR3Is7ch9ejAZWXM139rSEjyFisS8f7/3+a1I0cy1IDg+aVeRPwd2xBfdVwdh/K2SmehgpBzDByWNzuUnmJx9 D2tLFHiP 1ewFmot52IoEMHrEPPsj6e0chP/cNY0SkBaTXJgXKCacSuExfXUf+xZ7y1C601i4w1Z2N/I7OZ/uKt2HSxT/PuA5J5ZOiH/dfwt0uTCEXZF+11+lGm809pAyUTDt4E7fzkkZ1yVLUbdL1lobEBBWmNWfi4KgJyAjA9Smy4oNqV4kqiYz/K+ZUXVR0+xwCtkmcw1wE/g1v1QkfPRH3lFnu4Ozpeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/10/17 23:54, Matthew Wilcox wrote: > On Tue, Oct 17, 2023 at 03:44:35PM +0000, chengming.zhou@linux.dev wrote: >> We change slab->__unused to slab->flags to use it as SLUB_FLAGS, which >> now only include SF_NODE_PARTIAL flag. It indicates whether or not the >> slab is on node partial list. > > This is an unnecessarily complex solution. As with the pfmemalloc bit, > we can reuse the folio flags for a few flags. I would recommend the > PG_workingset bit for this purpose. > Yeah, this is better indeed. Thanks for your suggestion!