From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E62E784AF for ; Mon, 2 Oct 2023 09:43:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C32FF8D0014; Mon, 2 Oct 2023 05:43:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE3C68D0001; Mon, 2 Oct 2023 05:43:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD1D58D0014; Mon, 2 Oct 2023 05:43:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9DEA58D0001 for ; Mon, 2 Oct 2023 05:43:47 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 70EB5C01AC for ; Mon, 2 Oct 2023 09:43:47 +0000 (UTC) X-FDA: 81300034494.02.5C74C03 Received: from relay.hostedemail.com (unirelay06 [10.200.18.69]) by imf06.hostedemail.com (Postfix) with ESMTP id AFDCC180009 for ; Mon, 2 Oct 2023 09:43:45 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696239825; a=rsa-sha256; cv=none; b=X5itz/11rKtMad2XMLFpqVv78LzLVv694IlCUP6KSabAO+3uuXZmLff5Py7dkomFfBpmLT xKpyrNZOJo8G9/1iHXoVk/KZupFcifFeqcOKmk3Og/H6t4oxjpgnPyQkeVy15TggzOLDhe 5IIzdem4C16SCByJ1Mpt+ux7d9sq2ME= ARC-Authentication-Results: i=1; imf06.hostedemail.com; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696239825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k5MTBkQ/QNGYOJWtLSndjau1iV249grF8QvQZaXVC/w=; b=KBT7/+N0tyg2U0voTS0Suk2sQING9Mk7xdQWEgNtiS9D9H2wwpYhlfBo5zaOyb0pYFX5KD D9K3pAvxsOxScTfs4XDWHm83tY3anC7y9xqpWbuMkuWGlP0m6JlTGPJi20SmT1a4rFBt+P YoMI2PAykTJLmKJcH/aNkXJ1cPCYr4g= Received: from omf12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A4F13B389F; Mon, 2 Oct 2023 09:43:44 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA id 32EC118; Mon, 2 Oct 2023 09:43:42 +0000 (UTC) Message-ID: <6fb3fa0fe3e53d6e31c8ab6f96a9549da1d659f0.camel@perches.com> Subject: Re: [PATCH] mm/filemap: clarify filemap_fault() comments for not uptodate case From: Joe Perches To: Vlastimil Babka , Christoph Hellwig , Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , Jan Kara Date: Mon, 02 Oct 2023 02:43:41 -0700 In-Reply-To: References: <20230930231029.88196-1-lstoakes@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1927gKJYw892B+LAQerRFB3HJXUDRHeCwM= X-HE-Meta: U2FsdGVkX19IapDL28MSH5TXRBy0nJUW3yFP7+EJNp5Tre3L6r0j4z7/1bxenjmZ2my0YL6N3YIykdfJRcreF+nhH2BkKDaKxLfAUkF9RVJWt9P8EbpoY3F3wYxQFmdVoCH17kwKtrIgRaYD235u6jVg4TwpAkcXBztUMN7WyURtxdb74OpqshPvL/pu5R+wopPdd6mFMRkMspS3klk9uQr4nrqqGuI+B4sRXXBNp2jDqdAYheF56Ds6uX8A6EReebhZLw1FCbo0ID4K1guF4FPpbh8VQKIoGMyLNR0NfS3kcq+1HaAJqFEimf44RFA/XNiOs2G481BLFd+QvVsJln66K3p325sRcrGqRHEgT0tqZ0mRE9wcWKMPKfM03obGmrgxYenxyTVnegsRSWfXHDfu63VXPMBnFZC0FRKy0xX6VLVhd0g2QA== X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AFDCC180009 X-Stat-Signature: b8cedzsf9hmbj85bmf9d5rtcxw1fuprd X-HE-Tag-Orig: 1696239822-221708 X-HE-Tag: 1696239825-321095 X-HE-Meta: U2FsdGVkX1/CBQUuHnB0icIEHKKj/ogaSUgGW27zQytw8I8PiYDPPDR1Ia5ATWS/jh5PGioeMrmSCQGByxuUR6Y6Rz1KGFPev1PI1DmReoa8zzs/Gc/9zfW0MZNPV3uJKYcGUCgJL1y3VXoKe12nLz3ZFRjY32lKtpzv3jrPc22eN9u9HuT5J9V/POBiILMvSvscMhHG6GwglZcmPXfG61uDZWw68KMneK2pSRBdEhzP88/z9haySW9i2tYkvst9B9TH2QmZNDd26cRgE9z5AQiR7H9SHNXaRQpSR9Zl5ldZxBrMsOKSSBVV4oE2aTySSk2mThz8j/xYH4/Tdo1pkqSIpyvqccO5hsLMnIC0I88tPlz8P05Z4RwLXEgwfnjChh541iz8dwl6wG+DKwip8MkD+agR3M1chhTM7306jhMOkViOcGw3O2TvDMX/I0ix+RRbOJU7yT6kGZQ3IkBMY7FnNpIOfUSemvR4xzlh0DmSjybzXrkk6H38aCILD/AAa1S76cQAYUYIoW5dxwL3S7kHeY8E1EfN9dYEylXqLpUXML5gatc5AGoME+zFKERvxEzuPJyXh3PBJAcD7sTc78DLupOHQPnnTAiTdQqUw7x83aTYQ2ECyd1uZ5fICvOvqXLRHCoBiiswDJnVXhZdhpcVq4vz9ZlubS6ezeFsSrpOnQAUpbpA8vZY7wKMcEICBlt3WlDxZUdWdmXB74CCdsOs/G/GXd5aZK+lpPKwM7daRhtv8SDEgN7D61ocyabtUGf+6X8oXGq8kKkyO5YJxFiSpdSlnSCx+NlJIfTWgg3/mVDGc4UHyVZ1i6AtcsMrxBRJ/6cE0Pg4XcrKTVob7hysJsZOD63JwTcYRz/jIMvJlG0GUKh9Qh4Ruc++j7OZM8aDl/CPP9nD/adBxHmtL78R28CetArcnFfuPzBB+aytdjt3whsyC/TtCaDFotVAkbHwQejNUT839NIzen9 JH6zjzAx PREUMOm0OPqH59SEkUFJJdttB1a/36Bsx3MRZFjMkGdQBPXDCZf1HoXygtT6lvMhms4jT6P47PSXnTXKz4r8TySKBOLkMd8Qeq73bf9kDt5EiKYl0euRh8Gp9uQZLWErK0yMg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2023-10-02 at 08:39 +0200, Vlastimil Babka wrote: > On 10/2/23 08:26, Christoph Hellwig wrote: > > > + * If the invalidate lock is not held, the folio was in cache and > > > + * uptodate and now it is not. Strange but possible since we > >=20 > > Please don't spill block comments =F4ver the 80 charater limit, that ma= kes > > them impossible to read nicely. >=20 > Joe, can we revert the default to 80 to avoid everyone having to alias > --max-line-length=3D80 locally? Given the current --max-line-length default is 100, and that was Linus' preference, I think not. https://lore.kernel.org/lkml/CAHk-=3Dwj3iGQqjpvc+gf6+C29Jo4COj6OQQFzdY0h5qv= YKTdCow@mail.gmail.com/ and https://lore.kernel.org/lkml/CAHk-=3DwjR0H3+2ba0UUWwoYzYBH0GX9yTf5dj2MZyo0x= vyzvJnA@mail.gmail.com/